iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

should the size be verified here so it fails early?

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

why does it fall back to this?

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

is there a clean way to work this functionality into primitive stuff? If not, would it make more sense to just put everything directly in here and skip the generic primitive stuff?

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

j instead of k?

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

if these can panic then there's probably a better way to get these values at call site, eg. separate page handles & primitives from textures

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

if textures are drawn completely different from primitives , shouldn't they just have their own shader that shares the layout code?

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

why isn't the standard write path used?

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

comments too verbose everywhere. Please match the existing code with minimal comments. Set up a review at the end of each change to look over comments (& sanity check code)

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

why does this exist

iris commented on pull request iris/iris#11 2026-09-13 12:27:50 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

use align repr, don't manually pad

iris pushed to main at iris/iris 2026-09-13 03:39:24 -04:00
0f6a28b4dd Move text layout and rendering to Parley (#10)
iris merged pull request iris/iris#10 2026-09-13 03:39:24 -04:00
Move text layout and rendering to Parley
iris approved iris/iris#10 2026-09-13 03:37:08 -04:00
Move text layout and rendering to Parley
iris suggested changes for iris/iris#10 2026-09-13 03:07:13 -04:00
Move text layout and rendering to Parley
iris commented on pull request iris/iris#10 2026-09-13 03:07:13 -04:00
Move text layout and rendering to Parley

let some = ... else?

iris commented on pull request iris/iris#10 2026-09-13 03:07:13 -04:00
Move text layout and rendering to Parley

shouldn't this associated const go in this type if this is where it's used?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

unwrap or else?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

is the *16 the dp workaround? might wanna do more foundational work like do or Rc RefCell rsc before these commits

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

curious if we could type texture handles w a generic. May want to note somewhere

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

vec2?