iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

vec2?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

the common case is true, why remove the = true line?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

should prolly be a method on glyph.entry

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

put pixel is very slow iirc. Can we do a map type thing instead / find a fast way?

iris suggested changes for iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley
iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

didn't we remove family and switch to string stuff? If this makes it simpler for now then don't worry about it

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

what is Option? should have a brief comment for tuple types, or just make a struct if it's used a lot

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

what does this mean

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

may wanna extract this into a function if it's not too many args & doesn't have borrowing issues.

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

should be ctx, not cx

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

change to is empty

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

arc will get removed right?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

is this safe? can a source be cited or explained? is there a built in hash usable?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

same collapse thing

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

what does refresh do

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

move this line out so indentation can collapse

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

no take method in parley?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

unwrap or else?

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

is the *16 the dp workaround? might wanna do more foundational work like do or Rc RefCell rsc before these commits

iris commented on pull request iris/iris#10 2026-09-13 02:27:29 -04:00
Move text layout and rendering to Parley

this is weird, should prolly panic if end > len or start > end similar to slicing a vec