can these if lets be merged?
the kind is supposed to be obtainable from the type. That's like half of the point of the trait
you let old information get into this doc (GLES)
don't think this comment is useful
comments still too verbose. More importantly though, never put numbers like the group number in comments. That's an easy way for docs to become stale
much better. Two main issues here are that the kind is supposed to come from the generic type, and still seems like there's a decent bit of texture specific code being applied to all pipelines. Masks do need to support being textures, however, so keep that in mind.
need to make a named const for the 1 so it's clear what it is
registration order is an implementation detail & shouldn't be relied on. Layers are the proper mechanism to put something on top of something else
don't talk about old code unless you have a really good reason
is this comment still accurate?
don't need this comment, if you work with GPU upload it's obvious
much better overall, but it seems like textures should be drawn separately from other primitives. Interleaving is not supported within the same layer because primitives get swapped when removed. Layers are how you layer things to properly support alpha and blur and such.
isn't there a way to select regions?
please make this a struct return type with named fields to avoid confusion
can this directly be obtained from the texture array?
- please set up a forced review mechanism before you submit that sanity checks & especially targets comments for cleanup to match the rest of the code
should the size be verified here so it fails early?
if these can panic then there's probably a better way to get these values at call site, eg. separate page handles & primitives from textures