iris commented on pull request iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

don't need to comment on the proof

iris commented on pull request iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

you don't need to comment on lack of something unless it's important. Seems like another artifact of responding in the comments rather than keeping them isolated to the current project state.

iris commented on pull request iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

say "use" rather than draw. Draw may suggest the texture will appear, which would not be the case with masks

iris commented on pull request iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

why is Atlas in prelude?

iris suggested changes for iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

much better, almost there. Highlighting text and such does indeed require 2 layers, that should be changed. As stated, you should never rely on order within a single layer.

iris commented on pull request iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

don't include the setup for now. It's better to intentionally let things break so that registration order is not relied on, and it also frees up resources for users who don't need specific parts. In fact, could this be exploited to only iterate over the primitive kinds used per layer?

iris commented on pull request iris/iris#11 2026-09-13 16:44:35 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

any point in this now that it works as a primitive? maybe impl from texture handle for the primitive or smth / PrimitiveLike trait?

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

too verbose. Don't explain fields in the struct comment, put them directly on fields and only if it's not obvious

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

registration order is an implementation detail & shouldn't be relied on. Layers are the proper mechanism to put something on top of something else

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

There's no repr so can't you just derive these?

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

can these if lets be merged?

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

you let old information get into this doc (GLES)

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

same here

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

does it really have to be a multiple of 4?

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

the kind is supposed to be obtainable from the type. That's like half of the point of the trait

iris suggested changes for iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

much better. Two main issues here are that the kind is supposed to come from the generic type, and still seems like there's a decent bit of texture specific code being applied to all pipelines. Masks do need to support being textures, however, so keep that in mind.

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

don't think this comment is useful

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

need to make a named const for the 1 so it's clear what it is

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

how is binding change tracked now?

iris commented on pull request iris/iris#11 2026-09-13 15:48:17 -04:00
Draw the glyph atlas as an array texture and images with their own bind groups

this is one instance of textures being jammed in; rects don't have anything to do with per instance vs atlas