Compare commits
5
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
adbedaf264 | ||
|
|
23523eea29 | ||
|
|
1512d8418b | ||
|
|
0ef87ebfcf | ||
|
|
3091fb86df |
No files matched your search
@@ -32,7 +32,6 @@ pub(crate) enum Counter {
|
|||||||
SizeReads,
|
SizeReads,
|
||||||
HintHits,
|
HintHits,
|
||||||
HintMisses,
|
HintMisses,
|
||||||
RetainedSizeHits,
|
|
||||||
ReuseAttempts,
|
ReuseAttempts,
|
||||||
ReuseExact,
|
ReuseExact,
|
||||||
ReuseMoved,
|
ReuseMoved,
|
||||||
@@ -42,7 +41,6 @@ pub(crate) enum Counter {
|
|||||||
ReuseOutside,
|
ReuseOutside,
|
||||||
ReuseWrongLayer,
|
ReuseWrongLayer,
|
||||||
ReuseWrongNode,
|
ReuseWrongNode,
|
||||||
PlaceRedraws,
|
|
||||||
QueuePops,
|
QueuePops,
|
||||||
DepthReads,
|
DepthReads,
|
||||||
LocalRedraws,
|
LocalRedraws,
|
||||||
@@ -70,7 +68,6 @@ impl Counter {
|
|||||||
"draw-result size reads",
|
"draw-result size reads",
|
||||||
"hint hits",
|
"hint hits",
|
||||||
"hint misses",
|
"hint misses",
|
||||||
"retained size hits",
|
|
||||||
"reuse attempts",
|
"reuse attempts",
|
||||||
"reuse exact",
|
"reuse exact",
|
||||||
"reuse moved",
|
"reuse moved",
|
||||||
@@ -80,7 +77,6 @@ impl Counter {
|
|||||||
"reuse: outside what it holds for",
|
"reuse: outside what it holds for",
|
||||||
"reuse: another layer",
|
"reuse: another layer",
|
||||||
"reuse: region-node choice changed",
|
"reuse: region-node choice changed",
|
||||||
"placed by redrawing",
|
|
||||||
"redraw queue pops",
|
"redraw queue pops",
|
||||||
"depth reads",
|
"depth reads",
|
||||||
"local redraws",
|
"local redraws",
|
||||||
|
|||||||
+35
-30
@@ -1,6 +1,6 @@
|
|||||||
use crate::{
|
use crate::{
|
||||||
LayerId, LayoutHolds, LayoutLen, MaskIdx, MoveIdx, Place, RegionAlign, RetainedPrimitive, Size,
|
LayerId, LayoutHolds, LayoutLen, Len, MaskIdx, MoveIdx, Place, RegionAlign, RetainedPrimitive,
|
||||||
TextureHandle, UiRegion, WidgetId,
|
Size, TextureHandle, UiRegion, UiVec2, WidgetId,
|
||||||
};
|
};
|
||||||
|
|
||||||
/// What is kept of a widget its parent has asked about. `drawn` says whether
|
/// What is kept of a widget its parent has asked about. `drawn` says whether
|
||||||
@@ -9,35 +9,39 @@ use crate::{
|
|||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
pub struct ActiveData {
|
pub struct ActiveData {
|
||||||
pub id: WidgetId,
|
pub id: WidgetId,
|
||||||
/// Its frame in `parent_move`'s coordinates: what a fraction it declares
|
/// Where its drawing goes, in its region node's coordinates.
|
||||||
/// or reports is a fraction of, composed. Everything it draws sits inside
|
|
||||||
/// this by way of `extent`.
|
|
||||||
pub frame_abs: UiRegion,
|
|
||||||
/// Where its drawing goes, in the frame's own coordinates.
|
|
||||||
pub extent: UiRegion,
|
pub extent: UiRegion,
|
||||||
/// That frame in its parent's frame coordinates, before composition:
|
/// What a fraction declared or reported under this widget is a fraction
|
||||||
/// forwarded whole by a transparent container, narrowed by a declared
|
/// of, as a length of the window.
|
||||||
/// length. Its length is the same on every ask, which is what
|
pub frame: UiVec2,
|
||||||
/// a local redraw relies on to ask its parent's own question again.
|
/// A frame its parent decided for it on each axis -- a row's slot, or
|
||||||
pub frame: UiRegion,
|
/// padding's frame less its pixels -- as a length of the window. `None`
|
||||||
/// What of its parent's extent the drawing was given, and what it was
|
/// forwards the parent's frame. What it declared is kept separately in
|
||||||
/// given at the parent's first ask of it -- the question a cold layout
|
/// `declared` and is a fraction of whichever of the two reached it.
|
||||||
/// asks. A part is a length from the extent's start, so an extent that
|
pub narrow: [Option<Len>; 2],
|
||||||
/// moved re-places every child by re-adding that start.
|
/// Where its drawing was put, as a part of its parent's box, and where
|
||||||
|
/// it was asked. The two differ where a container asks in one place and
|
||||||
|
/// places the answer in another -- a row measures from its cursor and
|
||||||
|
/// puts the child in its slot. A part is a length from the box's start,
|
||||||
|
/// so a box that moved re-places every child by re-adding that start.
|
||||||
pub place: [Place; 2],
|
pub place: [Place; 2],
|
||||||
pub offer_place: [Place; 2],
|
pub offer_place: [Place; 2],
|
||||||
/// The box that ask gave it, in its frame's coordinates. Kept rather
|
/// The box it was asked in, in the parent's region-node coordinates: the
|
||||||
/// than worked out again from where its parent's own box is now: a
|
/// box its drawing was made in and the one its contract is about. Its
|
||||||
/// parent drawn again in the box its own answer chose gives its children
|
/// drawing is placed elsewhere by re-expression, never by asking again.
|
||||||
/// boxes it never measured anything in, and the measurement this widget
|
|
||||||
/// answered is the one its parent's layout was built on.
|
|
||||||
pub offer_part: UiRegion,
|
pub offer_part: UiRegion,
|
||||||
/// The measured answer and its dependencies. A hint-only dependency or
|
/// The measured answer and its dependencies. A hint-only dependency or
|
||||||
/// a widget first encountered during placement has no measurement yet.
|
/// a widget first encountered during placement has no measurement yet.
|
||||||
pub answer: Option<(Size, LayoutHolds)>,
|
pub answer: Option<(Size, LayoutHolds)>,
|
||||||
/// What the widget said it used of its frame, the last time it drew.
|
/// Asked more than once in its parent's last draw -- measured in one box
|
||||||
|
/// and then asked in the one the parent decided. The parent's layout
|
||||||
|
/// rests on the first answer and its drawing on the last, so only the
|
||||||
|
/// parent can ask either again.
|
||||||
|
pub re_asked: bool,
|
||||||
|
/// What the widget reported, in window-unit lengths.
|
||||||
pub size: Size,
|
pub size: Size,
|
||||||
/// The frame and extent reads that this drawing holds for.
|
/// The window and extent reads that this drawing holds for, and the
|
||||||
|
/// frame and box it pinned.
|
||||||
pub holds: LayoutHolds,
|
pub holds: LayoutHolds,
|
||||||
pub drawn: bool,
|
pub drawn: bool,
|
||||||
pub parent: Option<WidgetId>,
|
pub parent: Option<WidgetId>,
|
||||||
@@ -63,7 +67,8 @@ pub struct ActiveData {
|
|||||||
/// Its alignment when it was last drawn, which a change to the property
|
/// Its alignment when it was last drawn, which a change to the property
|
||||||
/// is found against.
|
/// is found against.
|
||||||
pub own_align: RegionAlign,
|
pub own_align: RegionAlign,
|
||||||
/// The movable region whose coordinates `frame_abs` uses.
|
/// The movable region whose coordinates `extent` uses when this widget
|
||||||
|
/// does not own a region node.
|
||||||
pub parent_move: MoveIdx,
|
pub parent_move: MoveIdx,
|
||||||
/// The mask its drawing is clipped to: one it set itself, or the one it
|
/// The mask its drawing is clipped to: one it set itself, or the one it
|
||||||
/// inherited from whoever drew it.
|
/// inherited from whoever drew it.
|
||||||
@@ -85,12 +90,12 @@ impl ActiveData {
|
|||||||
self.answer.map(|(size, _)| size)
|
self.answer.map(|(size, _)| size)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Whether what it answered still stands for a frame of these pixel
|
/// Whether what it answered still stands in this window, for the frame
|
||||||
/// lengths. The answer was given in the box its parent first asked
|
/// and the box it was asked in. The answer was given in the box its
|
||||||
/// about, which is what it is checked against -- `holds` on the record
|
/// parent first asked about, which is what it is checked against --
|
||||||
/// is about the box the answer then chose.
|
/// `holds` on the record is about the box the answer then chose.
|
||||||
pub fn answers_at(&self, px: crate::PxVec2, part: UiRegion) -> bool {
|
pub fn answers_at(&self, window: crate::PxVec2, part: UiRegion) -> bool {
|
||||||
self.answer
|
self.answer
|
||||||
.is_some_and(|(_, holds)| holds.contains(px, part))
|
.is_some_and(|(_, holds)| holds.contains(window, self.frame, part))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
+27
-11
@@ -1,20 +1,27 @@
|
|||||||
use crate::{Axis, Holds, Len, PxVec2, UiRegion};
|
use crate::{Axis, Holds, Len, PxVec2, UiRegion, UiVec2};
|
||||||
|
|
||||||
const AXES: [Axis; 2] = [Axis::X, Axis::Y];
|
const AXES: [Axis; 2] = [Axis::X, Axis::Y];
|
||||||
|
|
||||||
/// What one evaluation of a widget depends on: the pixel lengths of its
|
/// What one evaluation of a widget depends on: the window lengths its reads
|
||||||
/// frame and of its own box that its drawing and its answer hold for, and
|
/// hold for, the pixel lengths of its own box, and the symbolic lengths of
|
||||||
/// the symbolic length of its own box where it read one.
|
/// that box and of its frame where either one is what it was expressed in.
|
||||||
///
|
///
|
||||||
/// The symbolic length is a pin rather than a range: a container places its
|
/// The symbolic lengths are pins rather than ranges: a container places its
|
||||||
/// children as lengths of its frame measured from where its own box starts,
|
/// children as lengths of its frame measured from where its own box starts,
|
||||||
/// so what it draws turns on that box's length and on nothing about where it
|
/// so what it draws turns on that box's length and on nothing about where it
|
||||||
/// is. It reaches the parent only where the box it pinned is the parent's
|
/// is. A box pin reaches the parent only where the box it pinned is the
|
||||||
/// own; anywhere else the parent chose that length itself, and a widget
|
/// parent's own; anywhere else the parent chose that length itself, and a
|
||||||
/// pinned this way is checked when it is re-placed.
|
/// widget pinned this way is checked when it is re-placed.
|
||||||
|
///
|
||||||
|
/// A frame pin says the answer or the drawing is a fraction of the frame,
|
||||||
|
/// which is a different length wherever the frame is a different one -- at
|
||||||
|
/// the same window size, so no range of window pixels can say it. A length
|
||||||
|
/// of the frame that is only pixels is not one: it is that many pixels
|
||||||
|
/// whatever the frame turns out to be.
|
||||||
#[derive(Clone, Copy, Debug, PartialEq)]
|
#[derive(Clone, Copy, Debug, PartialEq)]
|
||||||
pub struct LayoutHolds {
|
pub struct LayoutHolds {
|
||||||
pub frame: [Holds; 2],
|
pub frame: [Holds; 2],
|
||||||
|
pub frame_len: [Option<Len>; 2],
|
||||||
pub extent: [Holds; 2],
|
pub extent: [Holds; 2],
|
||||||
pub extent_len: [Option<Len>; 2],
|
pub extent_len: [Option<Len>; 2],
|
||||||
}
|
}
|
||||||
@@ -22,6 +29,7 @@ pub struct LayoutHolds {
|
|||||||
impl LayoutHolds {
|
impl LayoutHolds {
|
||||||
pub const ANY: Self = Self {
|
pub const ANY: Self = Self {
|
||||||
frame: [Holds::ANY; 2],
|
frame: [Holds::ANY; 2],
|
||||||
|
frame_len: [None; 2],
|
||||||
extent: [Holds::ANY; 2],
|
extent: [Holds::ANY; 2],
|
||||||
extent_len: [None; 2],
|
extent_len: [None; 2],
|
||||||
};
|
};
|
||||||
@@ -36,7 +44,13 @@ impl LayoutHolds {
|
|||||||
|| other.extent_len[n].is_none()
|
|| other.extent_len[n].is_none()
|
||||||
|| self.extent_len[n] == other.extent_len[n]
|
|| self.extent_len[n] == other.extent_len[n]
|
||||||
);
|
);
|
||||||
|
debug_assert!(
|
||||||
|
self.frame_len[n].is_none()
|
||||||
|
|| other.frame_len[n].is_none()
|
||||||
|
|| self.frame_len[n] == other.frame_len[n]
|
||||||
|
);
|
||||||
result.extent_len[n] = self.extent_len[n].or(other.extent_len[n]);
|
result.extent_len[n] = self.extent_len[n].or(other.extent_len[n]);
|
||||||
|
result.frame_len[n] = self.frame_len[n].or(other.frame_len[n]);
|
||||||
}
|
}
|
||||||
result
|
result
|
||||||
}
|
}
|
||||||
@@ -48,15 +62,17 @@ impl LayoutHolds {
|
|||||||
&& self.extent[n].lo <= other.extent[n].lo
|
&& self.extent[n].lo <= other.extent[n].lo
|
||||||
&& self.extent[n].hi >= other.extent[n].hi
|
&& self.extent[n].hi >= other.extent[n].hi
|
||||||
&& self.extent_len[n].is_none_or(|len| other.extent_len[n] == Some(len))
|
&& self.extent_len[n].is_none_or(|len| other.extent_len[n] == Some(len))
|
||||||
|
&& self.frame_len[n].is_none_or(|len| other.frame_len[n] == Some(len))
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn contains(self, px: PxVec2, extent: UiRegion) -> bool {
|
pub fn contains(self, window: PxVec2, frame: UiVec2, extent: UiRegion) -> bool {
|
||||||
AXES.into_iter().all(|axis| {
|
AXES.into_iter().all(|axis| {
|
||||||
let n = axis as usize;
|
let n = axis as usize;
|
||||||
let len = extent.axis(axis).len();
|
let len = extent.axis(axis).len();
|
||||||
self.frame[n].contains(px.axis(axis))
|
self.frame[n].contains(window.axis(axis))
|
||||||
&& self.extent[n].contains(len.to_px(px.axis(axis)))
|
&& self.frame_len[n].is_none_or(|pinned| pinned == frame.axis(axis))
|
||||||
|
&& self.extent[n].contains(len.to_px(window.axis(axis)))
|
||||||
&& self.extent_len[n].is_none_or(|pinned| pinned == len)
|
&& self.extent_len[n].is_none_or(|pinned| pinned == len)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
+211
-199
@@ -1,14 +1,14 @@
|
|||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
use crate::layout_diagnostics::{self as diag, Counter};
|
use crate::layout_diagnostics::{self as diag, Counter};
|
||||||
use crate::{
|
use crate::{
|
||||||
Axis, Holds, LayoutHolds, LayoutLen, Len, Part, Place, Px, PxVec2, RegionAlign, RenderedText,
|
Axis, Holds, LayoutHolds, LayoutLen, Len, Part, Place, Px, PxVec2, RegionAlign, Rel,
|
||||||
RetainedPrimitive, Size, StrongWidget, TextAttrs, TextBuffer, TextData, TextureHandle,
|
RenderedText, RetainedPrimitive, Size, StrongWidget, TextAttrs, TextBuffer, TextData,
|
||||||
UiRegion, UiRenderState, UiRsc, UiSpan, UiVec2, Weight, WidgetId, Widgets,
|
TextureHandle, UiRegion, UiRenderState, UiRsc, UiSpan, UiVec2, Weight, WidgetId, Widgets,
|
||||||
render::{
|
render::{
|
||||||
GlyphPrimitive, Mask, MaskIdx, MoveIdx, Primitive, PrimitiveInst, PrimitiveKind,
|
GlyphPrimitive, Mask, MaskIdx, MoveIdx, Primitive, PrimitiveInst, PrimitiveKind,
|
||||||
TexturePrimitive,
|
TexturePrimitive,
|
||||||
},
|
},
|
||||||
ui::render_state::DrawInfo,
|
ui::render_state::{DrawInfo, Placing},
|
||||||
};
|
};
|
||||||
const AXES: [Axis; 2] = [Axis::X, Axis::Y];
|
const AXES: [Axis; 2] = [Axis::X, Axis::Y];
|
||||||
|
|
||||||
@@ -17,26 +17,20 @@ pub struct Painter<'a> {
|
|||||||
pub(super) state: &'a mut UiRenderState,
|
pub(super) state: &'a mut UiRenderState,
|
||||||
pub(super) rsc: &'a mut dyn UiRsc,
|
pub(super) rsc: &'a mut dyn UiRsc,
|
||||||
|
|
||||||
/// What a fraction this widget declares or reports is a fraction of, in
|
/// This widget's frame, per axis: a length of the window, and what a
|
||||||
/// the coordinates of `move_idx`: forwarded from its parent unchanged
|
/// fraction it or anything under it declares or reports is a fraction
|
||||||
/// through a span, a stack or a scroll, and narrowed only by what was
|
/// of. A length rather than a box, so padding can take from both the
|
||||||
/// decided above it -- a declared length, or the root. Its length
|
/// frame and the box without either becoming the other.
|
||||||
/// is the same on every ask of the widget, which is what keeps a fraction
|
pub(super) frame: UiVec2,
|
||||||
/// under it from being resolved twice.
|
/// Where this widget's drawing goes, in its region node's coordinates.
|
||||||
pub(super) frame: UiRegion,
|
|
||||||
/// Where this widget's drawing goes, in the frame's own coordinates.
|
|
||||||
/// Everything it writes is in these coordinates, and its children are
|
|
||||||
/// placed as parts of it.
|
|
||||||
pub(super) extent: UiRegion,
|
pub(super) extent: UiRegion,
|
||||||
/// The extent's symbolic length where this draw read it, which makes the
|
/// The extent's symbolic length where this draw read it, which makes the
|
||||||
/// drawing one that holds for that length alone -- the way reading a
|
/// drawing one that holds for that length alone -- the way reading a
|
||||||
/// length in pixels makes it hold for that number of pixels.
|
/// length in pixels makes it hold for that number of pixels.
|
||||||
pub(super) extent_len: [Option<Len>; 2],
|
pub(super) extent_len: [Option<Len>; 2],
|
||||||
/// The frame in pixels, which its children's frames are a length of:
|
/// The window in pixels. Frames and boxes become pixels against this one
|
||||||
/// threaded down rather than composed back up the chain, so every length
|
/// unit, regardless of region-node boundaries.
|
||||||
/// in layout is one multiply from its parent's and [`Holds::through`]
|
pub(super) window: PxVec2,
|
||||||
/// inverts exactly that.
|
|
||||||
pub(super) px: PxVec2,
|
|
||||||
pub(super) mask: MaskIdx,
|
pub(super) mask: MaskIdx,
|
||||||
pub(super) textures: Vec<TextureHandle>,
|
pub(super) textures: Vec<TextureHandle>,
|
||||||
pub(super) primitives: Vec<RetainedPrimitive>,
|
pub(super) primitives: Vec<RetainedPrimitive>,
|
||||||
@@ -44,22 +38,19 @@ pub struct Painter<'a> {
|
|||||||
/// Only children whose answers were read constrain this widget's answer.
|
/// Only children whose answers were read constrain this widget's answer.
|
||||||
pub(super) answer_under: LayoutHolds,
|
pub(super) answer_under: LayoutHolds,
|
||||||
pub(super) children: Vec<WidgetId>,
|
pub(super) children: Vec<WidgetId>,
|
||||||
/// The children asked about so far, so the first place each was asked in
|
|
||||||
/// is the one recorded as its offer.
|
|
||||||
pub(super) offered: Vec<WidgetId>,
|
|
||||||
/// Whether this draw is at the place its parent first asked about, which
|
|
||||||
/// makes the questions it asks the ones a cold layout asks and their
|
|
||||||
/// answers the ones to keep.
|
|
||||||
pub(super) at_offer: bool,
|
|
||||||
/// The children whose size this widget read while drawing.
|
/// The children whose size this widget read while drawing.
|
||||||
pub(super) size_deps: Vec<WidgetId>,
|
pub(super) size_deps: Vec<WidgetId>,
|
||||||
/// What this draw itself read of its frame in pixels, per axis: every
|
/// What this draw itself read of the window in pixels, per axis: every
|
||||||
/// length until it reads one, then that one, unless it says otherwise.
|
/// window until it reads one, then that one, unless it says otherwise.
|
||||||
pub(super) frame_own: [Holds; 2],
|
pub(super) frame_own: [Holds; 2],
|
||||||
/// The same for its own box.
|
/// Its frame's symbolic length where this draw read it, which makes the
|
||||||
|
/// drawing one that holds for that frame alone.
|
||||||
|
pub(super) frame_own_len: [Option<Len>; 2],
|
||||||
|
/// The window reads' equivalent for its own box.
|
||||||
pub(super) extent_own: [Holds; 2],
|
pub(super) extent_own: [Holds; 2],
|
||||||
/// Dependencies of every child drawing, including unmeasured overlays.
|
/// What each child's drawing depends on. Asking a child again replaces
|
||||||
pub(super) under: LayoutHolds,
|
/// its drawing, so it replaces this too rather than narrowing it.
|
||||||
|
pub(super) under: Vec<(WidgetId, LayoutHolds)>,
|
||||||
/// The movable region this widget's primitives are positioned through:
|
/// The movable region this widget's primitives are positioned through:
|
||||||
/// its own when opted in, otherwise the nearest ancestor's.
|
/// its own when opted in, otherwise the nearest ancestor's.
|
||||||
pub(super) move_idx: MoveIdx,
|
pub(super) move_idx: MoveIdx,
|
||||||
@@ -82,12 +73,10 @@ impl<'a> Painter<'a> {
|
|||||||
self.write_resolved(kind, primitive, region, self.resolve(region));
|
self.write_resolved(kind, primitive, region, self.resolve(region));
|
||||||
}
|
}
|
||||||
|
|
||||||
/// A box in this widget's extent coordinates, composed into the
|
/// A box in this widget's extent coordinates, composed into its region
|
||||||
/// coordinates its move slot is in: through the extent, then through the
|
/// node's coordinates.
|
||||||
/// frame the extent is a part of. The same two steps a recomposition
|
|
||||||
/// replays, so a moved drawing lands where a cold one does.
|
|
||||||
fn resolve(&self, region: UiRegion) -> UiRegion {
|
fn resolve(&self, region: UiRegion) -> UiRegion {
|
||||||
region.within(&self.extent).within(&self.frame)
|
region.within(&self.extent)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn write_resolved<P: Primitive>(
|
fn write_resolved<P: Primitive>(
|
||||||
@@ -151,63 +140,47 @@ impl<'a> Painter<'a> {
|
|||||||
/// one child wants, and what every transparent container passes for the
|
/// one child wants, and what every transparent container passes for the
|
||||||
/// frame.
|
/// frame.
|
||||||
pub fn widget<'s, W: ?Sized>(&'s mut self, id: &'s StrongWidget<W>) -> DrawResult<'s, 'a, W> {
|
pub fn widget<'s, W: ?Sized>(&'s mut self, id: &'s StrongWidget<W>) -> DrawResult<'s, 'a, W> {
|
||||||
self.widget_at(id, UiRegion::FULL, [Place::Within(Part::All); 2])
|
self.widget_at(id, [None; 2], [Place::Within(Part::All); 2])
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Draws a child, saying what its fractions are of and where its drawing
|
/// Asks a child, saying what its fractions are of and where it is asked.
|
||||||
/// goes.
|
|
||||||
///
|
///
|
||||||
/// `frame` is that reference, in this widget's own frame coordinates:
|
/// `narrow` is a length this widget decided for the child's frame, per
|
||||||
/// [`UiRegion::FULL`] forwards this widget's frame, which is what a
|
/// axis, as a length of this widget's own frame: a resolved share, or a
|
||||||
/// container that only divides room passes, so a fraction under it means
|
/// box a sibling's answer decided. `None` forwards this widget's frame,
|
||||||
/// the same wherever it sits and however deeply it is nested. Narrowing
|
/// which is what a container that only divides room passes, so a
|
||||||
/// it is for what is decided from above, and a declared length narrows
|
/// fraction under it means the same wherever it sits and however deeply
|
||||||
/// it here.
|
/// it is nested. A declared length narrows the frame here whatever the
|
||||||
|
/// caller says. A narrowed frame is placed in the part by the child's
|
||||||
|
/// alignment and is the box the child is asked in.
|
||||||
///
|
///
|
||||||
/// `place` is where the drawing goes, per axis, as a part of this
|
/// `place` is where the child is asked, per axis, as a part of this
|
||||||
/// widget's extent: see [`Place`]. A narrowed frame is its own extent,
|
/// widget's box: see [`Place`]. The child draws once, in that box, and
|
||||||
/// since the narrowing is what said where the drawing goes.
|
/// its answer is placed inside it by re-expressing the drawing. Nothing
|
||||||
|
/// is drawn again in a box an answer chose; a container that puts the
|
||||||
|
/// answer somewhere else says so with [`Self::place_at`].
|
||||||
pub fn widget_at<'s, W: ?Sized>(
|
pub fn widget_at<'s, W: ?Sized>(
|
||||||
&'s mut self,
|
&'s mut self,
|
||||||
id: &'s StrongWidget<W>,
|
id: &'s StrongWidget<W>,
|
||||||
frame: UiRegion,
|
narrow: [Option<Len>; 2],
|
||||||
place: [Place; 2],
|
place: [Place; 2],
|
||||||
) -> DrawResult<'s, 'a, W> {
|
) -> DrawResult<'s, 'a, W> {
|
||||||
let region_node = self.rsc.widgets().is_region_node(id.id());
|
let region_node = self.rsc.widgets().is_region_node(id.id());
|
||||||
let declared = self.declared_lens(id);
|
let declared = self.declared_lens(id);
|
||||||
let align = self.rsc.widgets().alignment(id.id());
|
let align = self.rsc.widgets().alignment(id.id());
|
||||||
let (local, extent) = frame_and_extent(
|
let (frame, extent) =
|
||||||
frame,
|
frame_and_extent(self.extent, self.frame, place, narrow, declared, align);
|
||||||
part_of(self.extent, place),
|
|
||||||
narrowed_by(declared, frame),
|
|
||||||
align,
|
|
||||||
);
|
|
||||||
let within = match local == UiRegion::FULL {
|
|
||||||
true => self.frame,
|
|
||||||
false => local.within(&self.frame),
|
|
||||||
};
|
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
if region_node {
|
if region_node {
|
||||||
diag::bump(Counter::RegionNodeDraws);
|
diag::bump(Counter::RegionNodeDraws);
|
||||||
diag::region_node(id.id(), self.id, within);
|
diag::region_node(id.id(), self.id, extent);
|
||||||
}
|
}
|
||||||
// A child listed twice would be moved twice.
|
// A child listed twice would be moved twice.
|
||||||
if !self.children.contains(&id.id()) {
|
let re_asked = self.children.contains(&id.id());
|
||||||
|
if !re_asked {
|
||||||
self.children.push(id.id());
|
self.children.push(id.id());
|
||||||
}
|
}
|
||||||
let first_ask = self.offer(id.id());
|
let px = frame.to_px(self.window);
|
||||||
let offer_place = if first_ask {
|
|
||||||
place
|
|
||||||
} else {
|
|
||||||
self.state
|
|
||||||
.active
|
|
||||||
.get(&id.id())
|
|
||||||
.map_or(place, |a| a.offer_place)
|
|
||||||
};
|
|
||||||
let px = local.size().to_px(self.px);
|
|
||||||
// The answer and what it holds for, both about the place asked in.
|
|
||||||
// The child's record may say something else once its drawing has been
|
|
||||||
// placed: a drawing made again in its placed box holds for that box.
|
|
||||||
let (size, answer_holds, holds) = self.state.draw_inner(
|
let (size, answer_holds, holds) = self.state.draw_inner(
|
||||||
id.id(),
|
id.id(),
|
||||||
DrawInfo {
|
DrawInfo {
|
||||||
@@ -217,23 +190,28 @@ impl<'a> Painter<'a> {
|
|||||||
parent_move: self.move_idx,
|
parent_move: self.move_idx,
|
||||||
region_node,
|
region_node,
|
||||||
mask: self.mask,
|
mask: self.mask,
|
||||||
frame: local,
|
frame,
|
||||||
frame_abs: within,
|
|
||||||
part: extent,
|
part: extent,
|
||||||
place,
|
place,
|
||||||
offer_place,
|
offer_place: place,
|
||||||
|
narrow,
|
||||||
|
re_asked,
|
||||||
px,
|
px,
|
||||||
},
|
},
|
||||||
None,
|
None,
|
||||||
self.rsc,
|
self.rsc,
|
||||||
);
|
);
|
||||||
let compose = |holds| in_parent(holds, local, extent, place, declared);
|
let holds = self.in_parent(holds, extent, place, narrow, declared);
|
||||||
self.under = self.under.and(compose(holds));
|
let answer_holds = self.in_parent(answer_holds, extent, place, narrow, declared);
|
||||||
|
match self.under.iter_mut().find(|(child, _)| *child == id.id()) {
|
||||||
|
Some((_, kept)) => *kept = holds,
|
||||||
|
None => self.under.push((id.id(), holds)),
|
||||||
|
}
|
||||||
DrawResult {
|
DrawResult {
|
||||||
child: id,
|
child: id,
|
||||||
painter: self,
|
painter: self,
|
||||||
size: in_parent_frame(size, local.size(), declared),
|
size,
|
||||||
answer_holds: compose(answer_holds),
|
answer_holds,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -242,9 +220,37 @@ impl<'a> Painter<'a> {
|
|||||||
/// this frame; what it answered is still something this widget asked.
|
/// this frame; what it answered is still something this widget asked.
|
||||||
pub fn undraw<W: ?Sized>(&mut self, id: &StrongWidget<W>) {
|
pub fn undraw<W: ?Sized>(&mut self, id: &StrongWidget<W>) {
|
||||||
self.children.retain(|child| *child != id.id());
|
self.children.retain(|child| *child != id.id());
|
||||||
|
self.under.retain(|(child, _)| *child != id.id());
|
||||||
self.state.undraw_rec(id.id(), self.rsc);
|
self.state.undraw_rec(id.id(), self.rsc);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Puts a child asked about in this draw somewhere else in this
|
||||||
|
/// widget's box: its answer, placed in this part instead. The drawing
|
||||||
|
/// is re-expressed there rather than made again -- what a row does once
|
||||||
|
/// it knows every slot, having measured each child from its cursor.
|
||||||
|
pub fn place_at<W: ?Sized>(&mut self, id: &StrongWidget<W>, place: [Place; 2]) {
|
||||||
|
debug_assert!(
|
||||||
|
self.children.contains(&id.id()),
|
||||||
|
"'{}' placed a child it did not ask about in this draw",
|
||||||
|
self.label()
|
||||||
|
);
|
||||||
|
let at = self.placing();
|
||||||
|
self.state.place_in(id.id(), &at, place, self.rsc);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// This widget as the thing its children are placed within.
|
||||||
|
fn placing(&self) -> Placing {
|
||||||
|
Placing {
|
||||||
|
id: self.id,
|
||||||
|
extent: self.extent,
|
||||||
|
frame: self.frame,
|
||||||
|
window: self.window,
|
||||||
|
depth: self.depth,
|
||||||
|
move_idx: self.move_idx,
|
||||||
|
mask: self.mask,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// What a widget's rules declare its lengths to be, which whoever draws
|
/// What a widget's rules declare its lengths to be, which whoever draws
|
||||||
/// it resolves into its frame. Reading them depends on nothing -- the box
|
/// it resolves into its frame. Reading them depends on nothing -- the box
|
||||||
/// that comes of them is kept on the child, and `redraw` compares it
|
/// that comes of them is kept on the child, and `redraw` compares it
|
||||||
@@ -281,19 +287,6 @@ impl<'a> Painter<'a> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Whether this is the first box a child is asked about in during a draw
|
|
||||||
/// that is itself the one its parent measured -- the question a cold
|
|
||||||
/// layout asks, whose answer is the one to keep. A drawing made again in
|
|
||||||
/// a box chosen from an answer asks about that box instead, and what it
|
|
||||||
/// hears back is not a measurement of anything.
|
|
||||||
fn offer(&mut self, child: WidgetId) -> bool {
|
|
||||||
if !self.at_offer || self.offered.contains(&child) {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
self.offered.push(child);
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn depend_on<W: ?Sized>(&mut self, child: &StrongWidget<W>) {
|
fn depend_on<W: ?Sized>(&mut self, child: &StrongWidget<W>) {
|
||||||
if !self.size_deps.contains(&child.id()) {
|
if !self.size_deps.contains(&child.id()) {
|
||||||
self.size_deps.push(child.id());
|
self.size_deps.push(child.id());
|
||||||
@@ -359,6 +352,17 @@ impl<'a> Painter<'a> {
|
|||||||
len
|
len
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The symbolic length of this widget's frame along one axis: what a
|
||||||
|
/// fraction it or anything under it declares is a fraction of. A
|
||||||
|
/// container reads it to hand a length of it down -- padding, which
|
||||||
|
/// takes its pixels off. Reading it pins the drawing to that frame, the
|
||||||
|
/// way [`Self::extent_len`] pins it to the box.
|
||||||
|
pub fn frame_len(&mut self, axis: Axis) -> Len {
|
||||||
|
let len = self.frame.axis(axis);
|
||||||
|
self.frame_own_len[axis as usize] = Some(len);
|
||||||
|
len
|
||||||
|
}
|
||||||
|
|
||||||
/// Where this widget sits in a box longer than the length it takes. A
|
/// Where this widget sits in a box longer than the length it takes. A
|
||||||
/// widget that positions its own content reads it to place that content
|
/// widget that positions its own content reads it to place that content
|
||||||
/// the way the box around it would have placed the widget.
|
/// the way the box around it would have placed the widget.
|
||||||
@@ -394,7 +398,7 @@ impl<'a> Painter<'a> {
|
|||||||
/// [`Self::px_size`] when the other axis cannot affect the drawing.
|
/// [`Self::px_size`] when the other axis cannot affect the drawing.
|
||||||
pub fn px_len(&mut self, axis: Axis) -> Px {
|
pub fn px_len(&mut self, axis: Axis) -> Px {
|
||||||
let part = self.extent.axis(axis).len();
|
let part = self.extent.axis(axis).len();
|
||||||
let len = part.to_px(self.px.axis(axis));
|
let len = part.to_px(self.window.axis(axis));
|
||||||
let own = &mut self.extent_own[axis as usize];
|
let own = &mut self.extent_own[axis as usize];
|
||||||
if *own == Holds::ANY {
|
if *own == Holds::ANY {
|
||||||
*own = Holds::at(len);
|
*own = Holds::at(len);
|
||||||
@@ -410,7 +414,7 @@ impl<'a> Painter<'a> {
|
|||||||
let part = self.extent.axis(axis).len();
|
let part = self.extent.axis(axis).len();
|
||||||
let holds = holds.into();
|
let holds = holds.into();
|
||||||
debug_assert!(
|
debug_assert!(
|
||||||
holds.contains(part.to_px(self.px.axis(axis))),
|
holds.contains(part.to_px(self.window.axis(axis))),
|
||||||
"'{}' ({:?}) says its drawing holds for lengths that leave out its own box",
|
"'{}' ({:?}) says its drawing holds for lengths that leave out its own box",
|
||||||
self.label(),
|
self.label(),
|
||||||
self.id
|
self.id
|
||||||
@@ -418,26 +422,28 @@ impl<'a> Painter<'a> {
|
|||||||
self.extent_own[axis as usize] = holds;
|
self.extent_own[axis as usize] = holds;
|
||||||
}
|
}
|
||||||
|
|
||||||
/// One axis of this widget's frame in pixels -- what a fraction of its
|
/// A window length in pixels, which is what every length in layout is
|
||||||
/// area resolves against, and so what a container divides among its
|
/// measured in. Reading one pins the drawing to this window wherever the
|
||||||
/// children. Its own box is a part of this one.
|
/// length is a fraction of it; one that is only pixels is that many
|
||||||
pub fn frame_px_len(&mut self, axis: Axis) -> Px {
|
/// pixels in any window and pins nothing.
|
||||||
let len = self.px.axis(axis);
|
pub fn to_px(&mut self, len: Len, axis: Axis) -> Px {
|
||||||
|
let window = self.window.axis(axis);
|
||||||
|
if len.rel != Rel::ZERO {
|
||||||
let own = &mut self.frame_own[axis as usize];
|
let own = &mut self.frame_own[axis as usize];
|
||||||
if *own == Holds::ANY {
|
if *own == Holds::ANY {
|
||||||
*own = Holds::at(len);
|
*own = Holds::at(window);
|
||||||
}
|
}
|
||||||
len
|
}
|
||||||
|
len.to_px(window)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// [`Self::holds`] stated about the frame rather than about this
|
/// A validity range already stated about the window. Containers use
|
||||||
/// widget's own box, for a container whose drawing turns on what its
|
/// this after branching on a window-unit length.
|
||||||
/// fractions are of rather than on the part of it it took.
|
pub fn window_holds(&mut self, axis: Axis, holds: impl Into<Holds>) {
|
||||||
pub fn frame_holds(&mut self, axis: Axis, holds: impl Into<Holds>) {
|
|
||||||
let holds = holds.into();
|
let holds = holds.into();
|
||||||
debug_assert!(
|
debug_assert!(
|
||||||
holds.contains(self.px.axis(axis)),
|
holds.contains(self.window.axis(axis)),
|
||||||
"'{}' ({:?}) says its drawing holds for lengths that leave out its frame",
|
"'{}' ({:?}) says its drawing holds for windows that leave out this one",
|
||||||
self.label(),
|
self.label(),
|
||||||
self.id
|
self.id
|
||||||
);
|
);
|
||||||
@@ -529,70 +535,77 @@ impl PrimitiveLike for &TextureHandle {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// What a child depends on, said about the boxes the widget that drew it
|
/// Moves what a child depends on into this widget's own terms: this
|
||||||
/// has rather than the ones the child was given.
|
/// method's `impl` block is where a `Painter`'s own boxes are, so it takes
|
||||||
|
/// only what the child was asked with.
|
||||||
|
impl Painter<'_> {
|
||||||
|
/// Frame ranges are already ranges on the window and combine directly.
|
||||||
|
/// A frame pin becomes this widget's own frame wherever a length of it
|
||||||
|
/// is what reached the child; where only pixels did, no length of this
|
||||||
|
/// frame can change the child's and the pin stops here.
|
||||||
///
|
///
|
||||||
/// `frame` is the child's frame in this widget's frame coordinates and
|
/// Extent validity maps back through the part of this widget's box,
|
||||||
/// `extent` the box it was given, in the child's own frame coordinates. Both
|
/// where the box the child was asked in is that part; a declared length
|
||||||
/// reach it as one length, so what it holds for maps back through that
|
/// places the box inside the part instead, and then only that length
|
||||||
/// length exactly -- and where the box it was given is this widget's own,
|
/// reaches the child. A narrowed frame is not one of these: it decides
|
||||||
/// what it says about that box is what this widget can say about its own.
|
/// what fractions under the child mean and leaves the box the part it
|
||||||
pub(crate) fn in_parent(
|
/// was given.
|
||||||
|
fn in_parent(
|
||||||
|
&self,
|
||||||
holds: LayoutHolds,
|
holds: LayoutHolds,
|
||||||
frame: UiRegion,
|
|
||||||
extent: UiRegion,
|
extent: UiRegion,
|
||||||
place: [Place; 2],
|
place: [Place; 2],
|
||||||
|
narrow: [Option<Len>; 2],
|
||||||
declared: [Option<LayoutLen>; 2],
|
declared: [Option<LayoutLen>; 2],
|
||||||
) -> LayoutHolds {
|
) -> LayoutHolds {
|
||||||
let mut result = LayoutHolds::ANY;
|
let mut result = LayoutHolds::ANY;
|
||||||
for axis in AXES {
|
for axis in AXES {
|
||||||
let n = axis as usize;
|
let n = axis as usize;
|
||||||
let frame_len = frame.axis(axis).len();
|
// Every frame range is already a range on the window: the
|
||||||
result.frame[n] = holds.frame[n].through(frame_len);
|
// widget's own read converted through its frame exactly once.
|
||||||
match (place[n].part(), declared[n]) {
|
result.frame[n] = holds.frame[n];
|
||||||
// Its box is this widget's own, or a part of it in that box's
|
let reaches = narrow[n].is_none()
|
||||||
// own lengths: so what it holds for is a range on this widget's
|
&& !matches!(place[n].part(), Part::Sized(_))
|
||||||
// own box, which is what lets that box move without a redraw. A
|
&& declared[n].is_none_or(|len| len.rel != Rel::ZERO);
|
||||||
// length it pinned is this widget's length wherever the part is
|
result.frame_len[n] = holds.frame_len[n].and(reaches.then(|| self.frame.axis(axis)));
|
||||||
// the whole of it, and pins the same way.
|
match (place[n].part(), declared[n].is_some()) {
|
||||||
(Part::All, None) => {
|
// Its box is this widget's own, or a part of it in that
|
||||||
|
// box's own lengths: so what it holds for is a range on this
|
||||||
|
// widget's own box, which is what lets that box move without
|
||||||
|
// a redraw. A length it pinned is this widget's length
|
||||||
|
// wherever the part is the whole of it, and pins the same
|
||||||
|
// way.
|
||||||
|
(Part::All, false) => {
|
||||||
result.extent[n] = holds.extent[n];
|
result.extent[n] = holds.extent[n];
|
||||||
result.extent_len[n] = holds.extent_len[n];
|
result.extent_len[n] = holds.extent_len[n];
|
||||||
}
|
}
|
||||||
// Its box is a part of this widget's own box, in that box's own
|
// Its box is a part of this widget's own box, in that box's
|
||||||
// lengths, so what it holds for maps back through that part into
|
// own lengths, so what it holds for maps back through that
|
||||||
// a range on this widget's box.
|
// part into a range on this widget's box. A length it pinned
|
||||||
(Part::Of(span), None) => {
|
// is this widget's length less the part's pixels where the
|
||||||
result.extent[n] = holds.extent[n].through(span.len());
|
// part is the whole of the box less pixels, which is the one
|
||||||
|
// shape that inverts exactly; any other part pins this
|
||||||
|
// widget's own length.
|
||||||
|
(Part::Of(span), false) => {
|
||||||
|
let part_len = span.len();
|
||||||
|
result.extent[n] = holds.extent[n].through(part_len);
|
||||||
|
result.extent_len[n] = holds.extent_len[n].map(|pinned| match part_len.rel {
|
||||||
|
Rel::ONE => pinned - Len::from_parts(Rel::ZERO, part_len.px),
|
||||||
|
_ => self.extent.axis(axis).len(),
|
||||||
|
});
|
||||||
}
|
}
|
||||||
// Its box is a part of this widget's frame: a length of the
|
// Its box is a part of this widget's frame, or a length of
|
||||||
// frame is all that reaches it, so what it holds for is a range
|
// it decided here: a length of the frame is all that reaches
|
||||||
// on the frame and none of it on this widget's own box.
|
// it, so what it holds for is a range on the frame and none
|
||||||
|
// of it on this widget's own box.
|
||||||
_ => {
|
_ => {
|
||||||
result.frame[n] = result.frame[n].and(
|
result.frame[n] =
|
||||||
holds.extent[n]
|
result.frame[n].and(holds.extent[n].through(extent.axis(axis).len()));
|
||||||
.through(extent.axis(axis).len())
|
|
||||||
.through(frame_len),
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
result
|
result
|
||||||
}
|
}
|
||||||
|
|
||||||
/// A child's answer as lengths of the parent's own region. A widget reports
|
|
||||||
/// a fraction of its own region, and `of` is that region as a length of this
|
|
||||||
/// one. Pixels come through untouched, being that many pixels wherever they
|
|
||||||
/// end up. A declared axis is already the parent's: it resolved the rule in
|
|
||||||
/// its own region, and the rule is what the report says.
|
|
||||||
fn in_parent_frame(size: Size, of: UiVec2, declared: [Option<LayoutLen>; 2]) -> Size {
|
|
||||||
let mut size = size;
|
|
||||||
for (axis, declared) in AXES.into_iter().zip(declared) {
|
|
||||||
if declared.is_none() {
|
|
||||||
*size.axis_mut(axis) = size.axis(axis).within_len(of.axis(axis));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
size
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// What a widget declares a length of its box to be. `leftover` is not one: a
|
/// What a widget declares a length of its box to be. `leftover` is not one: a
|
||||||
@@ -657,59 +670,58 @@ pub(crate) fn placed_extent(
|
|||||||
placed
|
placed
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The part of a widget's own box a `place` names, in the coordinates that
|
/// The frame length and the box a child is asked in, in the coordinates the
|
||||||
/// box is in.
|
/// widget asking draws in.
|
||||||
pub(crate) fn part_of(extent: UiRegion, place: [Place; 2]) -> UiRegion {
|
|
||||||
let mut part = extent;
|
|
||||||
for axis in AXES {
|
|
||||||
*part.axis_mut(axis) = place[axis as usize].part().of(*extent.axis(axis));
|
|
||||||
}
|
|
||||||
part
|
|
||||||
}
|
|
||||||
|
|
||||||
/// The length a rule gives a child's frame, per axis: a fraction in it is a
|
|
||||||
/// fraction of the frame the child was given, which is the one length the
|
|
||||||
/// rule can mean.
|
|
||||||
pub(crate) fn narrowed_by(declared: [Option<LayoutLen>; 2], frame: UiRegion) -> [Option<Len>; 2] {
|
|
||||||
AXES.map(|axis| {
|
|
||||||
declared[axis as usize]
|
|
||||||
.map(|len| Len::from_parts(len.rel, len.px).within_len(frame.axis(axis).len()))
|
|
||||||
})
|
|
||||||
}
|
|
||||||
|
|
||||||
/// The frame a child is asked in and the box its drawing goes in, both in
|
|
||||||
/// the coordinates of the widget asking.
|
|
||||||
///
|
///
|
||||||
/// `frame` is what the caller said the child's fractions are of, and `part`
|
/// `own` is that widget's own box, and `place` what of it the child is
|
||||||
/// what of the caller's own box the drawing takes. `narrow` is the length a
|
/// given. `narrow` is a frame the container decided for the child -- a row's
|
||||||
/// declared rule gives the frame, which makes the frame the box the drawing
|
/// slot, or padding's frame less its pixels -- and [`Part::Sized`] one a
|
||||||
/// goes in -- a rule is what decided where it goes, and there is nothing
|
/// sibling's answer decided; both are window lengths, like every other
|
||||||
/// left to place inside it. A caller that narrowed the frame itself said the
|
/// length here, since a slot of a row is not a fraction of anything the row
|
||||||
/// same thing.
|
/// can name. The child's declaration is a fraction of whichever reached it,
|
||||||
///
|
/// and is the only one of the three that also places the box: a box the
|
||||||
/// The length is the caller's to supply so that a widget asked again gets
|
/// caller decided is what `place` names.
|
||||||
/// the frame it already has rather than a second resolution of its rule.
|
|
||||||
pub(crate) fn frame_and_extent(
|
pub(crate) fn frame_and_extent(
|
||||||
mut frame: UiRegion,
|
own: UiRegion,
|
||||||
part: UiRegion,
|
parent_frame: UiVec2,
|
||||||
|
place: [Place; 2],
|
||||||
narrow: [Option<Len>; 2],
|
narrow: [Option<Len>; 2],
|
||||||
|
declared: [Option<LayoutLen>; 2],
|
||||||
align: RegionAlign,
|
align: RegionAlign,
|
||||||
) -> (UiRegion, UiRegion) {
|
) -> (UiVec2, UiRegion) {
|
||||||
|
let part = part_of(own, place, align);
|
||||||
|
let mut frame = parent_frame;
|
||||||
let mut extent = part;
|
let mut extent = part;
|
||||||
for (axis, narrow) in AXES.into_iter().zip(narrow) {
|
for axis in AXES {
|
||||||
let span = frame.axis_mut(axis);
|
let n = axis as usize;
|
||||||
let narrowed = match narrow {
|
let sized = match place[n].part() {
|
||||||
Some(len) => {
|
Part::Sized(len) => Some(len),
|
||||||
|
_ => None,
|
||||||
|
};
|
||||||
|
let base = sized
|
||||||
|
.or(narrow[n])
|
||||||
|
.unwrap_or_else(|| parent_frame.axis(axis));
|
||||||
|
let len = declared[n]
|
||||||
|
.map(|len| Len::from_parts(len.rel, len.px).within_len(base))
|
||||||
|
.unwrap_or(base);
|
||||||
|
*frame.axis_mut(axis) = len;
|
||||||
|
if declared[n].is_some() {
|
||||||
let slot = part.axis(axis);
|
let slot = part.axis(axis);
|
||||||
let start = slot.start + (slot.len() - len).scale(align.axis(axis).rel());
|
let start = slot.start + (slot.len() - len).scale(align.axis(axis).rel());
|
||||||
*span = UiSpan::new(start, start + len);
|
*extent.axis_mut(axis) = UiSpan::new(start, start + len);
|
||||||
true
|
|
||||||
}
|
|
||||||
None => *span != UiSpan::FULL,
|
|
||||||
};
|
|
||||||
if narrowed {
|
|
||||||
*extent.axis_mut(axis) = UiSpan::FULL;
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
(frame, extent)
|
(frame, extent)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The part of a widget's own box a `place` names, in the coordinates that
|
||||||
|
/// box is in.
|
||||||
|
fn part_of(extent: UiRegion, place: [Place; 2], align: RegionAlign) -> UiRegion {
|
||||||
|
let mut part = extent;
|
||||||
|
for axis in AXES {
|
||||||
|
*part.axis_mut(axis) = place[axis as usize]
|
||||||
|
.part()
|
||||||
|
.of(*extent.axis(axis), align.axis(axis));
|
||||||
|
}
|
||||||
|
part
|
||||||
|
}
|
||||||
+12
-2
@@ -1,4 +1,4 @@
|
|||||||
use crate::{PrimitiveHandle, UiRegion, UiSpan};
|
use crate::{AxisAlign, Len, PrimitiveHandle, UiRegion, UiSpan};
|
||||||
|
|
||||||
/// What of a widget's own box a child is given, along one axis.
|
/// What of a widget's own box a child is given, along one axis.
|
||||||
#[derive(Clone, Copy, Debug, PartialEq)]
|
#[derive(Clone, Copy, Debug, PartialEq)]
|
||||||
@@ -16,15 +16,25 @@ pub enum Part {
|
|||||||
/// container read its own box -- and a box chosen from its own answer
|
/// container read its own box -- and a box chosen from its own answer
|
||||||
/// then feeds back into the answer.
|
/// then feeds back into the answer.
|
||||||
Of(UiSpan),
|
Of(UiSpan),
|
||||||
|
/// A box of this length, wherever in the parent's box the child's own
|
||||||
|
/// alignment puts it, and that same length as its frame. Unlike `From`,
|
||||||
|
/// it is a length decided from above rather than a place along a
|
||||||
|
/// container's cursor -- what a stack's sizing child decides for the
|
||||||
|
/// rest.
|
||||||
|
Sized(Len),
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Part {
|
impl Part {
|
||||||
/// Where it lands in the coordinates `extent` is in.
|
/// Where it lands in the coordinates `extent` is in.
|
||||||
pub(crate) fn of(self, extent: UiSpan) -> UiSpan {
|
pub(crate) fn of(self, extent: UiSpan, align: AxisAlign) -> UiSpan {
|
||||||
match self {
|
match self {
|
||||||
Self::All => extent,
|
Self::All => extent,
|
||||||
Self::From(span) => UiSpan::new(extent.start + span.start, extent.start + span.end),
|
Self::From(span) => UiSpan::new(extent.start + span.start, extent.start + span.end),
|
||||||
Self::Of(span) => span.within(&extent),
|
Self::Of(span) => span.within(&extent),
|
||||||
|
Self::Sized(len) => {
|
||||||
|
let start = extent.start + (extent.len() - len).scale(align.rel());
|
||||||
|
UiSpan::new(start, start + len)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+294
-344
@@ -1,10 +1,10 @@
|
|||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
use crate::layout_diagnostics::{self as diag, Counter, ReuseOutcome, TimerKind};
|
use crate::layout_diagnostics::{self as diag, Counter, ReuseOutcome, TimerKind};
|
||||||
use crate::ui::painter::{declared_lens, frame_and_extent, narrowed_by, part_of, placed_extent};
|
use crate::ui::painter::{declared_lens, frame_and_extent, placed_extent};
|
||||||
use crate::{
|
use crate::{
|
||||||
ActiveData, Axis, DrawLayers, Holds, IdLike, LayoutHolds, LayoutLen, MaskIdx, MoveIdx, Moves,
|
ActiveData, Axis, DrawLayers, Holds, IdLike, LayoutHolds, LayoutLen, Len, MaskIdx, MoveIdx,
|
||||||
Painter, Part, PixelRegion, Place, PxVec2, Size, StrongWidget, UiRegion, UiRsc, Weight,
|
Moves, Painter, Part, PixelRegion, Place, PxVec2, Rel, Size, StrongWidget, UiRegion, UiRsc,
|
||||||
WidgetId, Widgets,
|
UiSpan, UiVec2, Weight, WidgetId, Widgets,
|
||||||
util::{HashMap, Vec2},
|
util::{HashMap, Vec2},
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -20,22 +20,23 @@ pub(super) struct DrawInfo {
|
|||||||
pub parent_move: MoveIdx,
|
pub parent_move: MoveIdx,
|
||||||
pub region_node: bool,
|
pub region_node: bool,
|
||||||
pub mask: MaskIdx,
|
pub mask: MaskIdx,
|
||||||
/// The frame in the parent widget's frame coordinates, before
|
/// What a fraction declared or reported under this widget is a fraction
|
||||||
/// composition. Its length is the same on every ask of the widget.
|
/// of, as a length of the window.
|
||||||
pub frame: UiRegion,
|
pub frame: UiVec2,
|
||||||
/// That frame composed into `parent_move`'s coordinates, which is what
|
/// The box the widget is asked in, in its parent region node's
|
||||||
/// the widget's own drawing is written within.
|
/// coordinates.
|
||||||
pub frame_abs: UiRegion,
|
|
||||||
/// The box the drawing is given, in the frame's own coordinates: the
|
|
||||||
/// part of the parent's own box that `place` names, before the widget's
|
|
||||||
/// answer is placed inside it.
|
|
||||||
pub part: UiRegion,
|
pub part: UiRegion,
|
||||||
/// What of the parent's extent the drawing was given, and what it was
|
/// Where the widget is put, and where it was asked, as parts of the
|
||||||
/// given at the parent's first ask of it. See [`Place`].
|
/// parent's box. See [`Place`]. The two are one ask's place until the
|
||||||
|
/// parent places the answer somewhere else.
|
||||||
pub place: [Place; 2],
|
pub place: [Place; 2],
|
||||||
pub offer_place: [Place; 2],
|
pub offer_place: [Place; 2],
|
||||||
/// The frame in pixels: one multiply from the parent's own, which is
|
/// A frame the parent decided for it on each axis, as a length of the
|
||||||
/// where every pixel length in layout comes from.
|
/// window, which the widget's own declaration is a fraction of.
|
||||||
|
pub narrow: [Option<Len>; 2],
|
||||||
|
/// Whether the parent already asked about this widget in this draw.
|
||||||
|
pub re_asked: bool,
|
||||||
|
/// The frame in pixels, resolved once against the window.
|
||||||
pub px: PxVec2,
|
pub px: PxVec2,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -45,34 +46,18 @@ impl DrawInfo {
|
|||||||
fn fill(&self) -> [bool; 2] {
|
fn fill(&self) -> [bool; 2] {
|
||||||
self.place.map(Place::fills)
|
self.place.map(Place::fills)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Whether this ask is the one the widget's answer is kept from: the
|
|
||||||
/// same widget in the place its parent measured it by, however this draw
|
|
||||||
/// came about.
|
|
||||||
///
|
|
||||||
/// **Open.** A place is a length from where the asking widget's own box
|
|
||||||
/// starts, so two drawings of that widget -- one in the box its parent
|
|
||||||
/// measured it in, one in the box its own answer chose -- ask their
|
|
||||||
/// children in the same places and different boxes, and this cannot tell
|
|
||||||
/// them apart. Shrinker seeds 2 (`repaint`) and 108 (`reorder`) at depth
|
|
||||||
/// 5 are where that shows.
|
|
||||||
fn offer(&self) -> bool {
|
|
||||||
self.place == self.offer_place
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// What a widget's children are placed in: its own box, the coordinates its
|
/// What a widget's children are placed in: its own box, the coordinates its
|
||||||
/// drawing is in, and what else one ask of a child is decided from.
|
/// drawing is in, and what else one ask of a child is decided from.
|
||||||
struct Placing {
|
pub(super) struct Placing {
|
||||||
id: WidgetId,
|
pub id: WidgetId,
|
||||||
extent: UiRegion,
|
pub extent: UiRegion,
|
||||||
/// The widget's frame in the coordinates its children compose within:
|
pub frame: UiVec2,
|
||||||
/// `FULL` where it is a region node, since its box is that node.
|
pub window: PxVec2,
|
||||||
local: UiRegion,
|
pub depth: usize,
|
||||||
px: PxVec2,
|
pub move_idx: MoveIdx,
|
||||||
depth: usize,
|
pub mask: MaskIdx,
|
||||||
move_idx: MoveIdx,
|
|
||||||
mask: MaskIdx,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct UiRenderState {
|
pub struct UiRenderState {
|
||||||
@@ -134,24 +119,20 @@ impl UiRenderState {
|
|||||||
self.resized = true;
|
self.resized = true;
|
||||||
let Some(root) = self.old_root else { return };
|
let Some(root) = self.old_root else { return };
|
||||||
let stands = self.active.get(&root).is_some_and(|active| {
|
let stands = self.active.get(&root).is_some_and(|active| {
|
||||||
let px = active.frame.size().to_px(size);
|
|
||||||
// Nothing above the root chose anything, so the box it was first
|
// Nothing above the root chose anything, so the box it was first
|
||||||
// asked about is the whole of its frame.
|
// asked about is the whole of its frame.
|
||||||
let offer = part_of(UiRegion::FULL, active.offer_place);
|
active.answers_at(size, active.offer_part)
|
||||||
active.answers_at(px, offer) && active.holds.contains(px, active.extent)
|
&& active.holds.contains(size, active.frame, active.offer_part)
|
||||||
});
|
});
|
||||||
if !stands {
|
if !stands {
|
||||||
widgets.needs_redraw.insert(root);
|
widgets.needs_redraw.insert(root);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The root is asked about in the output: the window is where a fraction
|
/// The root is asked about in the output. Its own rules narrow both its
|
||||||
/// becomes pixels rather than a box of its own, so the root's box is the
|
/// frame and box; nothing above it chose a different one.
|
||||||
/// first length threaded down. Its own rules narrow that box, and where
|
fn root_info(&self, frame: UiVec2, extent: UiRegion) -> DrawInfo {
|
||||||
/// they do the narrowed box is also the offer -- nothing above it chose
|
let px = frame.to_px(self.output_size);
|
||||||
/// anything else.
|
|
||||||
fn root_info(&self, region: UiRegion) -> DrawInfo {
|
|
||||||
let px = region.size().to_px(self.output_size);
|
|
||||||
DrawInfo {
|
DrawInfo {
|
||||||
layer: 0,
|
layer: 0,
|
||||||
parent: None,
|
parent: None,
|
||||||
@@ -159,11 +140,12 @@ impl UiRenderState {
|
|||||||
parent_move: MoveIdx::NONE,
|
parent_move: MoveIdx::NONE,
|
||||||
region_node: false,
|
region_node: false,
|
||||||
mask: MaskIdx::NONE,
|
mask: MaskIdx::NONE,
|
||||||
frame: region,
|
frame,
|
||||||
frame_abs: region,
|
part: extent,
|
||||||
part: UiRegion::FULL,
|
|
||||||
place: [Place::Within(Part::All); 2],
|
place: [Place::Within(Part::All); 2],
|
||||||
offer_place: [Place::Within(Part::All); 2],
|
offer_place: [Place::Within(Part::All); 2],
|
||||||
|
narrow: [None; 2],
|
||||||
|
re_asked: false,
|
||||||
px,
|
px,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -210,23 +192,24 @@ impl UiRenderState {
|
|||||||
let _layout = diag::timer(TimerKind::FullLayout);
|
let _layout = diag::timer(TimerKind::FullLayout);
|
||||||
self.clear(rsc);
|
self.clear(rsc);
|
||||||
if let Some(id) = root {
|
if let Some(id) = root {
|
||||||
let region = Self::root_region(id.id(), rsc.widgets());
|
let (frame, extent) = Self::root_layout(id.id(), rsc.widgets());
|
||||||
let info = self.root_info(region);
|
let info = self.root_info(frame, extent);
|
||||||
self.draw_inner(id.id(), info, None, rsc);
|
self.draw_inner(id.id(), info, None, rsc);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The root's frame: the window, narrowed by the root's own rules. Its
|
/// The root's frame and box: the window, taken in by the root's own
|
||||||
/// extent is that frame, since nothing above it chose anything else.
|
/// rules. Nothing above it narrowed anything or chose where it goes, so
|
||||||
fn root_region(id: WidgetId, widgets: &Widgets) -> UiRegion {
|
/// its declaration is the whole of what decides either.
|
||||||
let narrow = narrowed_by(declared_lens(widgets, id), UiRegion::FULL);
|
fn root_layout(id: WidgetId, widgets: &Widgets) -> (UiVec2, UiRegion) {
|
||||||
frame_and_extent(
|
frame_and_extent(
|
||||||
UiRegion::FULL,
|
UiRegion::FULL,
|
||||||
UiRegion::FULL,
|
UiVec2::FULL_SIZE,
|
||||||
narrow,
|
[Place::Within(Part::All); 2],
|
||||||
|
[None; 2],
|
||||||
|
declared_lens(widgets, id),
|
||||||
widgets.alignment(id),
|
widgets.alignment(id),
|
||||||
)
|
)
|
||||||
.0
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub(super) fn draw_inner(
|
pub(super) fn draw_inner(
|
||||||
@@ -236,78 +219,56 @@ impl UiRenderState {
|
|||||||
mut old: Option<ActiveData>,
|
mut old: Option<ActiveData>,
|
||||||
rsc: &mut dyn UiRsc,
|
rsc: &mut dyn UiRsc,
|
||||||
) -> (Size, LayoutHolds, LayoutHolds) {
|
) -> (Size, LayoutHolds, LayoutHolds) {
|
||||||
let (frame, part) = (info.frame_abs, info.part);
|
let part = info.part;
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
{
|
{
|
||||||
diag::bump(Counter::DrawRequests);
|
diag::bump(Counter::DrawRequests);
|
||||||
diag::draw_request(id, info.parent, frame, info.px, info.region_node);
|
diag::draw_request(id, info.parent, part, info.px, info.region_node);
|
||||||
}
|
}
|
||||||
let align = rsc.widgets().alignment(id);
|
let align = rsc.widgets().alignment(id);
|
||||||
|
let declared = declared_lens(rsc.widgets(), id);
|
||||||
// Nothing this widget measured can be dirty while it draws: layout is
|
// Nothing this widget measured can be dirty while it draws: layout is
|
||||||
// one bottom-up walk, so anything deeper has settled or deferred to
|
// one bottom-up walk, so anything deeper has settled or deferred to
|
||||||
// its own parent, and a deferred one leaves that parent marked.
|
// its own parent, and a deferred one leaves that parent marked.
|
||||||
let stale = rsc.widgets().needs_redraw.contains(&id);
|
let stale = rsc.widgets().needs_redraw.contains(&id);
|
||||||
let retained = match stale {
|
// The widget draws once, in the box it is asked in, and its answer
|
||||||
true => None,
|
// is placed inside that box by re-expressing the drawing. The box the
|
||||||
false => self
|
// answer chose is never a question: nothing is drawn again in it, so
|
||||||
.retained_answer(id, part, info)
|
// an answer is kept only with the drawing that gave it, and both
|
||||||
.or_else(|| self.try_reuse(id, frame, part, info, rsc)),
|
// have to hold for the box asked about.
|
||||||
};
|
let reused = (!stale)
|
||||||
let answer = retained.unwrap_or_else(|| {
|
.then(|| self.retained_answer(id, part, info))
|
||||||
|
.flatten()
|
||||||
|
.and_then(|answer| {
|
||||||
|
let extent = placed_extent(part, answer.0, declared, info.fill(), align);
|
||||||
|
self.try_reuse(id, part, extent, info, rsc).map(|()| answer)
|
||||||
|
});
|
||||||
|
let answer = reused.unwrap_or_else(|| {
|
||||||
if old.is_none() {
|
if old.is_none() {
|
||||||
old = self.remove(id, false, rsc);
|
old = self.remove(id, false, rsc);
|
||||||
}
|
}
|
||||||
self.draw_at(id, part, info, old.take(), rsc)
|
let answer = self.draw_at(id, part, info, old.take(), rsc);
|
||||||
|
// Where the drawing goes: the part its parent gave it, with the
|
||||||
|
// answer placed inside that part on any axis the parent left
|
||||||
|
// open.
|
||||||
|
let extent = placed_extent(part, answer.0, declared, info.fill(), align);
|
||||||
|
if extent != part {
|
||||||
|
self.relocate(id, extent, info, rsc);
|
||||||
|
}
|
||||||
|
answer
|
||||||
});
|
});
|
||||||
|
|
||||||
// Where the drawing goes, in the frame's own coordinates: the part
|
|
||||||
// its parent gave it, with the answer placed inside that part on any
|
|
||||||
// axis the parent left open. The frame itself does not change, so
|
|
||||||
// nothing under it resolves a fraction a second time.
|
|
||||||
//
|
|
||||||
// From the answer it gave when its parent measured it, and not from
|
|
||||||
// what a placing evaluation reported: placing a drawing by what it
|
|
||||||
// said in the box its own answer chose would move the box out from
|
|
||||||
// under it.
|
|
||||||
let measured = match info.offer() {
|
|
||||||
true => answer.0,
|
|
||||||
false => self.active[&id].measured().unwrap_or(answer.0),
|
|
||||||
};
|
|
||||||
let extent = placed_extent(
|
|
||||||
part,
|
|
||||||
measured,
|
|
||||||
declared_lens(rsc.widgets(), id),
|
|
||||||
info.fill(),
|
|
||||||
align,
|
|
||||||
);
|
|
||||||
self.place(id, extent, info, rsc);
|
|
||||||
|
|
||||||
// On axes the parent filled, measurement and drawing share an extent.
|
|
||||||
// Otherwise the answer fixes the final extent as a function of the
|
|
||||||
// frame, so pull that drawing's validity back through it.
|
|
||||||
let drawing_holds = self.active[&id].holds;
|
let drawing_holds = self.active[&id].holds;
|
||||||
let mut settled = answer;
|
|
||||||
for axis in AXES {
|
|
||||||
let n = axis as usize;
|
|
||||||
settled.1.frame[n] = settled.1.frame[n].and(drawing_holds.frame[n]);
|
|
||||||
if info.fill()[n] {
|
|
||||||
settled.1.extent[n] = settled.1.extent[n].and(drawing_holds.extent[n]);
|
|
||||||
} else {
|
|
||||||
settled.1.frame[n] = settled.1.frame[n]
|
|
||||||
.and(drawing_holds.extent[n].through(extent.axis(axis).len()));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
let active = self.active.get_mut(&id).unwrap();
|
let active = self.active.get_mut(&id).unwrap();
|
||||||
// Whoever asked owns how the boxes were reached: the frame it stated,
|
// Whoever asked owns how the boxes were reached: the frame it stated,
|
||||||
// and what of its own box it gave the drawing. A local redraw asks
|
// and what of its own box it asked in. A local redraw asks the same
|
||||||
// the same question again from these.
|
// question again from these.
|
||||||
active.frame_abs = frame;
|
|
||||||
active.frame = info.frame;
|
active.frame = info.frame;
|
||||||
if info.offer() {
|
active.narrow = info.narrow;
|
||||||
|
active.re_asked = info.re_asked;
|
||||||
active.answer = Some(answer);
|
active.answer = Some(answer);
|
||||||
active.offer_place = info.offer_place;
|
active.offer_place = info.offer_place;
|
||||||
active.offer_part = part;
|
active.offer_part = part;
|
||||||
}
|
|
||||||
active.place = info.place;
|
active.place = info.place;
|
||||||
active.own_align = align;
|
active.own_align = align;
|
||||||
// A subtree can be reused whole under a different parent -- same box,
|
// A subtree can be reused whole under a different parent -- same box,
|
||||||
@@ -322,21 +283,7 @@ impl UiRenderState {
|
|||||||
{
|
{
|
||||||
old_parent.children.retain(|child| *child != id);
|
old_parent.children.retain(|child| *child != id);
|
||||||
}
|
}
|
||||||
(answer.0, answer.1, settled.1)
|
(answer.0, answer.1, drawing_holds)
|
||||||
}
|
|
||||||
|
|
||||||
/// Recompose retained geometry when the evaluation still holds at this extent.
|
|
||||||
fn place(&mut self, id: WidgetId, extent: UiRegion, info: DrawInfo, rsc: &mut dyn UiRsc) {
|
|
||||||
if self
|
|
||||||
.try_reuse(id, info.frame_abs, extent, info, rsc)
|
|
||||||
.is_some()
|
|
||||||
{
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
|
||||||
diag::bump(Counter::PlaceRedraws);
|
|
||||||
let old = self.remove(id, false, rsc);
|
|
||||||
self.draw_at(id, extent, info, old, rsc);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Calls a widget's `draw` and keeps what it drew in `extent` of `frame`.
|
/// Calls a widget's `draw` and keeps what it drew in `extent` of `frame`.
|
||||||
@@ -348,35 +295,30 @@ impl UiRenderState {
|
|||||||
old: Option<ActiveData>,
|
old: Option<ActiveData>,
|
||||||
rsc: &mut dyn UiRsc,
|
rsc: &mut dyn UiRsc,
|
||||||
) -> (Size, LayoutHolds) {
|
) -> (Size, LayoutHolds) {
|
||||||
let frame = info.frame_abs;
|
let frame = info.frame;
|
||||||
let (move_idx, local, retired_move) = match info.region_node {
|
let (move_idx, extent, retired_move) = match info.region_node {
|
||||||
// Its box becomes its movable region, so it draws in that
|
// A node entry is only a translation. Its local box keeps the
|
||||||
// region's coordinates and its box is one entry to rewrite.
|
// same window-unit length as the box in its parent's node.
|
||||||
true => (
|
true => (
|
||||||
self.move_slot(id, info.parent_move, frame),
|
self.move_slot(id, info.parent_move, translation(extent)),
|
||||||
UiRegion::FULL,
|
local_region(extent),
|
||||||
None,
|
None,
|
||||||
),
|
),
|
||||||
// Keep the old entry alive until every descendant has migrated.
|
// Keep the old entry alive until every descendant has migrated.
|
||||||
// Reusing its index sooner could make an old parent look current.
|
// Reusing its index sooner could make an old parent look current.
|
||||||
false => (info.parent_move, frame, self.slots.remove(&id)),
|
false => (info.parent_move, extent, self.slots.remove(&id)),
|
||||||
};
|
|
||||||
let (old_children, old_answer, old_offer_part) = match old {
|
|
||||||
Some(old) => (old.children, old.answer, Some(old.offer_part)),
|
|
||||||
None => (Vec::new(), None, None),
|
|
||||||
};
|
};
|
||||||
|
let old_children = old.map_or_else(Vec::new, |old| old.children);
|
||||||
rsc.widgets_mut().needs_redraw.remove(&id);
|
rsc.widgets_mut().needs_redraw.remove(&id);
|
||||||
// Only evaluation at the original offer establishes the children's
|
|
||||||
// offers. A placing evaluation must not overwrite that question.
|
|
||||||
let px = info.px;
|
let px = info.px;
|
||||||
let at_offer = info.offer();
|
|
||||||
|
|
||||||
|
let window = self.output_size;
|
||||||
let mut painter = Painter {
|
let mut painter = Painter {
|
||||||
state: self,
|
state: self,
|
||||||
frame: local,
|
frame,
|
||||||
extent,
|
extent,
|
||||||
extent_len: [None; 2],
|
extent_len: [None; 2],
|
||||||
px,
|
window,
|
||||||
mask: info.mask,
|
mask: info.mask,
|
||||||
layer: info.layer,
|
layer: info.layer,
|
||||||
own_layer: info.layer,
|
own_layer: info.layer,
|
||||||
@@ -385,11 +327,10 @@ impl UiRenderState {
|
|||||||
primitives: Vec::new(),
|
primitives: Vec::new(),
|
||||||
mask_region: None,
|
mask_region: None,
|
||||||
children: Vec::new(),
|
children: Vec::new(),
|
||||||
offered: Vec::new(),
|
|
||||||
at_offer,
|
|
||||||
size_deps: Vec::new(),
|
size_deps: Vec::new(),
|
||||||
frame_own: [Holds::ANY; 2],
|
frame_own: [Holds::ANY; 2],
|
||||||
under: LayoutHolds::ANY,
|
frame_own_len: [None; 2],
|
||||||
|
under: Vec::new(),
|
||||||
extent_own: [Holds::ANY; 2],
|
extent_own: [Holds::ANY; 2],
|
||||||
answer_under: LayoutHolds::ANY,
|
answer_under: LayoutHolds::ANY,
|
||||||
depth: info.depth,
|
depth: info.depth,
|
||||||
@@ -413,7 +354,7 @@ impl UiRenderState {
|
|||||||
rsc: _,
|
rsc: _,
|
||||||
frame: _,
|
frame: _,
|
||||||
extent: _,
|
extent: _,
|
||||||
px: _,
|
window: _,
|
||||||
mask,
|
mask,
|
||||||
textures,
|
textures,
|
||||||
primitives,
|
primitives,
|
||||||
@@ -422,10 +363,9 @@ impl UiRenderState {
|
|||||||
extent_len,
|
extent_len,
|
||||||
answer_under,
|
answer_under,
|
||||||
children,
|
children,
|
||||||
offered: _,
|
|
||||||
at_offer: _,
|
|
||||||
size_deps,
|
size_deps,
|
||||||
frame_own,
|
frame_own,
|
||||||
|
frame_own_len,
|
||||||
under,
|
under,
|
||||||
move_idx,
|
move_idx,
|
||||||
layer,
|
layer,
|
||||||
@@ -441,11 +381,23 @@ impl UiRenderState {
|
|||||||
);
|
);
|
||||||
// A rule wins on the axis it names, and the draw answers the rest.
|
// A rule wins on the axis it names, and the draw answers the rest.
|
||||||
// Applied here so it is one place rather than every widget that could
|
// Applied here so it is one place rather than every widget that could
|
||||||
// carry one, and so the widget under a rule never learns of it.
|
// carry one, and so the widget under a rule never learns of it. The
|
||||||
|
// frame is the answer where the rule gave a length outright: it was
|
||||||
|
// resolved into the frame when the child was asked, and resolving it
|
||||||
|
// again here would take the fraction of a fraction.
|
||||||
let rules = rsc.widgets().size_rules(id);
|
let rules = rsc.widgets().size_rules(id);
|
||||||
|
let ruled = |axis: Axis, reported: LayoutLen| match rules.axis(axis).exact() {
|
||||||
|
None => reported,
|
||||||
|
Some(len) if len.leftover == Weight::ZERO => LayoutLen {
|
||||||
|
rel: info.frame.axis(axis).rel,
|
||||||
|
px: info.frame.axis(axis).px,
|
||||||
|
leftover: Weight::ZERO,
|
||||||
|
},
|
||||||
|
Some(len) => len.within_len(info.frame.axis(axis)),
|
||||||
|
};
|
||||||
let size = Size {
|
let size = Size {
|
||||||
x: rules.x.apply(size.x),
|
x: ruled(Axis::X, size.x),
|
||||||
y: rules.y.apply(size.y),
|
y: ruled(Axis::Y, size.y),
|
||||||
};
|
};
|
||||||
// A widget that clipped its contents to its box drew nothing outside
|
// A widget that clipped its contents to its box drew nothing outside
|
||||||
// it, so reporting more than the box asks to be placed at a length it
|
// it, so reporting more than the box asks to be placed at a length it
|
||||||
@@ -453,7 +405,10 @@ impl UiRenderState {
|
|||||||
// Overflowing is otherwise ordinary: a text too tall for the box it
|
// Overflowing is otherwise ordinary: a text too tall for the box it
|
||||||
// was offered reports the height it needs.
|
// was offered reports the height it needs.
|
||||||
debug_assert!(
|
debug_assert!(
|
||||||
mask == info.mask || AXES.into_iter().all(|axis| within_box(size, px, axis)),
|
mask == info.mask
|
||||||
|
|| AXES
|
||||||
|
.into_iter()
|
||||||
|
.all(|axis| within_box(size, extent, self.output_size, axis)),
|
||||||
"'{}' ({id:?}) clips to {px:?} and reports {size}",
|
"'{}' ({id:?}) clips to {px:?} and reports {size}",
|
||||||
rsc.widgets().label(id),
|
rsc.widgets().label(id),
|
||||||
);
|
);
|
||||||
@@ -465,15 +420,32 @@ impl UiRenderState {
|
|||||||
if let Some(idx) = retired_move {
|
if let Some(idx) = retired_move {
|
||||||
self.moves.remove(idx);
|
self.moves.remove(idx);
|
||||||
}
|
}
|
||||||
|
// A rule that is a fraction of the frame is answered with the
|
||||||
|
// frame's own length, so the answer is that frame's and not just
|
||||||
|
// that many pixels of this window -- the same pin a widget that read
|
||||||
|
// its frame took for its drawing.
|
||||||
|
let frame_len = AXES.map(|axis| {
|
||||||
|
let fraction = rules
|
||||||
|
.axis(axis)
|
||||||
|
.exact()
|
||||||
|
.is_some_and(|len| len.rel != Rel::ZERO);
|
||||||
|
match fraction {
|
||||||
|
true => Some(info.frame.axis(axis)),
|
||||||
|
false => frame_own_len[axis as usize],
|
||||||
|
}
|
||||||
|
});
|
||||||
let own_holds = LayoutHolds {
|
let own_holds = LayoutHolds {
|
||||||
frame: frame_own,
|
frame: frame_own,
|
||||||
|
frame_len,
|
||||||
extent: extent_own,
|
extent: extent_own,
|
||||||
extent_len,
|
extent_len,
|
||||||
};
|
};
|
||||||
let answer_holds = own_holds.and(answer_under);
|
let answer_holds = own_holds.and(answer_under);
|
||||||
let holds = answer_holds.and(under);
|
let holds = under
|
||||||
|
.into_iter()
|
||||||
|
.fold(answer_holds, |holds, (_, child)| holds.and(child));
|
||||||
debug_assert!(
|
debug_assert!(
|
||||||
holds.contains(px, extent),
|
holds.contains(self.output_size, info.frame, extent),
|
||||||
"'{}' ({id:?}) drew in {px:?}, outside the ranges it reported: {holds:?}",
|
"'{}' ({id:?}) drew in {px:?}, outside the ranges it reported: {holds:?}",
|
||||||
rsc.widgets().label(id),
|
rsc.widgets().label(id),
|
||||||
);
|
);
|
||||||
@@ -491,11 +463,12 @@ impl UiRenderState {
|
|||||||
parent_move: move_idx,
|
parent_move: move_idx,
|
||||||
region_node: false,
|
region_node: false,
|
||||||
mask,
|
mask,
|
||||||
frame: UiRegion::FULL,
|
frame: UiVec2::FULL_SIZE,
|
||||||
frame_abs: UiRegion::FULL,
|
|
||||||
part: UiRegion::FULL,
|
part: UiRegion::FULL,
|
||||||
place: [Place::Within(Part::All); 2],
|
place: [Place::Within(Part::All); 2],
|
||||||
offer_place: [Place::Within(Part::All); 2],
|
offer_place: [Place::Within(Part::All); 2],
|
||||||
|
narrow: [None; 2],
|
||||||
|
re_asked: false,
|
||||||
px,
|
px,
|
||||||
},
|
},
|
||||||
rsc,
|
rsc,
|
||||||
@@ -506,14 +479,15 @@ impl UiRenderState {
|
|||||||
|
|
||||||
let active = ActiveData {
|
let active = ActiveData {
|
||||||
id,
|
id,
|
||||||
frame_abs: frame,
|
|
||||||
extent,
|
extent,
|
||||||
frame: info.frame,
|
frame: info.frame,
|
||||||
|
narrow: info.narrow,
|
||||||
place: info.place,
|
place: info.place,
|
||||||
offer_place: info.offer_place,
|
offer_place: info.offer_place,
|
||||||
offer_part: old_offer_part.unwrap_or(extent),
|
offer_part: extent,
|
||||||
// Whoever asked writes the answer, if this was the asking.
|
// Whoever asked writes the answer.
|
||||||
answer: old_answer,
|
answer: None,
|
||||||
|
re_asked: info.re_asked,
|
||||||
size,
|
size,
|
||||||
holds,
|
holds,
|
||||||
drawn: true,
|
drawn: true,
|
||||||
@@ -576,38 +550,22 @@ impl UiRenderState {
|
|||||||
return None;
|
return None;
|
||||||
}
|
}
|
||||||
let answer = active.answer?;
|
let answer = active.answer?;
|
||||||
answer.1.contains(info.px, part).then_some(answer)
|
answer
|
||||||
|
.1
|
||||||
|
.contains(self.output_size, info.frame, part)
|
||||||
|
.then_some(answer)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The pixel lengths of a widget's frame, which is what a local redraw
|
/// Keeps the retained drawing if its contract holds for `part`, the box
|
||||||
/// needs to ask the question its parent asked.
|
/// asked about, and puts it at `extent`, where the answer places it.
|
||||||
///
|
|
||||||
/// It is threaded down from the window a length of a box at a time, and
|
|
||||||
/// this takes the same steps back up: a widget's frame is a length of its
|
|
||||||
/// parent's frame, and that chain has no coordinate frame in it, so a
|
|
||||||
/// region node cannot break it -- and it lands on the number a cold
|
|
||||||
/// layout computes rather than near it.
|
|
||||||
fn asked_px(&self, id: WidgetId) -> PxVec2 {
|
|
||||||
let active = &self.active[&id];
|
|
||||||
// Nothing above the root: the window is where a fraction becomes
|
|
||||||
// pixels, which is also the whole of the frame the root is given.
|
|
||||||
let parent_px = match active.parent.and_then(|p| self.active.get(&p)) {
|
|
||||||
Some(parent) => self.asked_px(parent.id),
|
|
||||||
None => self.output_size,
|
|
||||||
};
|
|
||||||
active.frame.size().to_px(parent_px)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Reuses the actual drawing in a new box if its retained contract holds
|
|
||||||
/// there. Answers retained from a different ask are handled separately.
|
|
||||||
fn try_reuse(
|
fn try_reuse(
|
||||||
&mut self,
|
&mut self,
|
||||||
id: WidgetId,
|
id: WidgetId,
|
||||||
frame: UiRegion,
|
part: UiRegion,
|
||||||
extent: UiRegion,
|
extent: UiRegion,
|
||||||
info: DrawInfo,
|
info: DrawInfo,
|
||||||
rsc: &mut dyn UiRsc,
|
rsc: &mut dyn UiRsc,
|
||||||
) -> Option<(Size, LayoutHolds)> {
|
) -> Option<()> {
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
diag::bump(Counter::ReuseAttempts);
|
diag::bump(Counter::ReuseAttempts);
|
||||||
if rsc.widgets().needs_redraw.contains(&id) {
|
if rsc.widgets().needs_redraw.contains(&id) {
|
||||||
@@ -653,10 +611,10 @@ impl UiRenderState {
|
|||||||
}
|
}
|
||||||
return None;
|
return None;
|
||||||
}
|
}
|
||||||
// In pixels, because the frame is a fraction of its parent's and
|
// In pixels, because the box is a fraction of the window and that
|
||||||
// that may be what changed -- an unchanged fraction of a box half the
|
// may be what changed -- an unchanged fraction of a window half the
|
||||||
// size is half the widget.
|
// size is half the widget.
|
||||||
if !active.holds.contains(info.px, extent) {
|
if !active.holds.contains(self.output_size, info.frame, part) {
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
{
|
{
|
||||||
// Which of the three said no, so a frame that redraws more
|
// Which of the three said no, so a frame that redraws more
|
||||||
@@ -665,13 +623,16 @@ impl UiRenderState {
|
|||||||
let holds = active.holds;
|
let holds = active.holds;
|
||||||
for axis in AXES {
|
for axis in AXES {
|
||||||
let n = axis as usize;
|
let n = axis as usize;
|
||||||
if holds.extent_len[n].is_some_and(|pinned| pinned != extent.axis(axis).len()) {
|
if holds.extent_len[n].is_some_and(|pinned| pinned != part.axis(axis).len()) {
|
||||||
diag::bump(Counter::OutsidePinnedLen);
|
diag::bump(Counter::OutsidePinnedLen);
|
||||||
}
|
}
|
||||||
if !holds.frame[n].contains(info.px.axis(axis)) {
|
if !holds.frame[n].contains(self.output_size.axis(axis))
|
||||||
|
|| holds.frame_len[n].is_some_and(|pinned| pinned != info.frame.axis(axis))
|
||||||
|
{
|
||||||
diag::bump(Counter::OutsideFrame);
|
diag::bump(Counter::OutsideFrame);
|
||||||
}
|
}
|
||||||
if !holds.extent[n].contains(extent.axis(axis).len().to_px(info.px.axis(axis)))
|
if !holds.extent[n]
|
||||||
|
.contains(part.axis(axis).len().to_px(self.output_size.axis(axis)))
|
||||||
{
|
{
|
||||||
diag::bump(Counter::OutsideExtent);
|
diag::bump(Counter::OutsideExtent);
|
||||||
}
|
}
|
||||||
@@ -681,22 +642,35 @@ impl UiRenderState {
|
|||||||
}
|
}
|
||||||
return None;
|
return None;
|
||||||
}
|
}
|
||||||
let extent_moved = active.extent != extent;
|
self.relocate(id, extent, info, rsc);
|
||||||
let moved = active.frame_abs != frame;
|
Some(())
|
||||||
let (answer, slot) = ((active.size, active.holds), active.move_idx);
|
}
|
||||||
if moved {
|
|
||||||
|
/// Puts a retained drawing where its parent now has it, without drawing:
|
||||||
|
/// a widget with a node of its own writes that node's translation, and
|
||||||
|
/// one without re-expresses its own drawing and everything inside it.
|
||||||
|
fn relocate(&mut self, id: WidgetId, extent: UiRegion, info: DrawInfo, rsc: &mut dyn UiRsc) {
|
||||||
|
let active = &self.active[&id];
|
||||||
|
debug_assert!(
|
||||||
|
!rsc.widgets().needs_redraw.contains(&id),
|
||||||
|
"'{}' ({id:?}) placed while marked to draw",
|
||||||
|
rsc.widgets().label(id)
|
||||||
|
);
|
||||||
|
let has_region_node = active.move_idx != active.parent_move;
|
||||||
|
let local = match has_region_node {
|
||||||
|
true => local_region(extent),
|
||||||
|
false => extent,
|
||||||
|
};
|
||||||
|
let moved = active.extent != local;
|
||||||
|
let slot = active.move_idx;
|
||||||
if has_region_node {
|
if has_region_node {
|
||||||
self.moves.set(slot, frame);
|
self.moves.set(slot, translation(extent));
|
||||||
} else {
|
|
||||||
self.recompose_subtree(id, frame, info.parent_move, rsc);
|
|
||||||
}
|
}
|
||||||
}
|
if moved {
|
||||||
if extent_moved {
|
self.reposition(id, local, info, rsc);
|
||||||
self.reposition(id, frame, extent, info, rsc);
|
|
||||||
}
|
}
|
||||||
self.redepth(id, info.depth);
|
self.redepth(id, info.depth);
|
||||||
let active = self.active.get_mut(&id).unwrap();
|
let active = self.active.get_mut(&id).unwrap();
|
||||||
active.frame_abs = frame;
|
|
||||||
active.frame = info.frame;
|
active.frame = info.frame;
|
||||||
active.place = info.place;
|
active.place = info.place;
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
@@ -719,20 +693,31 @@ impl UiRenderState {
|
|||||||
},
|
},
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
Some(answer)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Places one child of `at.id` in the box that widget's own box gives
|
/// Places one child of `at.id` where that widget's own box now has it.
|
||||||
/// it: its part of the extent, with its answer placed inside that part
|
|
||||||
/// where the ask left the axis open.
|
|
||||||
fn place_child(&mut self, child: WidgetId, at: &Placing, rsc: &mut dyn UiRsc) {
|
fn place_child(&mut self, child: WidgetId, at: &Placing, rsc: &mut dyn UiRsc) {
|
||||||
|
let place = self.active[&child].place;
|
||||||
|
self.place_in(child, at, place, rsc);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Puts a child of `at.id` in `place` of that widget's box: its answer
|
||||||
|
/// placed inside that part where the place leaves the axis open, the
|
||||||
|
/// drawing re-expressed there.
|
||||||
|
pub(super) fn place_in(
|
||||||
|
&mut self,
|
||||||
|
child: WidgetId,
|
||||||
|
at: &Placing,
|
||||||
|
place: [Place; 2],
|
||||||
|
rsc: &mut dyn UiRsc,
|
||||||
|
) {
|
||||||
let active = &self.active[&child];
|
let active = &self.active[&child];
|
||||||
let (frame, part) = Self::re_ask(active, at.extent, active.place);
|
let (frame, part) = Self::ask_again(active, at, place);
|
||||||
let extent = placed_extent(
|
let extent = placed_extent(
|
||||||
part,
|
part,
|
||||||
active.measured().unwrap_or(active.size),
|
active.measured().unwrap_or(active.size),
|
||||||
active.declared,
|
active.declared,
|
||||||
active.place.map(Place::fills),
|
place.map(Place::fills),
|
||||||
active.own_align,
|
active.own_align,
|
||||||
);
|
);
|
||||||
let info = DrawInfo {
|
let info = DrawInfo {
|
||||||
@@ -743,34 +728,27 @@ impl UiRenderState {
|
|||||||
region_node: active.move_idx != active.parent_move,
|
region_node: active.move_idx != active.parent_move,
|
||||||
mask: at.mask,
|
mask: at.mask,
|
||||||
frame,
|
frame,
|
||||||
frame_abs: frame.within(&at.local),
|
|
||||||
part,
|
part,
|
||||||
place: active.place,
|
place,
|
||||||
offer_place: active.offer_place,
|
offer_place: active.offer_place,
|
||||||
px: frame.size().to_px(at.px),
|
narrow: active.narrow,
|
||||||
|
re_asked: active.re_asked,
|
||||||
|
px: frame.to_px(at.window),
|
||||||
};
|
};
|
||||||
self.place(child, extent, info, rsc);
|
self.relocate(child, extent, info, rsc);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The frame and the box a widget being asked again is given, from what
|
/// The frame and the box a widget already drawn is given at `place` of
|
||||||
/// it already has and where its parent's box is now. A frame's length is
|
/// the box its parent is being taken as. What narrowed its frame and what
|
||||||
/// the same on every ask, so a declared length is put back where it sits
|
/// it declared are its own record's, so both are resolved against that
|
||||||
/// in the part rather than resolved from its rule a second time.
|
/// parent's frame again exactly as the first ask resolved them.
|
||||||
fn re_ask(
|
fn ask_again(active: &ActiveData, at: &Placing, place: [Place; 2]) -> (UiVec2, UiRegion) {
|
||||||
active: &ActiveData,
|
|
||||||
parent_extent: UiRegion,
|
|
||||||
place: [Place; 2],
|
|
||||||
) -> (UiRegion, UiRegion) {
|
|
||||||
let narrow = AXES.map(|axis| {
|
|
||||||
let n = axis as usize;
|
|
||||||
active.declared[n]
|
|
||||||
.is_some()
|
|
||||||
.then(|| active.frame.axis(axis).len())
|
|
||||||
});
|
|
||||||
frame_and_extent(
|
frame_and_extent(
|
||||||
active.frame,
|
at.extent,
|
||||||
part_of(parent_extent, place),
|
at.frame,
|
||||||
narrow,
|
place,
|
||||||
|
active.narrow,
|
||||||
|
active.declared,
|
||||||
active.own_align,
|
active.own_align,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
@@ -779,36 +757,21 @@ impl UiRenderState {
|
|||||||
/// is placed as a part of that box, so each one's new box is its retained
|
/// is placed as a part of that box, so each one's new box is its retained
|
||||||
/// part re-added to the new start -- and a child whose own box then did
|
/// part re-added to the new start -- and a child whose own box then did
|
||||||
/// not change is not touched at all.
|
/// not change is not touched at all.
|
||||||
fn reposition(
|
fn reposition(&mut self, id: WidgetId, extent: UiRegion, info: DrawInfo, rsc: &mut dyn UiRsc) {
|
||||||
&mut self,
|
|
||||||
id: WidgetId,
|
|
||||||
frame: UiRegion,
|
|
||||||
extent: UiRegion,
|
|
||||||
info: DrawInfo,
|
|
||||||
rsc: &mut dyn UiRsc,
|
|
||||||
) {
|
|
||||||
let active = self.active.get_mut(&id).unwrap();
|
let active = self.active.get_mut(&id).unwrap();
|
||||||
active.frame_abs = frame;
|
|
||||||
active.extent = extent;
|
active.extent = extent;
|
||||||
let local = if info.region_node {
|
|
||||||
UiRegion::FULL
|
|
||||||
} else {
|
|
||||||
frame
|
|
||||||
};
|
|
||||||
for primitive in &active.primitives {
|
for primitive in &active.primitives {
|
||||||
let handle = &primitive.handle;
|
let handle = &primitive.handle;
|
||||||
*self.layers[handle.layer].region_mut(handle) =
|
*self.layers[handle.layer].region_mut(handle) = primitive.region.within(&extent);
|
||||||
primitive.region.within(&extent).within(&local);
|
|
||||||
}
|
}
|
||||||
if let Some(mask_region) = active.mask_region {
|
if let Some(mask_region) = active.mask_region {
|
||||||
rsc.ui_mut().masks.get_mut(active.mask).region =
|
rsc.ui_mut().masks.get_mut(active.mask).region = mask_region.within(&extent);
|
||||||
mask_region.within(&extent).within(&local);
|
|
||||||
}
|
}
|
||||||
let at = Placing {
|
let at = Placing {
|
||||||
id,
|
id,
|
||||||
extent,
|
extent,
|
||||||
local,
|
frame: info.frame,
|
||||||
px: info.px,
|
window: self.output_size,
|
||||||
depth: info.depth,
|
depth: info.depth,
|
||||||
move_idx: active.move_idx,
|
move_idx: active.move_idx,
|
||||||
mask: active.mask,
|
mask: active.mask,
|
||||||
@@ -838,38 +801,6 @@ impl UiRenderState {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Replays the original local compositions, including their rounding order.
|
|
||||||
/// A region node terminates the walk because its contents name its slot.
|
|
||||||
fn recompose_subtree(
|
|
||||||
&mut self,
|
|
||||||
id: WidgetId,
|
|
||||||
frame: UiRegion,
|
|
||||||
parent_move: MoveIdx,
|
|
||||||
rsc: &mut dyn UiRsc,
|
|
||||||
) {
|
|
||||||
let active = self.active.get_mut(&id).unwrap();
|
|
||||||
active.frame_abs = frame;
|
|
||||||
if active.move_idx != parent_move {
|
|
||||||
self.moves.set(active.move_idx, frame);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
let extent = active.extent;
|
|
||||||
for primitive in &active.primitives {
|
|
||||||
let handle = &primitive.handle;
|
|
||||||
*self.layers[handle.layer].region_mut(handle) =
|
|
||||||
primitive.region.within(&extent).within(&frame);
|
|
||||||
}
|
|
||||||
if let Some(local) = active.mask_region {
|
|
||||||
rsc.ui_mut().masks.get_mut(active.mask).region = local.within(&extent).within(&frame);
|
|
||||||
}
|
|
||||||
let children = active.children.len();
|
|
||||||
for index in 0..children {
|
|
||||||
let child = self.active[&id].children[index];
|
|
||||||
let local = self.active[&child].frame;
|
|
||||||
self.recompose_subtree(child, local.within(&frame), parent_move, rsc);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn hints_agree(id: WidgetId, size: Size, rsc: &dyn UiRsc) -> bool {
|
fn hints_agree(id: WidgetId, size: Size, rsc: &dyn UiRsc) -> bool {
|
||||||
let Some(widget) = rsc.widgets().get_dyn(id) else {
|
let Some(widget) = rsc.widgets().get_dyn(id) else {
|
||||||
return true;
|
return true;
|
||||||
@@ -940,13 +871,14 @@ impl UiRenderState {
|
|||||||
id,
|
id,
|
||||||
ActiveData {
|
ActiveData {
|
||||||
id,
|
id,
|
||||||
frame_abs: UiRegion::FULL,
|
|
||||||
extent: UiRegion::FULL,
|
extent: UiRegion::FULL,
|
||||||
frame: UiRegion::FULL,
|
frame: UiVec2::FULL_SIZE,
|
||||||
|
narrow: [None; 2],
|
||||||
place: [Place::Within(Part::All); 2],
|
place: [Place::Within(Part::All); 2],
|
||||||
offer_place: [Place::Within(Part::All); 2],
|
offer_place: [Place::Within(Part::All); 2],
|
||||||
offer_part: UiRegion::FULL,
|
offer_part: UiRegion::FULL,
|
||||||
answer: None,
|
answer: None,
|
||||||
|
re_asked: false,
|
||||||
size,
|
size,
|
||||||
holds: LayoutHolds::ANY,
|
holds: LayoutHolds::ANY,
|
||||||
drawn: false,
|
drawn: false,
|
||||||
@@ -1127,9 +1059,8 @@ impl UiRenderState {
|
|||||||
pub fn window_region(&self, id: &impl IdLike) -> Option<PixelRegion> {
|
pub fn window_region(&self, id: &impl IdLike) -> Option<PixelRegion> {
|
||||||
let active = self.active.get(&id.id())?;
|
let active = self.active.get(&id.id())?;
|
||||||
active.drawn.then(|| {
|
active.drawn.then(|| {
|
||||||
let placed = active.extent.within(&active.frame_abs);
|
|
||||||
self.moves
|
self.moves
|
||||||
.resolve(active.parent_move, placed)
|
.resolve(active.move_idx, active.extent)
|
||||||
.to_px(self.output_size)
|
.to_px(self.output_size)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -1146,11 +1077,16 @@ impl UiRenderState {
|
|||||||
// Its parent resolved its declared lengths into its box and decided
|
// Its parent resolved its declared lengths into its box and decided
|
||||||
// whether to draw it at all, so a change to either is the parent's
|
// whether to draw it at all, so a change to either is the parent's
|
||||||
// to draw -- with the mark left on, so the parent draws it rather
|
// to draw -- with the mark left on, so the parent draws it rather
|
||||||
// than keeping it.
|
// than keeping it. So is a widget the parent asked twice: its
|
||||||
|
// layout rests on an answer this widget cannot give again alone.
|
||||||
let declared_changed = declared_lens(rsc.widgets(), id) != active.declared;
|
let declared_changed = declared_lens(rsc.widgets(), id) != active.declared;
|
||||||
let alignment_changed = rsc.widgets().alignment(id) != active.own_align;
|
let alignment_changed = rsc.widgets().alignment(id) != active.own_align;
|
||||||
if let Some(parent) = active.parent
|
if let Some(parent) = active.parent
|
||||||
&& (declared_changed || alignment_changed || !active.drawn || active.answer.is_none())
|
&& (declared_changed
|
||||||
|
|| alignment_changed
|
||||||
|
|| active.re_asked
|
||||||
|
|| !active.drawn
|
||||||
|
|| active.answer.is_none())
|
||||||
{
|
{
|
||||||
// Both stay marked: the parent because it has this to draw, and
|
// Both stay marked: the parent because it has this to draw, and
|
||||||
// this because the parent must draw it rather than keep what it
|
// this because the parent must draw it rather than keep what it
|
||||||
@@ -1166,10 +1102,10 @@ impl UiRenderState {
|
|||||||
// box is its own to work out again against the output. Every other
|
// box is its own to work out again against the output. Every other
|
||||||
// widget was given one.
|
// widget was given one.
|
||||||
let Some(parent) = active.parent else {
|
let Some(parent) = active.parent else {
|
||||||
let region = Self::root_region(id, rsc.widgets());
|
let (frame, extent) = Self::root_layout(id, rsc.widgets());
|
||||||
let info = DrawInfo {
|
let info = DrawInfo {
|
||||||
mask: active.parent_mask,
|
mask: active.parent_mask,
|
||||||
..self.root_info(region)
|
..self.root_info(frame, extent)
|
||||||
};
|
};
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
diag::bump(Counter::LocalRedraws);
|
diag::bump(Counter::LocalRedraws);
|
||||||
@@ -1177,13 +1113,14 @@ impl UiRenderState {
|
|||||||
self.draw_inner(id, info, old, rsc);
|
self.draw_inner(id, info, old, rsc);
|
||||||
return true;
|
return true;
|
||||||
};
|
};
|
||||||
let px = self.asked_px(id);
|
let (was_answer, was_holds, was_place) = (active.answer, active.holds, active.place);
|
||||||
let (was_answer, was_holds) = (active.answer, active.holds);
|
// The question its parent asked, asked again: the same place of the
|
||||||
// The boxes its parent gave it, then and now: its frame is the same
|
// box the parent was asked in, which is the box the parent's own
|
||||||
// on every ask, so the question its parent asked is the one this
|
// draw ran in and what its children's parts are of. Where the
|
||||||
// asks again -- there is no box here that could be its parent's to
|
// parent's answer put its own drawing is not a question anybody
|
||||||
// choose instead.
|
// asked, and nothing is asked in it here either.
|
||||||
let parent_extent = self.active[&parent].extent;
|
let asked = self.placing_of(parent, self.active[&parent].offer_part);
|
||||||
|
let (frame, part) = Self::ask_again(active, &asked, active.offer_place);
|
||||||
let info = DrawInfo {
|
let info = DrawInfo {
|
||||||
layer: active.layer,
|
layer: active.layer,
|
||||||
parent: active.parent,
|
parent: active.parent,
|
||||||
@@ -1191,51 +1128,19 @@ impl UiRenderState {
|
|||||||
parent_move: active.parent_move,
|
parent_move: active.parent_move,
|
||||||
region_node: rsc.widgets().is_region_node(id),
|
region_node: rsc.widgets().is_region_node(id),
|
||||||
mask: active.parent_mask,
|
mask: active.parent_mask,
|
||||||
frame: active.frame,
|
frame,
|
||||||
frame_abs: active.frame_abs,
|
part,
|
||||||
part: Self::re_ask(active, parent_extent, active.place).1,
|
place: active.offer_place,
|
||||||
place: active.place,
|
|
||||||
offer_place: active.offer_place,
|
offer_place: active.offer_place,
|
||||||
px,
|
narrow: active.narrow,
|
||||||
};
|
re_asked: false,
|
||||||
// The ask that measured it, asked again: the box it was measured in
|
px: frame.to_px(self.output_size),
|
||||||
// as its parent left it, rather than where that ask's place resolves
|
|
||||||
// to now -- a parent drawn again in the box its own answer chose
|
|
||||||
// gives its children boxes it never measured anything in.
|
|
||||||
let offered = DrawInfo {
|
|
||||||
place: info.offer_place,
|
|
||||||
part: active.offer_part,
|
|
||||||
..info
|
|
||||||
};
|
};
|
||||||
#[cfg(feature = "layout-diagnostics")]
|
#[cfg(feature = "layout-diagnostics")]
|
||||||
diag::bump(Counter::LocalRedraws);
|
diag::bump(Counter::LocalRedraws);
|
||||||
|
|
||||||
// Asked again in the box its parent gave it, which is the question
|
|
||||||
// its parent asked only while that box is as long as the one it was
|
|
||||||
// measured in. Any other box is a different question, so the parent
|
|
||||||
// asks it, with the mark left on. Lengths and not whole boxes: what
|
|
||||||
// a drawing depends on is its lengths, so the same lengths elsewhere
|
|
||||||
// is one question.
|
|
||||||
//
|
|
||||||
// The frame is the same on every ask now, so this is about the box
|
|
||||||
// the drawing goes in alone. Removing it -- asking the measuring
|
|
||||||
// question here and placing the answer afterwards -- is what the
|
|
||||||
// transparent-frames plan asks for next, and it does not hold yet:
|
|
||||||
// seeds 104 (`align`) and 210 (`reorder`) at depth 5 settle
|
|
||||||
// differently warm and cold without it.
|
|
||||||
if info.part.size() != offered.part.size() {
|
|
||||||
self.mark(id, rsc.widgets_mut());
|
|
||||||
self.mark(parent, rsc.widgets_mut());
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
let old = self.remove(id, false, rsc);
|
let old = self.remove(id, false, rsc);
|
||||||
// The original measurement is refreshed before the assigned slot is
|
let answer = self.draw_inner(id, info, old, rsc);
|
||||||
// restored: its lengths may differ even though the frame is
|
|
||||||
// unchanged.
|
|
||||||
let answer = self.draw_inner(id, offered, old, rsc);
|
|
||||||
if info.place != info.offer_place || info.part != offered.part {
|
|
||||||
self.draw_inner(id, info, None, rsc);
|
|
||||||
}
|
|
||||||
let active = self.active.get_mut(&id).unwrap();
|
let active = self.active.get_mut(&id).unwrap();
|
||||||
// A wider contract does not invalidate the guarantee the parent kept.
|
// A wider contract does not invalidate the guarantee the parent kept.
|
||||||
// Retain that guarantee so widening and narrowing back do not churn it.
|
// Retain that guarantee so widening and narrowing back do not churn it.
|
||||||
@@ -1245,7 +1150,9 @@ impl UiRenderState {
|
|||||||
{
|
{
|
||||||
active.answer = was_answer;
|
active.answer = was_answer;
|
||||||
}
|
}
|
||||||
if active.holds.covers(was_holds) && was_holds.contains(px, active.extent) {
|
if active.holds.covers(was_holds)
|
||||||
|
&& was_holds.contains(self.output_size, active.frame, active.extent)
|
||||||
|
{
|
||||||
active.holds = was_holds;
|
active.holds = was_holds;
|
||||||
}
|
}
|
||||||
if active.answer != was_answer || active.holds != was_holds {
|
if active.answer != was_answer || active.holds != was_holds {
|
||||||
@@ -1257,18 +1164,61 @@ impl UiRenderState {
|
|||||||
diag::bump(Counter::ReaderEdges);
|
diag::bump(Counter::ReaderEdges);
|
||||||
}
|
}
|
||||||
self.mark(parent, rsc.widgets_mut());
|
self.mark(parent, rsc.widgets_mut());
|
||||||
|
} else {
|
||||||
|
// The answer stands, so where the parent put it stands: the
|
||||||
|
// fresh drawing goes back there -- the same place, of the box
|
||||||
|
// the parent's answer chose rather than the one it was asked in.
|
||||||
|
let at = self.placing_of(parent, self.active[&parent].extent);
|
||||||
|
self.place_in(id, &at, was_place, rsc);
|
||||||
}
|
}
|
||||||
true
|
true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// A drawn widget as the thing its children are placed within, with
|
||||||
|
/// `extent` as the box their parts are of: the box it was asked in for
|
||||||
|
/// asking one of them again, the box its answer chose for placing one.
|
||||||
|
fn placing_of(&self, id: WidgetId, extent: UiRegion) -> Placing {
|
||||||
|
let active = &self.active[&id];
|
||||||
|
Placing {
|
||||||
|
id,
|
||||||
|
extent,
|
||||||
|
frame: active.frame,
|
||||||
|
window: self.output_size,
|
||||||
|
depth: active.depth,
|
||||||
|
move_idx: active.move_idx,
|
||||||
|
mask: active.mask,
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Whether what a widget reports along `axis` is inside the box it drew in.
|
/// Whether what a widget reports along `axis` is inside the box it drew in.
|
||||||
/// A share is a length only to whoever divides one, so it is not a claim
|
/// Both are lengths of the window, so the comparison is in its pixels. A
|
||||||
/// about this box and cannot exceed it.
|
/// share is a length only to whoever divides one, so it is not a claim about
|
||||||
fn within_box(size: Size, px: PxVec2, axis: Axis) -> bool {
|
/// this box and cannot exceed it.
|
||||||
|
fn within_box(size: Size, extent: UiRegion, window: PxVec2, axis: Axis) -> bool {
|
||||||
let len = size.axis(axis);
|
let len = size.axis(axis);
|
||||||
let box_len = px.axis(axis);
|
let window = window.axis(axis);
|
||||||
len.leftover != Weight::ZERO || box_len.mul(len.rel) + len.px <= box_len
|
len.leftover != Weight::ZERO
|
||||||
|
|| Len::from_parts(len.rel, len.px).to_px(window) <= extent.axis(axis).len().to_px(window)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A box in a fresh region node keeps its window-unit length and starts at
|
||||||
|
/// that node's origin.
|
||||||
|
fn local_region(region: UiRegion) -> UiRegion {
|
||||||
|
let size = region.size();
|
||||||
|
UiRegion::new(
|
||||||
|
UiSpan::new(Len::ZERO, size.x),
|
||||||
|
UiSpan::new(Len::ZERO, size.y),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A region node changes only the origin. A full relative span anchored at
|
||||||
|
/// the box start composes as that translation in both the CPU and shader.
|
||||||
|
fn translation(region: UiRegion) -> UiRegion {
|
||||||
|
UiRegion {
|
||||||
|
x: UiSpan::new(region.x.start, region.x.start + Len::FULL),
|
||||||
|
y: UiSpan::new(region.y.start, region.y.start + Len::FULL),
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Default for UiRenderState {
|
impl Default for UiRenderState {
|
||||||
|
|||||||
+15
-5
@@ -120,15 +120,25 @@ impl Widget for Branch {
|
|||||||
let cut = Len::from_parts(Rel::ZERO, Px::from_int(40));
|
let cut = Len::from_parts(Rel::ZERO, Px::from_int(40));
|
||||||
let top = Place::Within(Part::From(UiSpan::new(Len::ZERO, cut)));
|
let top = Place::Within(Part::From(UiSpan::new(Len::ZERO, cut)));
|
||||||
let measured = painter
|
let measured = painter
|
||||||
.widget_at(&self.probe, UiRegion::FULL, [Place::Within(Part::All), top])
|
.widget_at(&self.probe, [None; 2], [Place::Within(Part::All), top])
|
||||||
.len(Axis::X);
|
.len(Axis::X);
|
||||||
let px = measured.apply_leftover().to_px(painter.px_len(Axis::X));
|
let len = measured.apply_leftover();
|
||||||
|
let px = painter.to_px(len, Axis::X);
|
||||||
|
// The range it actually branched on, said the way a container says
|
||||||
|
// one: pinning the window instead would redraw this widget on every
|
||||||
|
// resize, which is a fixture that never exercises reuse.
|
||||||
|
let threshold = Px::from_f32(self.threshold);
|
||||||
|
let holds = match px > threshold {
|
||||||
|
true => Holds::from(threshold + Px::STEP..=Px::MAX),
|
||||||
|
false => Holds::from(Px::MIN..=threshold),
|
||||||
|
};
|
||||||
|
painter.window_holds(Axis::X, holds.through(len));
|
||||||
|
|
||||||
let below = Place::Within(Part::From(UiSpan::new(cut, painter.extent_len(Axis::Y))));
|
let below = Place::Within(Part::From(UiSpan::new(cut, painter.extent_len(Axis::Y))));
|
||||||
let place = [Place::Within(Part::All), below];
|
let place = [Place::Within(Part::All), below];
|
||||||
match px > Px::from_f32(self.threshold) {
|
match px > threshold {
|
||||||
true => painter.widget_at(&self.wide, UiRegion::FULL, place),
|
true => painter.widget_at(&self.wide, [None; 2], place),
|
||||||
false => painter.widget_at(&self.narrow, UiRegion::FULL, place),
|
false => painter.widget_at(&self.narrow, [None; 2], place),
|
||||||
};
|
};
|
||||||
Size::LEFTOVER
|
Size::LEFTOVER
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -15,6 +15,6 @@ impl Widget for Offset {
|
|||||||
moved(painter.extent_len(Axis::X), self.amt.x),
|
moved(painter.extent_len(Axis::X), self.amt.x),
|
||||||
moved(painter.extent_len(Axis::Y), self.amt.y),
|
moved(painter.extent_len(Axis::Y), self.amt.y),
|
||||||
];
|
];
|
||||||
painter.widget_at(&self.inner, UiRegion::FULL, place).size()
|
painter.widget_at(&self.inner, [None; 2], place).size()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -14,12 +14,11 @@ impl Widget for Pad {
|
|||||||
// widget -- the slack is the inner's to sit in, and forcing the near
|
// widget -- the slack is the inner's to sit in, and forcing the near
|
||||||
// edge pinned it to a corner it had not asked for.
|
// edge pinned it to a corner it had not asked for.
|
||||||
//
|
//
|
||||||
// The padding goes around what it pads: the frame passes through, so
|
// Padding is an inset of both: it comes off the frame, so `rel(1)`
|
||||||
// the inner's fractions mean what they would without it, and only
|
// under it fills this widget rather than overflowing it by the
|
||||||
// the box it draws in is moved in by the pixels. Said as a part of
|
// padding, and it comes off the box, so what is drawn sits inside.
|
||||||
// this widget's own box in that box's own lengths, so nothing here
|
// The two stay distinct -- the box can be narrower still, where a row
|
||||||
// reads how long the box is -- and a box chosen from this widget's
|
// asked this widget in the room left, and a text wraps at that.
|
||||||
// own answer therefore does not feed back into that answer.
|
|
||||||
let inset = |lead: Px, trail: Px| {
|
let inset = |lead: Px, trail: Px| {
|
||||||
Place::Within(Part::Of(UiSpan::new(
|
Place::Within(Part::Of(UiSpan::new(
|
||||||
Len::from_parts(Rel::ZERO, lead),
|
Len::from_parts(Rel::ZERO, lead),
|
||||||
@@ -30,7 +29,16 @@ impl Widget for Pad {
|
|||||||
inset(self.padding.left, self.padding.right),
|
inset(self.padding.left, self.padding.right),
|
||||||
inset(self.padding.top, self.padding.bottom),
|
inset(self.padding.top, self.padding.bottom),
|
||||||
];
|
];
|
||||||
let inner = painter.widget_at(&self.inner, UiRegion::FULL, place).size();
|
// Read from this widget's own frame rather than written as a
|
||||||
|
// fraction of it: a frame is a length of the window like everything
|
||||||
|
// else here, and taking the padding off is the whole of what this
|
||||||
|
// widget does to it.
|
||||||
|
let narrow = [
|
||||||
|
(Axis::X, self.padding.left + self.padding.right),
|
||||||
|
(Axis::Y, self.padding.top + self.padding.bottom),
|
||||||
|
]
|
||||||
|
.map(|(axis, pixels)| Some(painter.frame_len(axis) - Len::from_parts(Rel::ZERO, pixels)));
|
||||||
|
let inner = painter.widget_at(&self.inner, narrow, place).size();
|
||||||
Size {
|
Size {
|
||||||
x: LayoutLen {
|
x: LayoutLen {
|
||||||
px: inner.x.px + self.padding.left + self.padding.right,
|
px: inner.x.px + self.padding.left + self.padding.right,
|
||||||
|
|||||||
@@ -12,12 +12,11 @@ pub struct Scroll {
|
|||||||
impl Widget for Scroll {
|
impl Widget for Scroll {
|
||||||
fn draw(&mut self, painter: &mut Painter) -> Size {
|
fn draw(&mut self, painter: &mut Painter) -> Size {
|
||||||
let container_len = painter.px_len(self.axis);
|
let container_len = painter.px_len(self.axis);
|
||||||
// Measured in the whole viewport, then drawn at the scrolled offset.
|
// Asked in the whole viewport, then put at the scrolled offset.
|
||||||
let whole = UiRegion::FULL;
|
|
||||||
let answer_len = painter
|
let answer_len = painter
|
||||||
.widget_at(&self.inner, whole, [Place::Fill(Part::All); 2])
|
.widget_at(&self.inner, [None; 2], [Place::Fill(Part::All); 2])
|
||||||
.len(self.axis);
|
.len(self.axis);
|
||||||
let fixed = Len::from_parts(answer_len.rel, answer_len.px).to_px(container_len);
|
let fixed = painter.to_px(Len::from_parts(answer_len.rel, answer_len.px), self.axis);
|
||||||
self.container_len = container_len;
|
self.container_len = container_len;
|
||||||
self.content_len = fixed.max(container_len);
|
self.content_len = fixed.max(container_len);
|
||||||
|
|
||||||
@@ -59,11 +58,10 @@ impl Widget for Scroll {
|
|||||||
}
|
}
|
||||||
// The viewport is the inner's frame, so a fraction it declares or
|
// The viewport is the inner's frame, so a fraction it declares or
|
||||||
// reports is a fraction of what is on screen rather than of the
|
// reports is a fraction of what is on screen rather than of the
|
||||||
// content box its own answer decided. Where it is drawn is the
|
// content box its own answer decided. Where it goes is the content
|
||||||
// content box, scrolled.
|
// box, scrolled: its drawing moved there, not made again there.
|
||||||
painter.widget_at(
|
painter.place_at(
|
||||||
&self.inner,
|
&self.inner,
|
||||||
whole,
|
|
||||||
self.axis
|
self.axis
|
||||||
.pair(Place::Fill(Part::From(content)), Place::Fill(Part::All)),
|
.pair(Place::Fill(Part::From(content)), Place::Fill(Part::All)),
|
||||||
);
|
);
|
||||||
|
|||||||
+34
-15
@@ -25,19 +25,23 @@ impl Widget for Span {
|
|||||||
// A length for every child before their final slots are chosen. The
|
// A length for every child before their final slots are chosen. The
|
||||||
// frame passes through unchanged, so `rel(0.5)` is half the area this
|
// frame passes through unchanged, so `rel(0.5)` is half the area this
|
||||||
// span was given whatever else is in it and wherever this child sits
|
// span was given whatever else is in it and wherever this child sits
|
||||||
// among them; what it is drawn in is the room left from the cursor,
|
// among them; what it is asked in is the room left from the cursor,
|
||||||
// because a text has to wrap at the width actually there.
|
// because a text has to wrap at the width actually there. This is
|
||||||
|
// the one ask a fixed child gets: its slot is its answer, and the
|
||||||
|
// drawing is moved there once the shares are known.
|
||||||
let mut cursor = Len::rel_min();
|
let mut cursor = Len::rel_min();
|
||||||
let mut lens = Vec::with_capacity(self.children.len());
|
let mut sizes = Vec::with_capacity(self.children.len());
|
||||||
for child in &self.children {
|
for child in &self.children {
|
||||||
let room = Place::Within(Part::From(along(cursor, far)));
|
let room = Place::Within(Part::From(along(cursor, far)));
|
||||||
let len = painter
|
let size = painter
|
||||||
.widget_at(child, UiRegion::FULL, axis.pair(room, across))
|
.widget_at(child, [None; 2], axis.pair(room, across))
|
||||||
.len(axis);
|
.size();
|
||||||
|
let len = size.axis(axis);
|
||||||
cursor.px += len.px + self.gap;
|
cursor.px += len.px + self.gap;
|
||||||
cursor.rel += len.rel;
|
cursor.rel += len.rel;
|
||||||
lens.push(len);
|
sizes.push(size);
|
||||||
}
|
}
|
||||||
|
let lens: Vec<LayoutLen> = sizes.iter().map(|size| size.axis(axis)).collect();
|
||||||
|
|
||||||
let gaps = self
|
let gaps = self
|
||||||
.gap
|
.gap
|
||||||
@@ -64,12 +68,12 @@ impl Widget for Span {
|
|||||||
// exist at all turns on this.
|
// exist at all turns on this.
|
||||||
let mut shares = false;
|
let mut shares = false;
|
||||||
if total.leftover > Weight::ZERO {
|
if total.leftover > Weight::ZERO {
|
||||||
shares = room.to_px(painter.frame_px_len(axis)) > Px::ZERO;
|
shares = painter.to_px(room, axis) > Px::ZERO;
|
||||||
let holds = match shares {
|
let holds = match shares {
|
||||||
true => Holds::from(Px::STEP..=Px::MAX),
|
true => Holds::from(Px::STEP..=Px::MAX),
|
||||||
false => Holds::from(Px::MIN..=Px::ZERO),
|
false => Holds::from(Px::MIN..=Px::ZERO),
|
||||||
};
|
};
|
||||||
painter.frame_holds(axis, holds.through(room));
|
painter.window_holds(axis, holds.through(room));
|
||||||
}
|
}
|
||||||
|
|
||||||
// Across itself a span is as long as its longest child -- unless a
|
// Across itself a span is as long as its longest child -- unless a
|
||||||
@@ -88,7 +92,8 @@ impl Widget for Span {
|
|||||||
let mut taken = Weight::ZERO;
|
let mut taken = Weight::ZERO;
|
||||||
let mut start = Len::rel_min();
|
let mut start = Len::rel_min();
|
||||||
let mut ortho = LayoutLen::ZERO;
|
let mut ortho = LayoutLen::ZERO;
|
||||||
for (child, len) in self.children.iter().zip(&lens) {
|
for (child, size) in self.children.iter().zip(&sizes) {
|
||||||
|
let len = size.axis(axis);
|
||||||
// A child asking for nothing but a part of what is left over,
|
// A child asking for nothing but a part of what is left over,
|
||||||
// when nothing is, is not drawn at all. One that also asked for
|
// when nothing is, is not drawn at all. One that also asked for
|
||||||
// pixels or a fraction keeps those and overflows.
|
// pixels or a fraction keeps those and overflows.
|
||||||
@@ -106,12 +111,26 @@ impl Widget for Span {
|
|||||||
fixed.rel += len.rel;
|
fixed.rel += len.rel;
|
||||||
start = shared(fixed, taken, total.leftover, room);
|
start = shared(fixed, taken, total.leftover, room);
|
||||||
// Along the row the span says where the child goes, and that slot
|
// Along the row the span says where the child goes, and that slot
|
||||||
// is the drawing's box outright rather than something to place an
|
// is the child's box outright rather than something to place an
|
||||||
// answer inside again.
|
// answer inside again. A share is decided here and nowhere
|
||||||
let slot = Place::Fill(Part::From(along(from, start)));
|
// else: its slot narrows its frame, and the child is asked in
|
||||||
let placed = painter.widget_at(child, UiRegion::FULL, axis.pair(slot, across));
|
// it, since a text wraps at the width it is actually given. A
|
||||||
|
// fixed child's slot is its own answer, so its drawing is put
|
||||||
|
// there as it is.
|
||||||
|
let slot = along(from, start);
|
||||||
|
let place = axis.pair(Place::Fill(Part::From(slot)), across);
|
||||||
|
let used = match len.leftover > Weight::ZERO && shares {
|
||||||
|
true => {
|
||||||
|
let mut narrow = [None; 2];
|
||||||
|
narrow[axis as usize] = Some(slot.len());
|
||||||
|
painter.widget_at(child, narrow, place).len(!axis)
|
||||||
|
}
|
||||||
|
false => {
|
||||||
|
painter.place_at(child, place);
|
||||||
|
size.axis(!axis)
|
||||||
|
}
|
||||||
|
};
|
||||||
if shrinks {
|
if shrinks {
|
||||||
let used = placed.len(!axis);
|
|
||||||
// Choosing between a fixed and a relative length from the
|
// Choosing between a fixed and a relative length from the
|
||||||
// span's own eventual width admits multiple fixed points.
|
// span's own eventual width admits multiple fixed points.
|
||||||
// A scalable child therefore makes Children scalable too;
|
// A scalable child therefore makes Children scalable too;
|
||||||
|
|||||||
@@ -23,19 +23,29 @@ impl Widget for Stack {
|
|||||||
Some((i, child)) => {
|
Some((i, child)) => {
|
||||||
painter.child_layer_at(i);
|
painter.child_layer_at(i);
|
||||||
painter
|
painter
|
||||||
.widget_at(child, UiRegion::FULL, [Place::Fill(Part::All); 2])
|
.widget_at(child, [None; 2], [Place::Fill(Part::All); 2])
|
||||||
.size()
|
.size()
|
||||||
}
|
}
|
||||||
None => Size::LEFTOVER,
|
None => Size::LEFTOVER,
|
||||||
};
|
};
|
||||||
|
// Every other child gets the box the sizing child decided: the
|
||||||
|
// stack is that length, so that is the box they are asked in, and a
|
||||||
|
// fraction under them is a fraction of it. A share leaves the axis
|
||||||
|
// to whoever gave the stack its box. Where a child sits in a box
|
||||||
|
// bigger than itself is its own business.
|
||||||
|
let place = [Axis::X, Axis::Y].map(|axis| {
|
||||||
|
let len = size.axis(axis);
|
||||||
|
match len.leftover == Weight::ZERO {
|
||||||
|
true => Place::Fill(Part::Sized(Len::from_parts(len.rel, len.px))),
|
||||||
|
false => Place::Within(Part::All),
|
||||||
|
}
|
||||||
|
});
|
||||||
for (i, child) in self.children.iter().enumerate() {
|
for (i, child) in self.children.iter().enumerate() {
|
||||||
if sizing == Some(i) {
|
if sizing == Some(i) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
painter.child_layer_at(i);
|
painter.child_layer_at(i);
|
||||||
// Every other child is drawn in the stack's own box, and where it
|
painter.widget_at(child, [None; 2], place);
|
||||||
// sits in one bigger than itself is its own business.
|
|
||||||
painter.widget(child);
|
|
||||||
}
|
}
|
||||||
size
|
size
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -24,15 +24,15 @@ impl Widget for BranchesOnMeasurement {
|
|||||||
let cut = Len::from_parts(Rel::ZERO, Px::from_int(40));
|
let cut = Len::from_parts(Rel::ZERO, Px::from_int(40));
|
||||||
let top = Place::Within(Part::From(UiSpan::new(Len::ZERO, cut)));
|
let top = Place::Within(Part::From(UiSpan::new(Len::ZERO, cut)));
|
||||||
let measured = painter
|
let measured = painter
|
||||||
.widget_at(&self.probe, UiRegion::FULL, [Place::Within(Part::All), top])
|
.widget_at(&self.probe, [None; 2], [Place::Within(Part::All), top])
|
||||||
.len(Axis::X);
|
.len(Axis::X);
|
||||||
let px = measured.apply_leftover().to_px(painter.px_len(Axis::X));
|
let px = painter.to_px(measured.apply_leftover(), Axis::X);
|
||||||
|
|
||||||
let below = Place::Within(Part::From(UiSpan::new(cut, painter.extent_len(Axis::Y))));
|
let below = Place::Within(Part::From(UiSpan::new(cut, painter.extent_len(Axis::Y))));
|
||||||
let place = [Place::Within(Part::All), below];
|
let place = [Place::Within(Part::All), below];
|
||||||
match px > Px::from_f32(self.threshold) {
|
match px > Px::from_f32(self.threshold) {
|
||||||
true => painter.widget_at(&self.wide, UiRegion::FULL, place),
|
true => painter.widget_at(&self.wide, [None; 2], place),
|
||||||
false => painter.widget_at(&self.narrow, UiRegion::FULL, place),
|
false => painter.widget_at(&self.narrow, [None; 2], place),
|
||||||
};
|
};
|
||||||
Size::LEFTOVER
|
Size::LEFTOVER
|
||||||
}
|
}
|
||||||
|
|||||||
+90
-9
@@ -83,10 +83,8 @@ fn a_text_in_a_span_wraps_at_the_room_left_rather_than_the_whole_row() {
|
|||||||
assert!(crowded > whole_row, "{crowded} against {whole_row}");
|
assert!(crowded > whole_row, "{crowded} against {whole_row}");
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The same reading through a pad: padding goes around what it pads and
|
/// Padding is an inset: it narrows the frame a fraction resolves against and
|
||||||
/// does not narrow what a fraction under it is a fraction of, so half of the
|
/// adds itself back to the padded widget's reported length.
|
||||||
/// window plus the padding is what the pad takes and where the next child
|
|
||||||
/// starts.
|
|
||||||
#[test]
|
#[test]
|
||||||
fn a_pad_puts_its_padding_around_a_fraction_of_the_whole_box() {
|
fn a_pad_puts_its_padding_around_a_fraction_of_the_whole_box() {
|
||||||
let mut h = Harness::new((400, 100));
|
let mut h = Harness::new((400, 100));
|
||||||
@@ -97,9 +95,83 @@ fn a_pad_puts_its_padding_around_a_fraction_of_the_whole_box() {
|
|||||||
// placed inside it by its own alignment, which is not what is under test.
|
// placed inside it by its own alignment, which is not what is under test.
|
||||||
h.set_root((padded, tail).span(Dir::RIGHT).width(rel(1.0)));
|
h.set_root((padded, tail).span(Dir::RIGHT).width(rel(1.0)));
|
||||||
|
|
||||||
assert_corners!(h, inner, (10, 10), (210, 90));
|
assert_corners!(h, inner, (10, 10), (200, 90));
|
||||||
assert_corners!(h, padded, (0, 0), (220, 100));
|
assert_corners!(h, padded, (0, 0), (210, 100));
|
||||||
assert_corners!(h, tail, (220, 0), (320, 100));
|
assert_corners!(h, tail, (210, 0), (310, 100));
|
||||||
|
}
|
||||||
|
|
||||||
|
const PARAGRAPH: &str = "Wrapping shapes one source into as many lines as the box \
|
||||||
|
leaves room for, so a paragraph's height is an answer and not a setting.";
|
||||||
|
|
||||||
|
/// The worked example of what padding insets: in a 900 px row after a 24 px
|
||||||
|
/// icon, a `rel(1.0)` inside `pad(16)` is 900 - 32 and overflows the row by
|
||||||
|
/// the icon's width, while a wrapping text beside it is asked in the room
|
||||||
|
/// left, 900 - 24 - 32, and wraps there.
|
||||||
|
#[test]
|
||||||
|
fn padding_keeps_the_frame_distinct_from_the_room_left_in_a_row() {
|
||||||
|
let mut h = Harness::new((900, 200));
|
||||||
|
let icon = rect(Color::RED).width(24).add(&mut h.rsc);
|
||||||
|
let fill = rect(Color::GREEN).width(rel(1.0)).add(&mut h.rsc);
|
||||||
|
let padded = fill.pad(16).add(&mut h.rsc);
|
||||||
|
h.set_root((icon, padded).span(Dir::RIGHT).width(rel(1.0)));
|
||||||
|
let fill_width = h.region(&fill).unwrap().size().x;
|
||||||
|
assert_eq!(fill_width, Px::from_int(868));
|
||||||
|
|
||||||
|
let mut h = Harness::new((900, 200));
|
||||||
|
let icon = rect(Color::RED).width(24).add(&mut h.rsc);
|
||||||
|
let text = wtext(PARAGRAPH).size(16).wrap(true).add(&mut h.rsc);
|
||||||
|
let padded = text.pad(16).add(&mut h.rsc);
|
||||||
|
h.set_root((icon, padded).span(Dir::RIGHT).width(rel(1.0)));
|
||||||
|
let active = &h.render.active[&text.id()];
|
||||||
|
let window = h.render.output_size().x;
|
||||||
|
let asked = active.offer_part.x.len().to_px(window);
|
||||||
|
assert_eq!(active.frame.x.to_px(window), Px::from_int(868));
|
||||||
|
assert_eq!(asked, Px::from_int(844));
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The other way round: a share inside padding. A slot is a length of the
|
||||||
|
/// row, which is already the padded width, so what the span decided reaches
|
||||||
|
/// the child as it stands -- taking the padding off a second time would make
|
||||||
|
/// `rel(1.0)` in the slot shorter than the slot.
|
||||||
|
#[test]
|
||||||
|
fn a_share_inside_padding_fills_the_slot_it_was_given() {
|
||||||
|
let mut h = Harness::new((900, 200));
|
||||||
|
let fill = rect(Color::GREEN).width(rel(1.0)).add(&mut h.rsc);
|
||||||
|
let first = Span {
|
||||||
|
children: vec![fill.add_strong(&mut h.rsc)],
|
||||||
|
dir: Dir::RIGHT,
|
||||||
|
gap: Px::ZERO,
|
||||||
|
}
|
||||||
|
.width(leftover(1))
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let second = rect(Color::BLUE).width(leftover(1)).add(&mut h.rsc);
|
||||||
|
let row = (first, second).span(Dir::RIGHT).add(&mut h.rsc);
|
||||||
|
h.set_root(row.pad(16));
|
||||||
|
|
||||||
|
assert_eq!(h.region(&first).unwrap().size().x, Px::from_int(434));
|
||||||
|
assert_eq!(h.region(&fill).unwrap().size().x, Px::from_int(434));
|
||||||
|
}
|
||||||
|
|
||||||
|
/// The same padding in a share instead: the slot is 450, so both the
|
||||||
|
/// fraction and the wrap are the slot less the padding, and the two agree.
|
||||||
|
#[test]
|
||||||
|
fn padding_narrows_both_frame_and_box_inside_a_share() {
|
||||||
|
let mut h = Harness::new((900, 200));
|
||||||
|
let fill = rect(Color::GREEN).width(rel(1.0)).add(&mut h.rsc);
|
||||||
|
let padded = fill.pad(16).width(leftover(1)).add(&mut h.rsc);
|
||||||
|
let other = rect(Color::BLUE).width(leftover(1)).add(&mut h.rsc);
|
||||||
|
h.set_root((padded, other).span(Dir::RIGHT).width(rel(1.0)));
|
||||||
|
assert_eq!(h.region(&fill).unwrap().size().x, Px::from_int(418));
|
||||||
|
|
||||||
|
let mut h = Harness::new((900, 200));
|
||||||
|
let text = wtext(PARAGRAPH).size(16).wrap(true).add(&mut h.rsc);
|
||||||
|
let padded = text.pad(16).width(leftover(1)).add(&mut h.rsc);
|
||||||
|
let other = rect(Color::BLUE).width(leftover(1)).add(&mut h.rsc);
|
||||||
|
h.set_root((padded, other).span(Dir::RIGHT).width(rel(1.0)));
|
||||||
|
let active = &h.render.active[&text.id()];
|
||||||
|
let window = h.render.output_size().x;
|
||||||
|
assert_eq!(active.frame.x.to_px(window), Px::from_int(418));
|
||||||
|
assert_eq!(active.offer_part.x.len().to_px(window), Px::from_int(418));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -428,8 +500,7 @@ fn a_row_of_equal_shares_fills_it_exactly() {
|
|||||||
/// a step of. Kept in step with `snap_floor` in `prelude.wgsl`.
|
/// a step of. Kept in step with `snap_floor` in `prelude.wgsl`.
|
||||||
fn drawn_edges(h: &Harness, id: WidgetId, axis: Axis) -> (f32, f32) {
|
fn drawn_edges(h: &Harness, id: WidgetId, axis: Axis) -> (f32, f32) {
|
||||||
let active = &h.render.active[&id];
|
let active = &h.render.active[&id];
|
||||||
let drawn = active.extent.within(&active.frame_abs);
|
let region = h.render.moves.resolve(active.move_idx, active.extent);
|
||||||
let region = h.render.moves.resolve(active.parent_move, drawn);
|
|
||||||
let dim = h.size().axis(axis);
|
let dim = h.size().axis(axis);
|
||||||
let snap = |v: f32| (v + Px::STEP.to_f32() * 0.5).floor();
|
let snap = |v: f32| (v + Px::STEP.to_f32() * 0.5).floor();
|
||||||
let edge = |s: Len| snap(s.rel.to_f32() * dim + s.px.to_f32());
|
let edge = |s: Len| snap(s.rel.to_f32() * dim + s.px.to_f32());
|
||||||
@@ -740,3 +811,13 @@ fn a_fixed_child_is_centered_in_its_wrappers_share() {
|
|||||||
assert_corners!(h, wrapper, (200, 0), (900, 400));
|
assert_corners!(h, wrapper, (200, 0), (900, 400));
|
||||||
assert_corners!(h, leaf, (500, 150), (600, 250));
|
assert_corners!(h, leaf, (500, 150), (600, 250));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The root's frame is the window and its rule is a fraction of that, which
|
||||||
|
/// is one resolution and not two: nothing above it narrowed anything.
|
||||||
|
#[test]
|
||||||
|
fn a_root_with_a_fraction_rule_is_that_fraction_of_the_window() {
|
||||||
|
let mut h = Harness::new((900, 200));
|
||||||
|
let root = rect(Color::RED).width(rel(0.5)).add(&mut h.rsc);
|
||||||
|
h.set_root(root);
|
||||||
|
assert_eq!(h.region(&root).unwrap().size().x, Px::from_int(450));
|
||||||
|
}
|
||||||
+16
-17
@@ -156,9 +156,9 @@ fn a_span_child_that_declares_its_length_is_drawn_once() {
|
|||||||
h.set_root((hinted, asked).span(Dir::RIGHT));
|
h.set_root((hinted, asked).span(Dir::RIGHT));
|
||||||
|
|
||||||
assert_eq!(told_draws.get(), 1);
|
assert_eq!(told_draws.get(), 1);
|
||||||
// Only the available length changes: positioning the final slot does
|
// Asked once, from the cursor; its slot is its answer and the drawing is
|
||||||
// not invalidate a numeric size read.
|
// moved there.
|
||||||
assert_eq!(asked_draws.get(), 2);
|
assert_eq!(asked_draws.get(), 1);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -216,7 +216,7 @@ impl Widget for FromHint {
|
|||||||
let top = UiSpan::new(Len::ZERO, Len::from_parts(Rel::ZERO, len.px));
|
let top = UiSpan::new(Len::ZERO, Len::from_parts(Rel::ZERO, len.px));
|
||||||
painter.widget_at(
|
painter.widget_at(
|
||||||
&self.inner,
|
&self.inner,
|
||||||
UiRegion::FULL,
|
[None; 2],
|
||||||
[Place::Within(Part::All), Place::Within(Part::From(top))],
|
[Place::Within(Part::All), Place::Within(Part::From(top))],
|
||||||
);
|
);
|
||||||
Size::LEFTOVER
|
Size::LEFTOVER
|
||||||
@@ -255,10 +255,9 @@ impl Widget for ReadsBox {
|
|||||||
/// Reads its box across one axis only, so its drawing holds for a taller
|
/// Reads its box across one axis only, so its drawing holds for a taller
|
||||||
/// box on its own and only a wider one is worth a draw.
|
/// box on its own and only a wider one is worth a draw.
|
||||||
///
|
///
|
||||||
/// Both of these report a quarter of what they read, without saying that the
|
/// Both of these report a quarter of what they read. The quarter-sized box
|
||||||
/// drawing holds there too, so each length they are asked at costs two draws:
|
/// the answer places them in is not a question: the drawing is moved there,
|
||||||
/// one to answer, and one in the quarter-sized box that answer places them
|
/// so each length they are asked at costs one draw.
|
||||||
/// in. The counts below are in those pairs.
|
|
||||||
struct ReadsWidth {
|
struct ReadsWidth {
|
||||||
draws: Rc<Cell<usize>>,
|
draws: Rc<Cell<usize>>,
|
||||||
}
|
}
|
||||||
@@ -384,7 +383,7 @@ fn a_resize_redraws_what_read_its_box() {
|
|||||||
h.resize((800, 100));
|
h.resize((800, 100));
|
||||||
h.frame();
|
h.frame();
|
||||||
|
|
||||||
assert_eq!(draws.get(), settled + 2);
|
assert_eq!(draws.get(), settled + 1);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -404,7 +403,7 @@ fn a_resize_only_redraws_read_axes() {
|
|||||||
|
|
||||||
h.resize((800, 300));
|
h.resize((800, 300));
|
||||||
h.frame();
|
h.frame();
|
||||||
assert_eq!(draws.get(), settled + 2, "width changes its answer");
|
assert_eq!(draws.get(), settled + 1, "width changes its answer");
|
||||||
}
|
}
|
||||||
|
|
||||||
/// A window is measured onto the grid like everything else, so a resize too
|
/// A window is measured onto the grid like everything else, so a resize too
|
||||||
@@ -431,7 +430,7 @@ fn a_resize_within_one_step_is_not_a_resize() {
|
|||||||
|
|
||||||
h.resize((400.0 + step, 200.0));
|
h.resize((400.0 + step, 200.0));
|
||||||
h.frame();
|
h.frame();
|
||||||
assert_eq!(draws.get(), settled + 2);
|
assert_eq!(draws.get(), settled + 1);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// The same for a box that changes because a sibling did: what is compared
|
/// The same for a box that changes because a sibling did: what is compared
|
||||||
@@ -878,7 +877,7 @@ fn resizing_a_fixed_frame_recomposes_its_contents_without_drawing_them() {
|
|||||||
fn draw(&mut self, painter: &mut Painter) -> Size {
|
fn draw(&mut self, painter: &mut Painter) -> Size {
|
||||||
painter.widget_at(
|
painter.widget_at(
|
||||||
&self.child,
|
&self.child,
|
||||||
UiRegion::FULL,
|
[None; 2],
|
||||||
[
|
[
|
||||||
Place::Within(Part::From(self.region.x)),
|
Place::Within(Part::From(self.region.x)),
|
||||||
Place::Within(Part::From(self.region.y)),
|
Place::Within(Part::From(self.region.y)),
|
||||||
@@ -967,7 +966,7 @@ fn glyph_origins_compose_identically_when_drawn_and_when_retained() {
|
|||||||
fn draw(&mut self, painter: &mut Painter) -> Size {
|
fn draw(&mut self, painter: &mut Painter) -> Size {
|
||||||
painter.widget_at(
|
painter.widget_at(
|
||||||
&self.child,
|
&self.child,
|
||||||
self.region,
|
[Some(self.region.x.len()), None],
|
||||||
[
|
[
|
||||||
Place::Fill(Part::From(self.extent.x)),
|
Place::Fill(Part::From(self.extent.x)),
|
||||||
Place::Fill(Part::From(self.extent.y)),
|
Place::Fill(Part::From(self.extent.y)),
|
||||||
@@ -1137,7 +1136,7 @@ fn padding_and_stack_boxes_follow_the_extent_without_drawing_again() {
|
|||||||
fn draw(&mut self, painter: &mut Painter) -> Size {
|
fn draw(&mut self, painter: &mut Painter) -> Size {
|
||||||
painter.widget_at(
|
painter.widget_at(
|
||||||
&self.child,
|
&self.child,
|
||||||
UiRegion::FULL,
|
[None; 2],
|
||||||
[
|
[
|
||||||
Place::Fill(Part::From(self.extent.x)),
|
Place::Fill(Part::From(self.extent.x)),
|
||||||
Place::Fill(Part::From(self.extent.y)),
|
Place::Fill(Part::From(self.extent.y)),
|
||||||
@@ -1225,7 +1224,7 @@ fn moving_an_extent_child_preserves_the_slot_chosen_from_its_measurement() {
|
|||||||
fn draw(&mut self, painter: &mut Painter) -> Size {
|
fn draw(&mut self, painter: &mut Painter) -> Size {
|
||||||
painter.widget_at(
|
painter.widget_at(
|
||||||
&self.child,
|
&self.child,
|
||||||
UiRegion::FULL,
|
[None; 2],
|
||||||
[
|
[
|
||||||
Place::Fill(Part::From(UiSpan::new(
|
Place::Fill(Part::From(UiSpan::new(
|
||||||
Len::px(self.start),
|
Len::px(self.start),
|
||||||
@@ -1267,7 +1266,7 @@ fn extent_frames_keep_fractional_reports_and_numeric_dependencies_valid() {
|
|||||||
painter
|
painter
|
||||||
.widget_at(
|
.widget_at(
|
||||||
&self.child,
|
&self.child,
|
||||||
UiRegion::FULL,
|
[None; 2],
|
||||||
[
|
[
|
||||||
Place::Within(Part::From(self.region.x)),
|
Place::Within(Part::From(self.region.x)),
|
||||||
Place::Within(Part::From(self.region.y)),
|
Place::Within(Part::From(self.region.y)),
|
||||||
@@ -1287,7 +1286,7 @@ fn extent_frames_keep_fractional_reports_and_numeric_dependencies_valid() {
|
|||||||
painter
|
painter
|
||||||
.widget_at(
|
.widget_at(
|
||||||
&self.child,
|
&self.child,
|
||||||
UiRegion::FULL,
|
[None; 2],
|
||||||
[
|
[
|
||||||
Place::Fill(Part::From(self.extent.x)),
|
Place::Fill(Part::From(self.extent.x)),
|
||||||
Place::Fill(Part::From(self.extent.y)),
|
Place::Fill(Part::From(self.extent.y)),
|
||||||
|
|||||||
@@ -733,6 +733,51 @@ fn a_widget_under_a_region_node_is_asked_in_the_box_that_node_was_offered() {
|
|||||||
const PARAGRAPH: &str = "Wrapping shapes one source into as many lines as the \
|
const PARAGRAPH: &str = "Wrapping shapes one source into as many lines as the \
|
||||||
box leaves room for, so a paragraph's height is an answer and not a setting.";
|
box leaves room for, so a paragraph's height is an answer and not a setting.";
|
||||||
|
|
||||||
|
fn plant_stack_resized_from_free(h: &mut Harness, fixed: bool) -> (Vec<WidgetId>, WidgetId) {
|
||||||
|
let sizing = rect(Color::CYAN.alpha(126)).add(&mut h.rsc);
|
||||||
|
h.rsc.widgets_mut().set_size_rules(sizing.id(), None, None);
|
||||||
|
if fixed {
|
||||||
|
h.rsc.widgets_mut().set_size_rules(
|
||||||
|
sizing.id(),
|
||||||
|
Some(LayoutLen::px(112)),
|
||||||
|
Some(LayoutLen::px(101)),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
let text = wtext(PARAGRAPH).size(16).wrap(true).add(&mut h.rsc);
|
||||||
|
let pad = Pad {
|
||||||
|
padding: Padding::ZERO,
|
||||||
|
inner: text.add_strong(&mut h.rsc),
|
||||||
|
}
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let stack = Stack {
|
||||||
|
children: vec![sizing.add_strong(&mut h.rsc), pad.add_strong(&mut h.rsc)],
|
||||||
|
size: StackSize::Child(0),
|
||||||
|
}
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
h.set_root(stack);
|
||||||
|
(
|
||||||
|
vec![sizing.id(), text.id(), pad.id(), stack.id()],
|
||||||
|
sizing.id(),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn fixing_a_stacks_sizing_child_repositions_its_overlay() {
|
||||||
|
let mut warm = Harness::new((900, 1200));
|
||||||
|
let (ids, sizing) = plant_stack_resized_from_free(&mut warm, false);
|
||||||
|
warm.frame();
|
||||||
|
warm.rsc.widgets_mut().set_size_rules(
|
||||||
|
sizing,
|
||||||
|
Some(LayoutLen::px(112)),
|
||||||
|
Some(LayoutLen::px(101)),
|
||||||
|
);
|
||||||
|
warm.frame();
|
||||||
|
|
||||||
|
let mut cold = Harness::new((900, 1200));
|
||||||
|
let (cold_ids, _) = plant_stack_resized_from_free(&mut cold, true);
|
||||||
|
assert_same_regions(&warm, &ids, &cold, &cold_ids);
|
||||||
|
}
|
||||||
|
|
||||||
/// Eight widgets, shrunk from a 118-widget tree (seed 1121, depth 4,
|
/// Eight widgets, shrunk from a 118-widget tree (seed 1121, depth 4,
|
||||||
/// `shuffle-swap-for-three`). The stack takes its size from the span above,
|
/// `shuffle-swap-for-three`). The stack takes its size from the span above,
|
||||||
/// the span takes its width from the longest line of the texts in it, and
|
/// the span takes its width from the longest line of the texts in it, and
|
||||||
@@ -846,3 +891,179 @@ fn adding_text_to_a_reverse_row_keeps_its_shared_height() {
|
|||||||
let (_, other, _) = build(&mut cold, true);
|
let (_, other, _) = build(&mut cold, true);
|
||||||
assert_eq!(warm.region(&shared), cold.region(&other));
|
assert_eq!(warm.region(&shared), cold.region(&other));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Nine widgets, shrunk from seed 946 at depth 6. The column is a share of
|
||||||
|
/// the row while its rect has room to draw and a fixed width once it has
|
||||||
|
/// not, so the row asks it twice: in the room, where it answers a share,
|
||||||
|
/// and in its slot, where it answers its text's width. Emptying the column
|
||||||
|
/// changes only the first answer. A local redraw that asked only the second
|
||||||
|
/// question kept the row as it was; the column has to defer to the row.
|
||||||
|
fn plant_column_that_is_a_share_only_while_its_rect_fits(
|
||||||
|
h: &mut Harness,
|
||||||
|
emptied: bool,
|
||||||
|
) -> (Vec<WidgetId>, WeakWidget<Span>, Vec<StrongWidget>) {
|
||||||
|
let first = wtext(PARAGRAPH).size(16).wrap(true).add(&mut h.rsc);
|
||||||
|
let filler = rect(Color::CYAN.alpha(126)).add(&mut h.rsc);
|
||||||
|
let second = wtext(PARAGRAPH).size(16).wrap(true).add(&mut h.rsc);
|
||||||
|
let mut spare: Vec<StrongWidget> =
|
||||||
|
vec![filler.add_strong(&mut h.rsc), second.add_strong(&mut h.rsc)];
|
||||||
|
let mut children: Vec<StrongWidget> = vec![first.add_strong(&mut h.rsc)];
|
||||||
|
if !emptied {
|
||||||
|
children.append(&mut spare);
|
||||||
|
}
|
||||||
|
let column = Span {
|
||||||
|
children,
|
||||||
|
dir: Dir::DOWN,
|
||||||
|
gap: Px::ZERO,
|
||||||
|
}
|
||||||
|
.height(159)
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let left = rect(Color::MAGENTA.alpha(189)).add(&mut h.rsc);
|
||||||
|
let right = rect(Color::BLUE.alpha(0)).add(&mut h.rsc);
|
||||||
|
let row = Span {
|
||||||
|
children: vec![
|
||||||
|
left.add_strong(&mut h.rsc),
|
||||||
|
column.add_strong(&mut h.rsc),
|
||||||
|
right.add_strong(&mut h.rsc),
|
||||||
|
],
|
||||||
|
dir: Dir::RIGHT,
|
||||||
|
gap: Px::ZERO,
|
||||||
|
}
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let end = rect(Color::MAGENTA.alpha(189)).add(&mut h.rsc);
|
||||||
|
let root = Span {
|
||||||
|
children: vec![end.add_strong(&mut h.rsc), row.add_strong(&mut h.rsc)],
|
||||||
|
dir: Dir::LEFT,
|
||||||
|
gap: Px::ZERO,
|
||||||
|
}
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
h.set_root(root);
|
||||||
|
(
|
||||||
|
vec![
|
||||||
|
first.id(),
|
||||||
|
filler.id(),
|
||||||
|
second.id(),
|
||||||
|
column.id(),
|
||||||
|
left.id(),
|
||||||
|
right.id(),
|
||||||
|
row.id(),
|
||||||
|
end.id(),
|
||||||
|
root.id(),
|
||||||
|
],
|
||||||
|
column,
|
||||||
|
spare,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn emptying_a_column_the_row_asked_twice_asks_the_row_again() {
|
||||||
|
let mut warm = Harness::new((900, 1200));
|
||||||
|
let (ids, column, _spare) =
|
||||||
|
plant_column_that_is_a_share_only_while_its_rect_fits(&mut warm, false);
|
||||||
|
warm.frame();
|
||||||
|
// Kept alive: dropping the last share of a widget frees its id.
|
||||||
|
let _removed: Vec<StrongWidget> = warm.rsc[column].children.drain(1..).collect();
|
||||||
|
warm.frame();
|
||||||
|
|
||||||
|
let mut cold = Harness::new((900, 1200));
|
||||||
|
let (cold_ids, _, _spare) =
|
||||||
|
plant_column_that_is_a_share_only_while_its_rect_fits(&mut cold, true);
|
||||||
|
cold.frame();
|
||||||
|
|
||||||
|
assert_same_regions(&warm, &ids, &cold, &cold_ids);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Six widgets, shrunk from seed 59 at depth 5 (`resize-size`). The column
|
||||||
|
/// divides the box it is given between two shares, so its drawing holds for
|
||||||
|
/// that box's length alone, and the pads above it pass that dependency up:
|
||||||
|
/// each one's box is a part of the box it was asked in. Padding narrowing
|
||||||
|
/// the frame it hands down does not change that, and while it was taken to,
|
||||||
|
/// changing the rule over the pads relocated the column's drawing into the
|
||||||
|
/// new box instead of dividing it again.
|
||||||
|
fn plant_two_shares_under_two_pads(h: &mut Harness, height: f32) -> Vec<WidgetId> {
|
||||||
|
let top = rect(Color::CYAN.alpha(126)).add(&mut h.rsc);
|
||||||
|
let bottom = rect(Color::RED).add(&mut h.rsc);
|
||||||
|
let column = (top, bottom).span(Dir::DOWN).add(&mut h.rsc);
|
||||||
|
let inner = Pad {
|
||||||
|
padding: Padding::ZERO,
|
||||||
|
inner: column.add_strong(&mut h.rsc),
|
||||||
|
}
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let outer = Pad {
|
||||||
|
padding: Padding::ZERO,
|
||||||
|
inner: inner.add_strong(&mut h.rsc),
|
||||||
|
}
|
||||||
|
.height(height)
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let beside = rect(Color::BLUE).add(&mut h.rsc);
|
||||||
|
h.set_root((outer, beside).span(Dir::RIGHT));
|
||||||
|
vec![
|
||||||
|
top.id(),
|
||||||
|
bottom.id(),
|
||||||
|
column.id(),
|
||||||
|
inner.id(),
|
||||||
|
outer.id(),
|
||||||
|
beside.id(),
|
||||||
|
]
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn changing_a_rule_over_two_pads_divides_the_column_again() {
|
||||||
|
let mut warm = Harness::new((900, 1200));
|
||||||
|
let ids = plant_two_shares_under_two_pads(&mut warm, 88.0);
|
||||||
|
warm.frame();
|
||||||
|
warm.rsc
|
||||||
|
.widgets_mut()
|
||||||
|
.set_size_rules(ids[4], None, Some(LayoutLen::px(105)));
|
||||||
|
warm.frame();
|
||||||
|
|
||||||
|
let mut cold = Harness::new((900, 1200));
|
||||||
|
let cold_ids = plant_two_shares_under_two_pads(&mut cold, 105.0);
|
||||||
|
cold.frame();
|
||||||
|
|
||||||
|
assert_same_regions(&warm, &ids, &cold, &cold_ids);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Six widgets, shrunk from seed 942 at depth 6 (`resize`). A `Branch` asks
|
||||||
|
/// its probe in the top 40 px of its box and forwards the frame, so the
|
||||||
|
/// scroll's own box is 40 px tall whatever the window is -- but its content
|
||||||
|
/// is as tall as the frame, which is the window, and a scroll kept to its
|
||||||
|
/// end has to be told when that changes. Resolving a length against the
|
||||||
|
/// window is what reads it, so that is where the dependency is taken.
|
||||||
|
fn plant_a_window_tall_column_in_a_short_scroll(h: &mut Harness) -> Vec<WidgetId> {
|
||||||
|
let leaf = rect(Color::RED).add(&mut h.rsc);
|
||||||
|
let column = Span {
|
||||||
|
children: vec![leaf.add_strong(&mut h.rsc)],
|
||||||
|
dir: Dir::RIGHT,
|
||||||
|
gap: Px::ZERO,
|
||||||
|
}
|
||||||
|
.height(rel(1.0))
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
let scroll = Scroll::new(column.add_strong(&mut h.rsc), Axis::Y).add(&mut h.rsc);
|
||||||
|
let wide = rect(Color::BLUE).add(&mut h.rsc);
|
||||||
|
let narrow = rect(Color::GREEN).add(&mut h.rsc);
|
||||||
|
let root = Branch {
|
||||||
|
probe: scroll.add_strong(&mut h.rsc),
|
||||||
|
wide: wide.add_strong(&mut h.rsc),
|
||||||
|
narrow: narrow.add_strong(&mut h.rsc),
|
||||||
|
threshold: 55.0,
|
||||||
|
}
|
||||||
|
.add(&mut h.rsc);
|
||||||
|
h.set_root(root);
|
||||||
|
vec![leaf.id(), column.id(), scroll.id(), root.id()]
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn resizing_under_a_short_scroll_snaps_its_window_tall_content_again() {
|
||||||
|
let mut warm = Harness::new((1920, 1200));
|
||||||
|
let ids = plant_a_window_tall_column_in_a_short_scroll(&mut warm);
|
||||||
|
warm.frame();
|
||||||
|
warm.resize((640, 900));
|
||||||
|
warm.frame();
|
||||||
|
|
||||||
|
let mut cold = Harness::new((640, 900));
|
||||||
|
let cold_ids = plant_a_window_tall_column_in_a_short_scroll(&mut cold);
|
||||||
|
cold.frame();
|
||||||
|
|
||||||
|
assert_same_regions(&warm, &ids, &cold, &cold_ids);
|
||||||
|
}
|
||||||
+60
-4
@@ -103,6 +103,11 @@ pub enum Case {
|
|||||||
/// A resize and then a size change, so a retained answer is asked to
|
/// A resize and then a size change, so a retained answer is asked to
|
||||||
/// survive two different kinds of invalidation in a row.
|
/// survive two different kinds of invalidation in a row.
|
||||||
ResizeSize,
|
ResizeSize,
|
||||||
|
/// A size change and then a resize, which is the other order and not the
|
||||||
|
/// same test: a length answered as a fraction of one box and kept as a
|
||||||
|
/// fraction of another agrees at the size it was changed at and parts
|
||||||
|
/// from it at every other one.
|
||||||
|
SizeResize,
|
||||||
/// A few declared sizes.
|
/// A few declared sizes.
|
||||||
Size,
|
Size,
|
||||||
/// Every declared size at once, so every reader of a size has a changed
|
/// Every declared size at once, so every reader of a size has a changed
|
||||||
@@ -119,12 +124,13 @@ pub enum Case {
|
|||||||
Shuffle(Shuffle),
|
Shuffle(Shuffle),
|
||||||
}
|
}
|
||||||
|
|
||||||
pub const ALL: [Case; 15] = [
|
pub const ALL: [Case; 16] = [
|
||||||
Case::Repaint,
|
Case::Repaint,
|
||||||
Case::RepaintSome,
|
Case::RepaintSome,
|
||||||
Case::Resize,
|
Case::Resize,
|
||||||
Case::ResizeRepaint,
|
Case::ResizeRepaint,
|
||||||
Case::ResizeSize,
|
Case::ResizeSize,
|
||||||
|
Case::SizeResize,
|
||||||
Case::Size,
|
Case::Size,
|
||||||
Case::EverySize,
|
Case::EverySize,
|
||||||
Case::Align,
|
Case::Align,
|
||||||
@@ -146,6 +152,7 @@ impl Case {
|
|||||||
Self::Resize => "resize",
|
Self::Resize => "resize",
|
||||||
Self::ResizeRepaint => "resize-repaint",
|
Self::ResizeRepaint => "resize-repaint",
|
||||||
Self::ResizeSize => "resize-size",
|
Self::ResizeSize => "resize-size",
|
||||||
|
Self::SizeResize => "size-resize",
|
||||||
Self::Size => "size",
|
Self::Size => "size",
|
||||||
Self::EverySize => "every-size",
|
Self::EverySize => "every-size",
|
||||||
Self::Align => "align",
|
Self::Align => "align",
|
||||||
@@ -170,6 +177,15 @@ impl Case {
|
|||||||
_ => (STILL, STILL),
|
_ => (STILL, STILL),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// The window the warm tree is taken to after the change, where the case
|
||||||
|
/// is about what the change left behind rather than about the change.
|
||||||
|
fn then_resize(self) -> Option<(f32, f32)> {
|
||||||
|
match self {
|
||||||
|
Self::SizeResize => Some(INNER),
|
||||||
|
_ => None,
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn mark(warm: &mut Harness, tree: &Tree, step: usize) {
|
fn mark(warm: &mut Harness, tree: &Tree, step: usize) {
|
||||||
@@ -284,7 +300,7 @@ fn change(case: Case, warm: &mut Harness, tree: &mut Tree, plan: &Plan, rng: &mu
|
|||||||
warm.frame();
|
warm.frame();
|
||||||
return out;
|
return out;
|
||||||
}
|
}
|
||||||
Case::Size | Case::ResizeSize => Edits {
|
Case::Size | Case::ResizeSize | Case::SizeResize => Edits {
|
||||||
sizes: some_sizes(warm, tree, rng),
|
sizes: some_sizes(warm, tree, rng),
|
||||||
..Default::default()
|
..Default::default()
|
||||||
},
|
},
|
||||||
@@ -384,6 +400,17 @@ fn describe_widget(id: WidgetId, h: &Harness) -> String {
|
|||||||
label
|
label
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// One widget's layout as it stands: the frame its fractions resolved
|
||||||
|
/// against, the box it was asked in, the box its drawing went in, and what
|
||||||
|
/// it reported. In window units, which is what both trees are in.
|
||||||
|
fn record(id: WidgetId, h: &Harness) -> String {
|
||||||
|
let active = &h.render.active[&id];
|
||||||
|
format!(
|
||||||
|
"frame {} ask {} box {} size {}",
|
||||||
|
active.frame, active.offer_part, active.extent, active.size,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
/// Runs `case` on the tree `plan` describes, warm and cold, and says where
|
/// Runs `case` on the tree `plan` describes, warm and cold, and says where
|
||||||
/// the two disagree. `seed` chooses only the values a case picks at random,
|
/// the two disagree. `seed` chooses only the values a case picks at random,
|
||||||
/// so one plan under one case is one comparison however it was reached.
|
/// so one plan under one case is one comparison however it was reached.
|
||||||
@@ -400,12 +427,29 @@ pub fn diverges(plan: &Plan, case: Case, seed: u64) -> Option<String> {
|
|||||||
warm.frame();
|
warm.frame();
|
||||||
}
|
}
|
||||||
let cold_plan = change(case, &mut warm, &mut tree, plan, &mut Rng::new(seed));
|
let cold_plan = change(case, &mut warm, &mut tree, plan, &mut Rng::new(seed));
|
||||||
|
// Whatever the change left, seen at another window: an answer kept as a
|
||||||
|
// fraction of the wrong length is the same number of pixels where it was
|
||||||
|
// made and a different one everywhere else.
|
||||||
|
let end = match case.then_resize() {
|
||||||
|
Some(after) => {
|
||||||
|
warm.resize(after);
|
||||||
|
warm.frame();
|
||||||
|
after
|
||||||
|
}
|
||||||
|
None => end,
|
||||||
|
};
|
||||||
|
|
||||||
let mut cold = Harness::new(end);
|
let mut cold = Harness::new(end);
|
||||||
let (root, cold_tree) = build(&mut cold.rsc, &cold_plan);
|
let (root, cold_tree) = build(&mut cold.rsc, &cold_plan);
|
||||||
cold.state.root = Some(root);
|
cold.state.root = Some(root);
|
||||||
cold.frame();
|
cold.frame();
|
||||||
|
|
||||||
|
let places: HashMap<WidgetId, usize> = tree
|
||||||
|
.ids
|
||||||
|
.iter()
|
||||||
|
.enumerate()
|
||||||
|
.map(|(i, &id)| (id, i))
|
||||||
|
.collect();
|
||||||
let mut drawn = 0;
|
let mut drawn = 0;
|
||||||
for (i, (&w, &c)) in tree.ids.iter().zip(&cold_tree.ids).enumerate() {
|
for (i, (&w, &c)) in tree.ids.iter().zip(&cold_tree.ids).enumerate() {
|
||||||
let (got, want) = (warm.region(&w), cold.region(&c));
|
let (got, want) = (warm.region(&w), cold.region(&c));
|
||||||
@@ -416,6 +460,7 @@ pub fn diverges(plan: &Plan, case: Case, seed: u64) -> Option<String> {
|
|||||||
// Where two trees disagree is rarely where the cause is, so the
|
// Where two trees disagree is rarely where the cause is, so the
|
||||||
// ancestry comes with it, marking the widgets that own a region.
|
// ancestry comes with it, marking the widgets that own a region.
|
||||||
let mut chain = Vec::new();
|
let mut chain = Vec::new();
|
||||||
|
let mut records = Vec::new();
|
||||||
let mut at = Some(w);
|
let mut at = Some(w);
|
||||||
while let Some(id) = at {
|
while let Some(id) = at {
|
||||||
let active = &warm.render.active[&id];
|
let active = &warm.render.active[&id];
|
||||||
@@ -424,11 +469,22 @@ pub fn diverges(plan: &Plan, case: Case, seed: u64) -> Option<String> {
|
|||||||
false => "*",
|
false => "*",
|
||||||
};
|
};
|
||||||
chain.push(format!("{}{node}", describe(id, &warm)));
|
chain.push(format!("{}{node}", describe(id, &warm)));
|
||||||
|
// What each level was asked in on both sides, since the level
|
||||||
|
// where the two stop agreeing is the one to look at rather than
|
||||||
|
// the leaf that reported the difference.
|
||||||
|
let cold_id = places.get(&id).and_then(|&i| cold_tree.ids.get(i));
|
||||||
|
records.push(format!(
|
||||||
|
" {}\n warm {}\n cold {}",
|
||||||
|
describe(id, &warm),
|
||||||
|
record(id, &warm),
|
||||||
|
cold_id.map_or("-".into(), |&id| record(id, &cold)),
|
||||||
|
));
|
||||||
at = active.parent;
|
at = active.parent;
|
||||||
}
|
}
|
||||||
return Some(format!(
|
return Some(format!(
|
||||||
"widget {i}\n warm {got:?}\n cold {want:?}\n {}",
|
"widget {i}\n warm {got:?}\n cold {want:?}\n {}\n{}",
|
||||||
chain.join(" < ")
|
chain.join(" < "),
|
||||||
|
records.join("\n"),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
match drawn {
|
match drawn {
|
||||||
|
|||||||
+6
-2
@@ -70,10 +70,14 @@ fn no_grown_tree_lays_out_differently_warm_than_cold() {
|
|||||||
over_seeds(seeds, |seed| {
|
over_seeds(seeds, |seed| {
|
||||||
let grown = plan(seed, depth, &Edits::default());
|
let grown = plan(seed, depth, &Edits::default());
|
||||||
for &case in &cases {
|
for &case in &cases {
|
||||||
let Some(how) = diverges(&grown, case, seed) else {
|
if diverges(&grown, case, seed).is_none() {
|
||||||
continue;
|
continue;
|
||||||
};
|
}
|
||||||
let small = shrink(grown.clone(), case, seed);
|
let small = shrink(grown.clone(), case, seed);
|
||||||
|
// Described from the shrunk tree: the grown tree's chain names
|
||||||
|
// widgets that are no longer there, and the ancestry of the
|
||||||
|
// failure is what a test is written from.
|
||||||
|
let how = diverges(&small, case, seed).unwrap_or_default();
|
||||||
println!(
|
println!(
|
||||||
"seed {seed} case {}: {how}\ngrown {} widgets, shrank to {}\n{small:#?}",
|
"seed {seed} case {}: {how}\ngrown {} widgets, shrank to {}\n{small:#?}",
|
||||||
case.name(),
|
case.name(),
|
||||||
|
|||||||
Reference in new issue
Block a user