`Image` is the only widget in the repository whose size hint is a length in pixels -- everything else hints a share, or nothing -- so it is the only one that exercises a rule beside a hint, a box a widget knows before it is drawn, and the answer the commit before this one changed. The generated trees had none, which is why nothing there could reach that case. `Kind::Image` is a fifth leaf, drawn one time in five, and it steps to a plain rect when the shrinker reduces it: a picture measures nothing either, but its length is its own, so the leaf that takes whatever it is given is the simpler one. The picture is a 64x64 checkerboard of purple and black in 8 px cells, committed at `src/assets/checkerboard.png` beside the generator that draws it -- the way `examples/tabs` keeps its own -- and included rather than opened, so that growing a tree does not depend on a working directory and one seed is one tree whatever anything else does. One upload per tree, however many images it grows: a `TextureHandle` is a counted reference, so the first image in a tree uploads the checkerboard and every one after it clones the handle. Measured: seed 1 at depth 4 grows 13 images and holds 1 texture, seed 6 grows none and holds none, and `a_tree_of_images_uploads_one_texture` asserts it. `Image::new` is what a caller holding a handle needs, since `image` uploads what it is given. A seed names a tree only while the generator draws the same things in the same order, so every seed now grows a different tree. The seed list in `generated.rs` says so: 20 and 86 no longer grow the trees whose defects they once caught, and both of those live on as shrunk fixtures in `unsettled.rs`, which are trees rather than numbers. The seeds those fixtures name are similarly historical, and their file says that too. Format, clippy with and without layout-diagnostics, and the suite (135 + 19 + 13 + 4) are clean. The cold dump is a new baseline of 34,571 boxes over the 400 depth-5 trees, since the trees themselves changed; all three seed scans pass over the new ones -- 400 at depth 5 in 62.79s, 1,000 at depth 6 in 160.20s, 2,000 at depth 4 in 299.58s -- which is what actually checks that images lay out warm the way they do cold. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
128 lines
4.8 KiB
Rust
128 lines
4.8 KiB
Rust
//! Laying a tree out again has to land where growing it that way would.
|
|
//!
|
|
//! Every case is one of `scenario`'s, over the trees `iris::random` grows
|
|
//! from a seed. The fast test takes a handful of seeds and the ignored one
|
|
//! takes as many as it is asked for; both run the same cases the shrinker
|
|
//! does over the same trees, so a seed that fails here is reduced by
|
|
//!
|
|
//! SHRINK_SEED=<seed> SHRINK_DEPTH=<depth> SHRINK_CASE=<case> \
|
|
//! cargo test --release --test shrink -- --ignored --nocapture
|
|
//!
|
|
//! `IRIS_GENERATED_SEED`, `IRIS_GENERATED_SEEDS` and `IRIS_GENERATED_DEPTH`
|
|
//! select what the long run covers.
|
|
|
|
#[path = "scenario/mod.rs"]
|
|
mod scenario;
|
|
|
|
use iris::random::{Edits, Plan, plan};
|
|
use scenario::{ALL, Case, diverges, env, over_seeds};
|
|
|
|
/// How deep the generator branches. The generator widens two to four ways per
|
|
/// level, so depth is exponential in width and a deep narrow tree is not
|
|
/// reachable by raising this -- it buys more overlap between dependency
|
|
/// paths, not more ancestry.
|
|
fn depth() -> usize {
|
|
env("IRIS_GENERATED_DEPTH", 4)
|
|
}
|
|
|
|
/// The seeds the ordinary tests take: a corpus rather than a set of
|
|
/// regression cases, since a seed names a tree only for as long as the
|
|
/// generator draws the same things in the same order. Adding images to the
|
|
/// leaves moved every one of them, so 20 and 86 -- which once caught a widget
|
|
/// placed twice in a box its parent had already placed it in, and a `Scroll`
|
|
/// fixed point settling differently -- no longer grow those trees. Both
|
|
/// defects are pinned by the shrunk fixtures in `cases/unsettled.rs`, which
|
|
/// are trees rather than numbers.
|
|
const SEEDS: [u64; 10] = [1, 2, 3, 5, 8, 10, 13, 20, 86, 98];
|
|
|
|
fn check(seed: u64, depth: usize, case: Case) {
|
|
check_plan(&plan(seed, depth, &Edits::default()), seed, depth, case);
|
|
}
|
|
|
|
fn check_plan(grown: &Plan, seed: u64, depth: usize, case: Case) {
|
|
if let Some(how) = diverges(grown, case, seed) {
|
|
panic!(
|
|
"seed {seed} at depth {depth} differs after {}: {how}\n\
|
|
reduce it with SHRINK_SEED={seed} SHRINK_DEPTH={depth} \
|
|
SHRINK_CASE={} cargo test --release --test shrink -- --ignored --nocapture",
|
|
case.name(),
|
|
case.name(),
|
|
);
|
|
}
|
|
}
|
|
|
|
/// A test per case, and the list of which cases have one, from the same
|
|
/// place. A case the ordinary suite leaves out runs only in the long scan,
|
|
/// which nobody runs by hand.
|
|
macro_rules! cases {
|
|
($($name:ident = $case:expr,)*) => {
|
|
$(
|
|
#[test]
|
|
fn $name() {
|
|
for seed in SEEDS {
|
|
check(seed, depth(), $case);
|
|
}
|
|
}
|
|
)*
|
|
|
|
const NAMED: [Case; [$($case,)*].len()] = [$($case,)*];
|
|
};
|
|
}
|
|
|
|
cases! {
|
|
many_widgets_redrawing_at_once_leaves_every_box_where_it_was = Case::RepaintSome,
|
|
everything_redrawing_at_once_leaves_every_box_where_it_was = Case::Repaint,
|
|
a_resize_lands_where_starting_at_that_size_would = Case::Resize,
|
|
a_resize_and_a_repaint_land_where_starting_that_way_would = Case::ResizeRepaint,
|
|
a_size_change_after_a_resize_lands_the_same_way = Case::ResizeSize,
|
|
a_resize_after_a_size_change_lands_the_same_way = Case::SizeResize,
|
|
a_size_change_lands_where_growing_it_that_way_would = Case::Size,
|
|
every_size_changing_at_once_lands_where_growing_it_that_way_would = Case::EverySize,
|
|
an_alignment_change_lands_where_growing_it_that_way_would = Case::Align,
|
|
giving_and_taking_a_movable_region_rebuilds_what_resolves_it = Case::RegionNode,
|
|
reordering_a_span_lands_where_growing_it_that_way_would = Case::Reorder,
|
|
}
|
|
|
|
/// The shuffles are one test between them, so they are the only cases `ALL`
|
|
/// may hold without a test of their own.
|
|
#[test]
|
|
fn every_case_runs_without_the_long_scan() {
|
|
for case in ALL {
|
|
assert!(
|
|
NAMED.contains(&case) || matches!(case, Case::Shuffle(_)),
|
|
"{} runs only in the long seed scan; give it a case here",
|
|
case.name()
|
|
);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn adding_and_removing_span_children_lands_where_growing_it_that_way_would() {
|
|
for case in ALL {
|
|
if matches!(case, Case::Shuffle(_)) {
|
|
for seed in SEEDS {
|
|
check(seed, depth(), case);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
#[ignore = "as many seeds as it is asked for, rather than the ten the others check"]
|
|
fn a_long_run_of_seeds_agrees() {
|
|
let depth = depth();
|
|
let seeds: Vec<u64> = match std::env::var("IRIS_GENERATED_SEED")
|
|
.ok()
|
|
.and_then(|v| v.parse().ok())
|
|
{
|
|
Some(seed) => vec![seed],
|
|
None => (1..=env("IRIS_GENERATED_SEEDS", 100_u64)).collect(),
|
|
};
|
|
over_seeds(seeds, |seed| {
|
|
let grown = plan(seed, depth, &Edits::default());
|
|
for case in ALL {
|
|
check_plan(&grown, seed, depth, case);
|
|
}
|
|
});
|
|
}
|