Keep a subagent's words in its own transcript, and count the ones already running
Two corrections to the previous commit. A subagent's closing report belongs in the subagent's transcript, which is where it already is; drawing it as a card in the parent's put the same paragraph in two places for a reader who did not ask for it. The row is a divider now -- a boundary, which is what the transcript actually needed there -- closed, saying only what reported and how it went. Opening it shows the report anyway, since leaving the conversation to read one line has its own cost, and a backgrounded command has no transcript of its own so this is the only place its report exists at all: that one names itself from its summary and has nothing left to open. `TranscriptDivider` grew a `trailing` slot for the chevron rather than the row growing its own copy of the rules. And the status was wrong for a session that was already running before the update, which is every session when the backend is replaced under it. Adoption picks a session's stdout back up from a recorded offset, so the `task_started` lines for subagents launched earlier are behind it and the translator never saw them -- it started with an empty set and reported `idle` with a subagent plainly still working. `Subagents::any_open` reads the directory instead, which is a measurement rather than bookkeeping and is right for a session this process did not start. Both sources are kept and neither subsumes the other: the translator's own set is the only thing that knows about a backgrounded *command*, which has no subagent to be found. The same pair decides whether an ending has already been reported, so a task that began before the restart still gets its divider. Echo's helpers now record their report as their own subagent's closing text, the way the real driver does, so the fixture has the shape being tested. Verified on the emulator: three dividers closed, one opened to its report, and each reply drawn as its own message. 170 server tests, ktfmt, clippy, rustfmt, Android lint and the JVM unit tests all clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
5711c2568a
commit
ef1aad8776
11 files changed
+342
-120
No files matched your search
@@ -83,14 +83,21 @@ class TranscriptItemsTest {
|
||||
assertEquals(listOf("One turn.", "The next."), texts(whole))
|
||||
}
|
||||
|
||||
/** The endings nobody builds a screen for -- see [taskNoteHeading]. */
|
||||
/** The endings nobody builds a screen for -- see [taskNoteSummary]. */
|
||||
@Test
|
||||
fun a_task_note_says_which_ending_it_was() {
|
||||
assertEquals("Message from helper 1", taskNoteHeading("helper 1", "completed"))
|
||||
assertEquals("Message from a background task", taskNoteHeading(null, "completed"))
|
||||
assertEquals("helper 1 failed", taskNoteHeading("helper 1", "failed"))
|
||||
assertEquals("helper 1 was cancelled", taskNoteHeading("helper 1", "cancelled"))
|
||||
val said = "it said hello"
|
||||
// A subagent is named, and its own words stay in its own transcript rather than being
|
||||
// repeated here.
|
||||
assertEquals("helper 1 reported back", taskNoteSummary("helper 1", "completed", said))
|
||||
assertEquals("helper 1 failed", taskNoteSummary("helper 1", "failed", null))
|
||||
assertEquals("helper 1 was cancelled", taskNoteSummary("helper 1", "cancelled", said))
|
||||
// A word this build has never seen is said as itself, not mapped onto the nearest one.
|
||||
assertEquals("helper 1: evicted", taskNoteHeading("helper 1", "evicted"))
|
||||
assertEquals("helper 1: evicted", taskNoteSummary("helper 1", "evicted", said))
|
||||
// A backgrounded command has no title and no transcript of its own, so its summary is the
|
||||
// only record of it there is -- and it is already a sentence.
|
||||
val command = """Background command "build the kernel" completed (exit code 0)"""
|
||||
assertEquals(command, taskNoteSummary(null, "completed", command))
|
||||
assertEquals("A background task failed", taskNoteSummary(null, "failed", null))
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user