Record the #11 review and the pre-submit gate in the handoff
This commit is contained in:
1 parent
a9d63babe4
commit
bc555f9ded
1 file changed
+14
-6
@@ -11,12 +11,17 @@ it as a permanent decisions log; remove it after the extraction is complete.
|
||||
- Canonical `main` is at `0f6a28b4dd20d1f6bd745271c5f0926028c8fdb6`,
|
||||
the squash merge of PR #10.
|
||||
- **Updated 2026-09-13:** two independent PRs are open against canonical
|
||||
`main`, neither reviewed yet -- #11 (`split/11-texture-bindings`, the
|
||||
glyph atlas as an array texture and standalone images with their own bind
|
||||
groups) and #12 (`split/12-pointer-routing`, a scroll falling through a
|
||||
hovered button). Both branch from `0f6a28b` and touch disjoint paths, so
|
||||
either can merge first. Their worktrees are `/home/bob/repos/iris-pr11`
|
||||
`main` -- #11 (`split/11-texture-bindings`) and #12
|
||||
(`split/12-pointer-routing`, a scroll falling through a hovered button,
|
||||
not reviewed yet). Both branch from `0f6a28b` and touch disjoint paths,
|
||||
so either can merge first. Their worktrees are `/home/bob/repos/iris-pr11`
|
||||
and `/home/bob/repos/iris-pr12`.
|
||||
- #11 was reviewed `REQUEST_CHANGES` and reworked in response (commit
|
||||
`0106257`): atlas pages became their own type rather than a `TextureKind`
|
||||
tag on `Textures`, images went back through the single primitive instance
|
||||
list instead of a parallel one, group 2 became one array texture plus a
|
||||
sampler bound per draw run, and masks moved to group 3. Awaiting
|
||||
re-review.
|
||||
- `/home/bob/repos/ai-app-2` is on `rustify` at `50d214e` before this handoff
|
||||
commit. Its worktree was clean.
|
||||
- `/home/bob/repos/iris-pr10-text` is clean at `983e15c`, the merged PR head.
|
||||
@@ -199,7 +204,10 @@ The owner explicitly restored them after an over-aggressive TODO cleanup.
|
||||
|
||||
## Review and code-quality expectations
|
||||
|
||||
Every slice should get a sanity review, not merely a successful transplant.
|
||||
Run the installed `pre-submit-review` skill before creating or updating any
|
||||
pull request; the owner asked for a forced mechanism after #11, and it is the
|
||||
only copy of the procedure. Every slice should get a sanity review, not merely
|
||||
a successful transplant.
|
||||
Fix obvious smells, poor naming, needless allocation, awkward state shapes, and
|
||||
accidental complexity while keeping the slice focused. It is not necessary to
|
||||
fully understand or redesign every complicated subsystem.
|
||||
|
||||
Reference in new issue
Block a user