Close a card by pressing its words, and let a selection be put away
A markdown paragraph took every tap that landed on its glyphs, so an opened peer message or memory note could be shut anywhere except on the text -- which is most of it, and reads as a card that has stopped working. Measured on the emulator: with a handler on the text the tap did nothing at all, and with the handler removed the same tap shut the card. The words now do the shutting, through a composition local, since the renderer composes those paragraphs out of its own component table and there is nothing between the card and them to pass a parameter through. The link handler is bounded by the long-press timeout, so holding to select is not a tap. The other half is the tap that puts a selection away, which used to shut whatever card the words were in. The container clears the selection from that same press, milliseconds before the card reads it, so the answer is taken at composition instead -- what was true when the reader touched the screen. Selection colours are the app's own. Material's 40% of primary is a tint of whatever is behind it, and over the near-black a code block sits on it composited to a smudge, so selecting a line of code looked like nothing had happened. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
359649bc73
commit
acdf00ab1d
10 files changed
+336
-69
No files matched your search
@@ -281,6 +281,13 @@ fun SessionScreen(
|
||||
// have to ask whether anything is selected before they treat a tap as their own -- see
|
||||
// [expanding].
|
||||
val selection = rememberSelectionState()
|
||||
// Read here, at composition, rather than inside [expanding] at the moment of the click. The
|
||||
// container clears the selection from the very press that a card then reads as its own, a few
|
||||
// milliseconds earlier and in the same event -- so a card asking the live state at its click
|
||||
// always hears "nothing is selected", and a tap meant to put a selection away also shut the
|
||||
// tool call the words were in. This value is whatever was true as of the last frame, which is
|
||||
// what the reader was looking at when they touched the screen.
|
||||
val selecting = selection.selectedTexts.isNotEmpty()
|
||||
var expandedTools by remember { mutableStateOf(setOf<String>()) }
|
||||
// Which runs of adjacent tool calls are open. Keyed by the first call's
|
||||
// id, so a group survives more calls arriving after it.
|
||||
@@ -509,7 +516,7 @@ fun SessionScreen(
|
||||
* hold for only some of them.
|
||||
*/
|
||||
fun expanding(toggle: () -> Unit) {
|
||||
if (selection.selectedTexts.isNotEmpty()) {
|
||||
if (selecting) {
|
||||
selection.clear()
|
||||
return
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user