Record the round's last two findings, and the review the old code is owed
`pre-submit-review` arrived after the Rust port and most of Iris were written, so all of that went in unreviewed and no sweep has covered it. The surface-texture defect is the argument for a pass of its own. Nothing in Iris is kept for the app's sake either: the app is to be rewritten against the new API rather than ported call by call.
This commit is contained in:
1 parent
718923c217
commit
734c521f5d
2 files changed
+47
-23
No files matched your search
+19
-9
@@ -6,7 +6,7 @@ found is in `docs/LAYOUT_LOG.md`.
|
||||
|
||||
## The Iris layout repair is submitted
|
||||
|
||||
**Iris PR #19** (`layout/one-ask`) replaces closed #18. The tip is `7502176`,
|
||||
**Iris PR #19** (`layout/one-ask`) replaces closed #18. The tip is `1096c31`,
|
||||
and past the reviewed `cadfba0` it is seven rounds, each described in
|
||||
`docs/LAYOUT_LOG.md`:
|
||||
|
||||
@@ -24,9 +24,10 @@ and past the reviewed `cadfba0` it is seven rounds, each described in
|
||||
read, three reuse rejections the diagnostics could not see, and a fuzz case
|
||||
that ran only in the long scan.
|
||||
- **A sweep over the renderer, the text store and the retained path**,
|
||||
`d8d5122` through `7502176` -- a contract kept where the new window left
|
||||
`d8d5122` through `1096c31` -- a contract kept where the new window left
|
||||
it out, a surface configured under its own texture, a counter naming the
|
||||
wrong contract, and three things nothing reads.
|
||||
wrong contract, things nothing reads, and a question asked through a value
|
||||
rather than a reference.
|
||||
|
||||
The settled design of the last three is in `docs/LAYOUT.md` under "Three
|
||||
names, and the one argument that says them". Bryan settled the API over
|
||||
@@ -61,14 +62,23 @@ a compile error, which reads exactly like a fuzzer failure.
|
||||
`pre-submit-review` over each round's changes, and apply the gate above to
|
||||
whatever each one touched. The ordinary oracle does not replace absolute
|
||||
geometry and retained-primitive expectations.
|
||||
2. **Integrate the app's Iris capabilities before changing its pin.**
|
||||
2. **A review of everything written before the review gate existed.**
|
||||
`pre-submit-review` and the rule that nothing is submitted unreviewed
|
||||
arrived on 2026-09-13, well after the Rust port and most of Iris were
|
||||
written, so all of that code went in unreviewed and none of the five
|
||||
sweeps above covered more than the layout branch. It wants a pass of its
|
||||
own (Bryan, 2026-09-20). The surface-texture defect in `02048ea` is the
|
||||
argument: nothing about that arm was hard, and it was written wrong
|
||||
anyway, which is what a first reader catches and a later sweep of some
|
||||
other subject does not.
|
||||
3. **Integrate the app's Iris capabilities before changing its pin.**
|
||||
`32f6ad8` has 45 commits not reachable from the review branch; shared UI
|
||||
ownership, richer masks, Android support, and app-side performance work
|
||||
must survive the integration. The app then absorbs the branch's
|
||||
vocabulary and container API, all of it already upstream: `rest` ->
|
||||
`leftover`, `SizeRule` beside widgets, alignment properties, the removal
|
||||
of `OrthoSize`, region/placement/rel_base, and `PlaceDesc`.
|
||||
3. **Round-to-nearest**, CPU and shader together as one verified change.
|
||||
must survive the integration. What has to survive is those capabilities,
|
||||
not the calls the app makes today: the app is to be largely rewritten
|
||||
against the new API rather than ported call by call, so nothing in Iris
|
||||
is kept alive for the app's sake (Bryan, 2026-09-20).
|
||||
4. **Round-to-nearest**, CPU and shader together as one verified change.
|
||||
Bryan approved it on 2026-09-17 and neither half has landed; the
|
||||
derivation, the form to use and what to re-check are in `docs/LAYOUT.md`
|
||||
under "Rendering the grid (pending)".
|
||||
|
||||
Reference in new issue
Block a user