Record the eleventh sweep, over the built-in bounds work
This commit is contained in:
1 parent
17423a57b8
commit
5f01dc65c8
2 files changed
+123
-11
No files matched your search
+30
-11
@@ -8,12 +8,13 @@ found is in `docs/LAYOUT_LOG.md`.
|
||||
|
||||
Bryan clarified that the built-in attribute should replace the wrapper.
|
||||
Work is in `/home/bob/repos/iris-deferred`, on `layout/one-ask`, at
|
||||
`2ac0843` (pushed). Bounds now constrain the offer in `Placing::ask`; declarations
|
||||
are retained as resolved window lengths, so movement does not decide the
|
||||
bound again. `.max_width`/`.max_height` now edit the same widget, like the
|
||||
minimum helpers, and `MaxSize` is removed. Preferred lengths and bounds
|
||||
are independent, so either order of `.width` and `.max_width` works. The
|
||||
app pin is unchanged.
|
||||
`ea1f836` (pushed), which is the eleventh sweep over `2ac0843`. Bounds now
|
||||
constrain the offer in `Placing::ask`; declarations are retained as resolved
|
||||
window lengths, so movement does not decide the bound again.
|
||||
`.max_width`/`.max_height` now edit the same widget, like the minimum
|
||||
helpers, and `MaxSize` is removed. Preferred lengths and bounds are
|
||||
independent, so either order of `.width` and `.max_width` works. The app pin
|
||||
is unchanged.
|
||||
|
||||
The review fixed three cases: `window_holds` erasing an ask's bound crossing
|
||||
(seed 104, depth 5), inactive bound edits failing to update the parent's offer
|
||||
@@ -22,9 +23,10 @@ fractional intrinsic cap being read against its already-allocated slot.
|
||||
The latter has an absolute 75-in-300 geometry check; warm/cold agreement
|
||||
alone cannot catch it.
|
||||
|
||||
207 ordinary and 211 diagnostic tests pass, with warning-clean Clippy both
|
||||
ways. All three layout scans pass (400 depth 5, 1,000 depth 6, 2,000 depth 4),
|
||||
as do 400 depth-5 trees in each of three deferred-request corpora. All 34,986
|
||||
206 ordinary and 210 diagnostic tests pass, with warning-clean Clippy both
|
||||
ways (207 and 211 at `2ac0843`, less the duplicate test the sweep merged).
|
||||
All three layout scans pass (400 depth 5, 1,000 depth 6, 2,000 depth 4), as
|
||||
do 400 depth-5 trees in each of three deferred-request corpora. All 34,986
|
||||
unbounded cold boxes match `4cb6f68`; bounded offers intentionally change.
|
||||
The final unbounded-path optimization preserves every bounded cold box too.
|
||||
|
||||
@@ -36,6 +38,22 @@ widget; all three allocation fixtures remain allocation-free after warm-up.
|
||||
`docs/LAYOUT.md` records the contract and measurements. Artifacts are in
|
||||
`/tmp/attribute-bounds/`.
|
||||
|
||||
## A quality sweep of the bounds work is submitted on PR #19
|
||||
|
||||
The eleventh sweep landed at `ea1f836`. It is the first review of `2ac0843`
|
||||
-- `SizeRule` from an enum to a preferred length beside an independent bound,
|
||||
the offer constrained in `Placing::ask`, and `MaxSize` removed. Eight
|
||||
findings, the two largest being a hint read that answered "cannot say" above
|
||||
the diagnostics and so counted as no read at all, and five spellings of
|
||||
reading one environment variable across the rigs, which is the class the
|
||||
tenth sweep found one commit earlier -- there is now one `env` in
|
||||
`tests/rig/`, used by all six. `bounds_cost` also verified 128 regions inside
|
||||
its measured loop; the check moved out, and the 0.65% it measured is written
|
||||
beside it. `docs/LAYOUT_LOG.md` has all eight, with the two rules it tripped
|
||||
and left. Verified: format, clippy both ways, 206 and 210 tests, 400 depth-5
|
||||
trees warm against cold in 64.19s, and the cold dump byte-identical to
|
||||
`2ac0843` across all 34,986 boxes.
|
||||
|
||||
## A quality sweep of the deferred system is submitted on PR #19
|
||||
|
||||
The tenth sweep landed at `4cb6f68` in `/home/bob/repos/iris-deferred`. It is
|
||||
@@ -147,6 +165,7 @@ comparison work above, its review rounds past `cadfba0` are described in
|
||||
above the root, which would pin the tree to pixels.
|
||||
- **The deferred request system's own sweep**, `4cb6f68` -- described at the
|
||||
top of this file and in full in `docs/LAYOUT_LOG.md`.
|
||||
- **The bounds work's own sweep**, `ea1f836` -- the same, over `2ac0843`.
|
||||
|
||||
The settled design of the vocabulary rounds is in `docs/LAYOUT.md` under
|
||||
"Three names, and the one argument that says them". Bryan settled the API
|
||||
@@ -202,8 +221,8 @@ the name it is reachable by.
|
||||
**Always**, because they cost nothing: format, workspace clippy under
|
||||
`-D warnings` with and without `layout-diagnostics`, the workspace tests, and
|
||||
the **cold dump**. `layout_dump` over 400 depth-5 trees is **34,986** boxes
|
||||
since `76aaf06` grew bounds in the trees. It was 34,571 from `2dba90b`, which
|
||||
grew the images, and 34,488 before those; the fourth through eighth sweeps all
|
||||
since `76aaf06` grew bounds in the trees, and is unchanged through `ea1f836`.
|
||||
It was 34,571 from `2dba90b`, which grew the images, and 34,488 before those; the fourth through eighth sweeps all
|
||||
repeated 34,492, which is a `wc -l` of the whole run rather than of its box
|
||||
lines, so count the lines that are a box (`grep -cE '^[0-9]+ [0-9]+ '`). It is the only thing that catches two
|
||||
same-typed values being swapped, which is the failure mode of a rename or a
|
||||
|
||||
Reference in new issue
Block a user