Prune Iris TODO and prioritize color correctness

app-rust/android-project/app/src/main/java/dev/iris/android/demo/IrisView.java

@@ -1,15 +1,8 @@
 package dev.iris.android.demo;
 
 import android.app.Activity;
-import android.content.ClipData;
-import android.content.ClipboardManager;
 import android.content.Context;
 import android.view.Gravity;
-import android.view.View;
-import android.view.ViewGroup;
-import android.widget.Button;
-import android.widget.FrameLayout;
-import android.widget.LinearLayout;
 import android.widget.ScrollView;
 import android.widget.TextView;
 
@@ -77,80 +70,4 @@ public final class IrisView extends RustView {
         activity.setContentView(scroll);
     }
 
-    private static final String DIAGNOSTICS_OVERLAY_TAG = "iris-diagnostics-overlay";
-
-    /**
-     * The bench build's keyboard diagnostics capture
-     * (`bench_client.rs`'s `on_insets_changed` /
-     * `capture_keyboard_diagnostics`, via `bench_jni.rs`'s
-     * `PlatformHandle::show_diagnostics_overlay`): unlike
-     * `showRendererError` above, this adds a panel *over* this view
-     * (`MainActivity`'s `FrameLayout` still holds `IrisView` underneath,
-     * running) rather than replacing the activity's content, and gives it
-     * a Copy button and a Close that removes the panel -- so it draws
-     * (and can be read) whether or not iris itself is still putting
-     * anything on screen, without abandoning the session that produced
-     * it. Runs on the UI thread regardless of which thread calls it,
-     * since the call comes from a background task (a delayed capture
-     * after the keyboard opens), and touching the view tree off the UI
-     * thread is undefined.
-     */
-    void showDiagnosticsOverlay(String report) {
-        Context context = getContext();
-        if (!(context instanceof Activity)) {
-            return;
-        }
-        Activity activity = (Activity) context;
-        activity.runOnUiThread(() -> {
-            ViewGroup parent = (ViewGroup) getParent();
-            if (parent == null) {
-                return;
-            }
-            View existing = parent.findViewWithTag(DIAGNOSTICS_OVERLAY_TAG);
-            if (existing != null) {
-                parent.removeView(existing);
-            }
-
-            float density = activity.getResources().getDisplayMetrics().density;
-            int pad = (int) (16 * density);
-
-            LinearLayout overlay = new LinearLayout(activity);
-            overlay.setTag(DIAGNOSTICS_OVERLAY_TAG);
-            overlay.setOrientation(LinearLayout.VERTICAL);
-            overlay.setBackgroundColor(0xEE000000);
-            overlay.setPadding(pad, pad, pad, pad);
-
-            TextView text = new TextView(activity);
-            text.setText(report);
-            text.setTextIsSelectable(true);
-            text.setTextColor(0xFFFFFFFF);
-            ScrollView scroll = new ScrollView(activity);
-            scroll.addView(text);
-            overlay.addView(scroll, new LinearLayout.LayoutParams(
-                    LinearLayout.LayoutParams.MATCH_PARENT, 0, 1f));
-
-            LinearLayout buttonRow = new LinearLayout(activity);
-            buttonRow.setOrientation(LinearLayout.HORIZONTAL);
-            buttonRow.setPadding(0, pad, 0, 0);
-
-            Button copy = new Button(activity);
-            copy.setText("Copy");
-            copy.setOnClickListener(v -> {
-                ClipboardManager clipboard =
-                        (ClipboardManager) activity.getSystemService(Context.CLIPBOARD_SERVICE);
-                if (clipboard != null) {
-                    clipboard.setPrimaryClip(ClipData.newPlainText("iris diagnostics", report));
-                }
-            });
-            Button close = new Button(activity);
-            close.setText("Close");
-            close.setOnClickListener(v -> parent.removeView(overlay));
-            buttonRow.addView(copy);
-            buttonRow.addView(close);
-            overlay.addView(buttonRow);
-
-            parent.addView(overlay, new FrameLayout.LayoutParams(
-                    FrameLayout.LayoutParams.MATCH_PARENT, FrameLayout.LayoutParams.MATCH_PARENT));
-        });
-    }
 }

app-rust/src/android/bench_jni.rs

@@ -222,31 +222,4 @@ impl PlatformHandle {
             .ok()
         }
     }
-
-    /// Shows `report` in the shell's plain-view diagnostics overlay
-    /// (`IrisView.showDiagnosticsOverlay`) -- a real `TextView` plus Copy
-    /// and Close controls, added over whatever iris itself is drawing
-    /// rather than replacing it (unlike `android::view::show_renderer_error`,
-    /// which exists for the case the renderer can never recover from and
-    /// intentionally never returns). Called from a background task after
-    /// the keyboard-open delay (`bench_client.rs`'s `on_insets_changed`),
-    /// so the Java side hops onto the UI thread itself before touching the
-    /// view tree -- see that method's own comment.
-    pub fn show_diagnostics_overlay(&self, report: &str) -> bool {
-        self.try_show_diagnostics_overlay(report).is_some()
-    }
-
-    fn try_show_diagnostics_overlay(&self, report: &str) -> Option<()> {
-        let mut guard = self.vm.attach_current_thread().ok()?;
-        let env: &mut JNIEnv = &mut guard;
-        let jreport = env.new_string(report).ok()?;
-        env.call_method(
-            self.view.as_obj(),
-            "showDiagnosticsOverlay",
-            "(Ljava/lang/String;)V",
-            &[JValue::Object(jreport.as_ref())],
-        )
-        .ok()?;
-        Some(())
-    }
 }