Record what the step 1 review found
The pre-submit review of the six one-ask commits found a scroll placing content that fits into a window-length box rather than its viewport, and three comments still calling window lengths frame lengths.
This commit is contained in:
1 parent
2a3072b90a
commit
2fa734cd63
2 files changed
+66
-18
No files matched your search
+21
-18
@@ -14,20 +14,21 @@ detached comparison checkout is `/home/bob/repos/iris-layout-baseline`. It is
|
||||
the reviewed baseline this work must preserve or improve.
|
||||
|
||||
The continuation is `/home/bob/repos/iris-layout-experiment`, now on branch
|
||||
**`wip/one-ask`** at **`a30971e`**, six commits over `4328eac` (the head of
|
||||
**`wip/one-ask`** at **`a888717`**, eight commits over `4328eac` (the head of
|
||||
`wip/transparent-frames`, which is unchanged). It replaces the old step 3
|
||||
plan with the one-ask protocol below, and `1512d84` and `23523ee` make the
|
||||
frame a length of the window. It passes every check:
|
||||
plan with the one-ask protocol below, `1512d84` and `23523ee` make the frame
|
||||
a length of the window, and `e8a5792` is what the step 1 review found. It
|
||||
passes every check:
|
||||
|
||||
| check at `a30971e` | result |
|
||||
| check at `a888717` | result |
|
||||
| --- | --- |
|
||||
| `cargo fmt --all --check`, clippy `-D warnings`, with and without `layout-diagnostics` | clean |
|
||||
| `cargo test --workspace` (debug) | 122 suite, 20 core, 11 generated, all green |
|
||||
| `cargo test --workspace` (debug) | 123 suite, 20 core, 11 generated, all green |
|
||||
| `cargo test --release --test generated` | 11/11 |
|
||||
| shrinker, 400 seeds, depth 5, all sixteen cases | agree, 66 s |
|
||||
| 1000 seeds at depth 6 | agree, 170 s |
|
||||
| 2000-seed depth-4 scan, all sixteen cases | agree, 310 s (82,203 widgets) |
|
||||
| renders and the `tabs` replay against #18 | inspected, see below |
|
||||
| shrinker, 400 seeds, depth 5, all sixteen cases | agree, 73 s (34,488 widgets) |
|
||||
| 1000 seeds at depth 6 | agree, 187 s |
|
||||
| 2000-seed depth-4 scan, all sixteen cases | agree, 347 s (82,203 widgets) |
|
||||
| renders, the `tabs` replay and the `random` resize against #18 | inspected, see below |
|
||||
|
||||
What implementing it corrected in the plan is in `docs/LAYOUT_LOG.md`; the
|
||||
four that would have shipped as wrong layout are a share inside padding
|
||||
@@ -40,10 +41,12 @@ The renders and the replay are done and recorded in `docs/LAYOUT_LOG.md`:
|
||||
against #18, `minimal` and `tabs` are byte-identical (before and after the
|
||||
reference gesture), `random` differs in two pixels of glyph antialiasing,
|
||||
`text` moves one padded block one pixel, and a live resize of `random`
|
||||
matches a cold render at that size byte for byte.
|
||||
matches a cold render at that size byte for byte. Re-run at `a888717`, all
|
||||
five are byte-identical to the same renders at `a30971e`, so the scroll fix
|
||||
below changed none of them.
|
||||
|
||||
Not done: the retained-cost work (step 5) and a pre-submit review of the six
|
||||
commits as one diff (step 1).
|
||||
Not done: the retained-cost work (step 5). Step 1's review is done and what
|
||||
it found is in `docs/LAYOUT_LOG.md`.
|
||||
|
||||
The worker's older step 3/4 experiment is preserved as branch
|
||||
`wip/step3-experiment` (one commit over `4328eac`) and as
|
||||
@@ -263,12 +266,12 @@ a second draw back.
|
||||
|
||||
### 1. Review the six commits
|
||||
|
||||
Run the pre-submit review over the six commits as one diff against
|
||||
`4328eac`. `1512d84` rewrote much of what the first two did to `painter.rs`
|
||||
and `render_state.rs` and was reviewed as it was written, but the six have
|
||||
never been read as one change, and the parts of the one-ask protocol it did
|
||||
not touch -- `place_at`, the twice-asked deferral, `Span`'s two passes --
|
||||
were written as a probe and reviewed only by their tests.
|
||||
**Done at `a888717`.** The pre-submit review over the six commits as one
|
||||
diff against `4328eac` found one wrong layout -- a scroll placing content
|
||||
that fits into a window-length box rather than the viewport -- and three
|
||||
comments left describing lengths as fractions of the frame. Both are in
|
||||
`docs/LAYOUT_LOG.md`; the fix is `e8a5792`, pinned by
|
||||
`scroll::content_that_fits_is_placed_in_the_viewport_and_not_in_the_window`.
|
||||
|
||||
### 2. Make the frame a length and the box a region
|
||||
|
||||
|
||||
Reference in new issue
Block a user