Compare commits
2
Commits
40b89c1f79
...
6c84b6f2cb
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6c84b6f2cb | ||
|
|
8d2b7a512b |
No files matched your search
+11
-15
@@ -37,8 +37,8 @@ impl Widget for Span {
|
||||
painter.widget_at(child, room).len(axis)
|
||||
}
|
||||
};
|
||||
cursor.px += len.px + self.gap;
|
||||
cursor.rel += len.rel;
|
||||
cursor += len.without_leftover();
|
||||
cursor.px += self.gap;
|
||||
lens.push(len);
|
||||
}
|
||||
|
||||
@@ -83,15 +83,14 @@ impl Widget for Span {
|
||||
let shrinks = !painter.has_exact_size(!axis);
|
||||
// What the fixed parts and the gaps before here take, which is a sum
|
||||
// of lengths and exact, and how much of the leftover weight is
|
||||
// spoken for. A position is one from the other rather than a step
|
||||
// from the last child: the share of the room is rounded, and taking
|
||||
// each from the one before it would carry every rounding along the
|
||||
// row.
|
||||
// spoken for. Both ends of a slot are read from those two rather
|
||||
// than stepped from the last child: the share of the room is
|
||||
// rounded, and taking each end from the one before it would carry
|
||||
// every rounding along the row.
|
||||
let mut fixed = Len::rel_min();
|
||||
let mut taken = Weight::ZERO;
|
||||
let mut start = Len::rel_min();
|
||||
let mut ortho = LayoutLen::ZERO;
|
||||
let shared = |fixed: Len, taken: Weight| match taken == Weight::ZERO {
|
||||
let reached = |fixed: Len, taken: Weight| match taken == Weight::ZERO {
|
||||
true => fixed,
|
||||
false => fixed + room.scale(Rel::ratio(taken, total.leftover)),
|
||||
};
|
||||
@@ -102,15 +101,14 @@ impl Widget for Span {
|
||||
if len.is_only_leftover() && !shares {
|
||||
painter.undraw(child);
|
||||
fixed.px += self.gap;
|
||||
start = shared(fixed, taken);
|
||||
continue;
|
||||
}
|
||||
let from = start;
|
||||
let from = reached(fixed, taken);
|
||||
if len.leftover > Weight::ZERO && shares {
|
||||
taken += len.leftover;
|
||||
}
|
||||
fixed += len.without_leftover();
|
||||
start = shared(fixed, taken);
|
||||
let to = reached(fixed, taken);
|
||||
// Along the row the span says where the child goes, and that slot
|
||||
// is the child's box outright rather than something to place an
|
||||
// answer inside again. A share is decided here and nowhere
|
||||
@@ -118,7 +116,7 @@ impl Widget for Span {
|
||||
// it, since a text wraps at the width it is actually given. A
|
||||
// fixed child's slot is its own answer, so a drawing made in the
|
||||
// room is put there as it is, and one not made yet is made here.
|
||||
let slot = along(from, start);
|
||||
let slot = along(from, to);
|
||||
let mut place = slot.shifted_desc().fills().on_axis(axis);
|
||||
if len.leftover > Weight::ZERO && shares {
|
||||
place = place.rel_base(axis, slot.len());
|
||||
@@ -136,7 +134,6 @@ impl Widget for Span {
|
||||
}
|
||||
}
|
||||
fixed.px += self.gap;
|
||||
start = shared(fixed, taken);
|
||||
}
|
||||
|
||||
// Carried whole rather than collapsed to one share: a span that sizes
|
||||
@@ -146,12 +143,11 @@ impl Widget for Span {
|
||||
// get a quarter each, which collapsing to `leftover(1)` per level does
|
||||
// not give. Resolution happens at the nearest ancestor with a length,
|
||||
// and the root always has one.
|
||||
let along = total;
|
||||
let ortho = match shrinks {
|
||||
true => ortho,
|
||||
false => LayoutLen::rel(1.0),
|
||||
};
|
||||
Size::from_axis(axis, along, ortho)
|
||||
Size::from_axis(axis, total, ortho)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1067,3 +1067,32 @@ fn resizing_under_a_short_scroll_snaps_its_window_tall_content_again() {
|
||||
|
||||
assert_same_regions(&warm, &ids, &cold, &cold_ids);
|
||||
}
|
||||
|
||||
/// A scroll clamps its position against the box it is drawn in, so drawing it
|
||||
/// once at one viewport and again at another writes state the second draw then
|
||||
/// reads. That the answer is still the one a cold layout gives is a property
|
||||
/// of the clamp, not something the layout enforces.
|
||||
#[test]
|
||||
fn a_scrolled_view_resized_lands_where_a_cold_layout_puts_it() {
|
||||
for amt in [10.0, 40.0, 90.0, 140.0] {
|
||||
let mut warm = Harness::new((100, 100));
|
||||
let (_, warm_scroll) = plant_wider(&mut warm, 100.0);
|
||||
warm.move_to((50.0, 50.0));
|
||||
warm.scroll((-amt, 0.0));
|
||||
warm.frame();
|
||||
warm.resize((160, 100));
|
||||
warm.frame();
|
||||
|
||||
let mut cold = Harness::new((160, 100));
|
||||
let (_, cold_scroll) = plant_wider(&mut cold, 100.0);
|
||||
cold.move_to((50.0, 50.0));
|
||||
cold.scroll((-amt, 0.0));
|
||||
cold.frame();
|
||||
|
||||
assert_eq!(
|
||||
warm.region(&warm_scroll),
|
||||
cold.region(&cold_scroll),
|
||||
"scrolled by {amt} then widened"
|
||||
);
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user