iris is the framework alone; the app is one crate in app-rust/
Iris: "the organization of the rust rewrite is a mess right now... there shouldn't be anything related to the app inside of iris. Iris is supposed to be the UI framework alone." And, on the crate count: "I'm confused why the app only code needs more than one crate though." Nine cargo workspaces become three, and the port's project code -- which sat in five places, four of them inside the framework -- becomes one crate, `ai-app`, in `app-rust/`: client-core -> app-rust/src/client iris/transcript-ui -> app-rust/src/ui iris/transcript-fixture -> app-rust/src/ui/fixture.rs + tests/ + touch/ iris/desktop-app -> app-rust/src/desktop + src/bin_desktop.rs iris/android-app -> app-rust/src/android + android-project/ android-shell -> app-rust/src/shell iris/ keeps core, macro, the iris crate, tabs-ui and rig-input, and now mentions no session, transcript, setup or server anywhere. Only two of the old splits had a reason that survived reading. event-model stays a crate at the repo root because server/ depends on it too, so a crate is what makes the backend and the app agree by construction. The two Android .so names looked like a hard constraint -- a package produces one library artifact -- until P2 turned out to already plan merging those two Android apps into one; both faces now come out of libai_app.so, picked apart by features so `--no-default-features --features shell` keeps wgpu, parley and iris out of the Compose app's APK. docs/RUST.md's "One app crate" has the rest, including what each remaining feature is for. DECISIONS.md and SUBAGENTS.md move into docs/ with everything else. Verified: ./run-tests.sh and `cd iris && cargo test` green, clippy and fmt clean in all five workspaces, `cargo ndk -t x86_64` links libai_app.so, build-apk.sh produces an APK that installs and launches on this checkout's emulator (Gl ... virgl, as expected), and the phone-sized headless screenshot renders the transcript unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
7b54aaf3c4
commit
a9312e9431
113 files changed
+23221
-2992
No files matched your search
+3
-3
@@ -4,9 +4,9 @@ version.workspace = true
|
||||
edition.workspace = true
|
||||
|
||||
[dependencies]
|
||||
proc-macro2 = "1.0.103"
|
||||
quote = "1.0.42"
|
||||
syn = { version = "2.0.111", features = ["full"] }
|
||||
proc-macro2 = "1.0.107"
|
||||
quote = "1.0.47"
|
||||
syn = { version = "3.0.5", features = ["full"] }
|
||||
|
||||
[lib]
|
||||
proc-macro = true
|
||||
+15
-3
@@ -18,6 +18,12 @@ struct Input {
|
||||
}
|
||||
|
||||
struct InputFn {
|
||||
/// Everything written above the `fn` -- in practice a `///` doc
|
||||
/// comment, which is why this exists: `masked_by` and its siblings
|
||||
/// are public API and rustdoc is where their contract is read, so a
|
||||
/// macro that silently rejected `///` sent the explanation into an
|
||||
/// ordinary `//` comment nobody generating docs ever sees.
|
||||
attrs: Vec<Attribute>,
|
||||
sig: Signature,
|
||||
body: Block,
|
||||
}
|
||||
@@ -32,9 +38,10 @@ impl Parse for Input {
|
||||
input.parse::<Token![;]>()?;
|
||||
let mut fns = Vec::new();
|
||||
while !input.is_empty() {
|
||||
let attrs = input.call(Attribute::parse_outer)?;
|
||||
let sig = input.parse()?;
|
||||
let body = input.parse()?;
|
||||
fns.push(InputFn { sig, body })
|
||||
fns.push(InputFn { attrs, sig, body })
|
||||
}
|
||||
if !input.is_empty() {
|
||||
input.error("function expected");
|
||||
@@ -59,10 +66,15 @@ pub fn widget_trait(input: TokenStream) -> TokenStream {
|
||||
fns,
|
||||
} = parse_macro_input!(input as Input);
|
||||
|
||||
let sigs: Vec<_> = fns.iter().map(|f| f.sig.clone()).collect();
|
||||
// The attributes go on the trait's own signature, which is the one
|
||||
// rustdoc renders; the impl gets the bare `fn`.
|
||||
let sigs: Vec<_> = fns
|
||||
.iter()
|
||||
.map(|InputFn { attrs, sig, .. }| quote! { #(#attrs)* #sig })
|
||||
.collect();
|
||||
let impls: Vec<_> = fns
|
||||
.iter()
|
||||
.map(|InputFn { sig, body }| quote! { #sig #body })
|
||||
.map(|InputFn { sig, body, .. }| quote! { #sig #body })
|
||||
.collect();
|
||||
|
||||
let Some(GenericParam::Type(state)) = generics.params.first() else {
|
||||
|
||||
Reference in new issue
Block a user