work

core/src/widget/handle.rs

@@ -1,7 +1,7 @@
 use std::{marker::Unsize, ops::CoerceUnsized, sync::mpsc::Sender};
 
 use crate::{
-    HasUi, Widget,
+    UiRsc, Widget,
     util::{RefCounter, SlotId},
 };
 
@@ -12,7 +12,7 @@ pub type WidgetId = SlotId;
 /// a signal is sent to the owning UI to clean up the resources.
 ///
 /// TODO: ergonomic clones when they get put in rust-analyzer & don't cause ICEs?
-pub struct WidgetHandle<W: ?Sized = dyn Widget> {
+pub struct StrongWidget<W: ?Sized = dyn Widget> {
     pub(super) id: WidgetId,
     counter: RefCounter,
     send: Sender<WidgetId>,
@@ -21,24 +21,19 @@ pub struct WidgetHandle<W: ?Sized = dyn Widget> {
 
 /// A weak handle to a widget.
 /// Will not keep it alive, but can still be used for indexing like WidgetHandle.
-pub struct WidgetRef<W: ?Sized = dyn Widget> {
+pub struct WeakWidget<W: ?Sized = dyn Widget> {
     pub(super) id: WidgetId,
     #[allow(unused)]
     ty: *const W,
 }
 
-pub struct WidgetHandles<W: ?Sized = dyn Widget> {
-    pub h: WidgetHandle<W>,
-    pub r: WidgetRef<W>,
-}
-
-impl<W: Widget + ?Sized + Unsize<dyn Widget>> WidgetHandle<W> {
-    pub fn any(self) -> WidgetHandle<dyn Widget> {
+impl<W: Widget + ?Sized + Unsize<dyn Widget>> StrongWidget<W> {
+    pub fn any(self) -> StrongWidget<dyn Widget> {
         self
     }
 }
 
-impl<W: ?Sized> WidgetHandle<W> {
+impl<W: ?Sized> StrongWidget<W> {
     pub(crate) fn new(id: WidgetId, send: Sender<WidgetId>) -> Self {
         Self {
             id,
@@ -56,18 +51,13 @@ impl<W: ?Sized> WidgetHandle<W> {
         self.counter.refs()
     }
 
-    pub fn weak(&self) -> WidgetRef<W> {
+    pub fn weak(&self) -> WeakWidget<W> {
         let Self { ty, id, .. } = *self;
-        WidgetRef { ty, id }
-    }
-
-    pub fn handles(self) -> WidgetHandles<W> {
-        let r = self.weak();
-        WidgetHandles { h: self, r }
+        WeakWidget { ty, id }
     }
 }
 
-impl<W: ?Sized> WidgetRef<W> {
+impl<W: ?Sized> WeakWidget<W> {
     pub(crate) fn new(id: WidgetId) -> Self {
         Self { id, ty: null_ptr() }
     }
@@ -77,12 +67,12 @@ impl<W: ?Sized> WidgetRef<W> {
     }
 
     #[track_caller]
-    pub fn upgrade(self, ui: &mut impl HasUi) -> WidgetHandle<W> {
-        ui.ui_mut().widgets.upgrade(self)
+    pub fn upgrade(self, ui: &mut impl UiRsc) -> StrongWidget<W> {
+        ui.widgets_mut().upgrade(self)
     }
 }
 
-impl<W: ?Sized> Drop for WidgetHandle<W> {
+impl<W: ?Sized> Drop for StrongWidget<W> {
     fn drop(&mut self) {
         if self.counter.drop() {
             let _ = self.send.send(self.id);
@@ -90,29 +80,29 @@ impl<W: ?Sized> Drop for WidgetHandle<W> {
     }
 }
 
-pub trait WidgetIdFn<Rsc, W: ?Sized = dyn Widget>: FnOnce(&mut Rsc) -> WidgetRef<W> {}
-impl<Rsc, W: ?Sized, F: FnOnce(&mut Rsc) -> WidgetRef<W>> WidgetIdFn<Rsc, W> for F {}
+pub trait WidgetIdFn<Rsc, W: ?Sized = dyn Widget>: FnOnce(&mut Rsc) -> WeakWidget<W> {}
+impl<Rsc, W: ?Sized, F: FnOnce(&mut Rsc) -> WeakWidget<W>> WidgetIdFn<Rsc, W> for F {}
 
 pub trait IdLike {
     type Widget: ?Sized;
     fn id(&self) -> WidgetId;
 }
 
-impl<W: ?Sized> IdLike for &WidgetHandle<W> {
+impl<W: ?Sized> IdLike for &StrongWidget<W> {
     type Widget = W;
     fn id(&self) -> WidgetId {
         self.id
     }
 }
 
-impl<W: ?Sized> IdLike for WidgetHandle<W> {
+impl<W: ?Sized> IdLike for StrongWidget<W> {
     type Widget = W;
     fn id(&self) -> WidgetId {
         self.id
     }
 }
 
-impl<W: ?Sized> IdLike for WidgetRef<W> {
+impl<W: ?Sized> IdLike for WeakWidget<W> {
     type Widget = W;
     fn id(&self) -> WidgetId {
         self.id
@@ -126,38 +116,38 @@ impl IdLike for WidgetId {
     }
 }
 
-impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<WidgetHandle<U>> for WidgetHandle<T> {}
-impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<WidgetRef<U>> for WidgetRef<T> {}
+impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<StrongWidget<U>> for StrongWidget<T> {}
+impl<T: ?Sized + Unsize<U>, U: ?Sized> CoerceUnsized<WeakWidget<U>> for WeakWidget<T> {}
 
-impl<W: ?Sized> Clone for WidgetRef<W> {
+impl<W: ?Sized> Clone for WeakWidget<W> {
     fn clone(&self) -> Self {
         *self
     }
 }
-impl<W: ?Sized> Copy for WidgetRef<W> {}
-impl<W: ?Sized> PartialEq for WidgetRef<W> {
+impl<W: ?Sized> Copy for WeakWidget<W> {}
+impl<W: ?Sized> PartialEq for WeakWidget<W> {
     fn eq(&self, other: &Self) -> bool {
         self.id == other.id
     }
 }
 
-impl<W> PartialEq for WidgetHandle<W> {
+impl<W> PartialEq for StrongWidget<W> {
     fn eq(&self, other: &Self) -> bool {
         self.id == other.id
     }
 }
 
-impl<W> std::fmt::Debug for WidgetHandle<W> {
+impl<W> std::fmt::Debug for StrongWidget<W> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         self.id.fmt(f)
     }
 }
 
-impl<'a, W: Widget + 'a, State: HasUi> FnOnce<(&'a mut State,)> for WidgetRef<W> {
+impl<'a, W: Widget + 'a, State: UiRsc> FnOnce<(&'a mut State,)> for WeakWidget<W> {
     type Output = &'a mut W;
 
     extern "rust-call" fn call_once(self, args: (&'a mut State,)) -> Self::Output {
-        &mut args.0.ui_mut()[self]
+        &mut args.0.widgets_mut()[self]
     }
 }
 
@@ -170,5 +160,5 @@ fn null_ptr<W: ?Sized>() -> *const W {
     }
 }
 
-unsafe impl<W: ?Sized> Send for WidgetRef<W> {}
-unsafe impl<W: ?Sized> Sync for WidgetRef<W> {}
+unsafe impl<W: ?Sized> Send for WeakWidget<W> {}
+unsafe impl<W: ?Sized> Sync for WeakWidget<W> {}

core/src/widget/like.rs

@@ -1,20 +1,20 @@
-use crate::HasUi;
+use crate::{HasRoot, UiRsc};
 
 use super::*;
 use std::marker::Unsize;
 
-pub trait WidgetLike<Rsc: HasUi, Tag>: Sized {
+pub trait WidgetLike<Rsc: UiRsc, Tag>: Sized {
     type Widget: Widget + ?Sized + Unsize<dyn Widget>;
 
-    fn add(self, rsc: &mut Rsc) -> WidgetRef<Self::Widget>;
+    fn add(self, rsc: &mut Rsc) -> WeakWidget<Self::Widget>;
 
-    fn add_strong(self, rsc: &mut Rsc) -> WidgetHandle<Self::Widget> {
-        self.add(rsc).upgrade(rsc.ui_mut())
+    fn add_strong(self, rsc: &mut Rsc) -> StrongWidget<Self::Widget> {
+        self.add(rsc).upgrade(rsc)
     }
 
     fn with_id<W2>(
         self,
-        f: impl FnOnce(&mut Rsc, WidgetRef<Self::Widget>) -> WidgetRef<W2>,
+        f: impl FnOnce(&mut Rsc, WeakWidget<Self::Widget>) -> WeakWidget<W2>,
     ) -> impl WidgetIdFn<Rsc, W2> {
         move |state| {
             let id = self.add(state);
@@ -22,14 +22,12 @@ pub trait WidgetLike<Rsc: HasUi, Tag>: Sized {
         }
     }
 
-    fn set_root(self, state: &mut Rsc) {
-        let id = self.add(state);
-        let ui = state.ui_mut();
-        ui.root = Some(id.upgrade(ui));
-    }
-
-    fn handles(self, state: &mut Rsc) -> WidgetHandles<Self::Widget> {
-        self.add(state).upgrade(state.ui_mut()).handles()
+    fn set_root(self, rsc: &mut Rsc)
+    where
+        Rsc: HasRoot,
+    {
+        let id = self.add_strong(rsc);
+        rsc.set_root(id);
     }
 }
 
@@ -50,12 +48,12 @@ macro_rules! impl_widget_arr {
         impl_widget_arr!($n;$($W)*;$(${concat($W,Tag)})*);
     };
     ($n:expr;$($W:ident)*;$($Tag:ident)*) => {
-        impl<Rsc: HasUi, $($W: WidgetLike<Rsc, $Tag>,$Tag,)*> WidgetArrLike<Rsc, $n, ($($Tag,)*)> for ($($W,)*) {
+        impl<Rsc: UiRsc, $($W: WidgetLike<Rsc, $Tag>,$Tag,)*> WidgetArrLike<Rsc, $n, ($($Tag,)*)> for ($($W,)*) {
             fn add(self, rsc: &mut Rsc) -> WidgetArr<$n> {
                 #[allow(non_snake_case)]
                 let ($($W,)*) = self;
                 WidgetArr::new(
-                    [$($W.add(rsc).upgrade(rsc.ui_mut()),)*],
+                    [$($W.add(rsc).upgrade(rsc),)*],
                 )
             }
         }

core/src/widget/mod.rs

@@ -61,27 +61,27 @@ pub trait WidgetFn<State, W: Widget + ?Sized>: FnOnce(&mut State) -> W {}
 impl<State, W: Widget + ?Sized, F: FnOnce(&mut State) -> W> WidgetFn<State, W> for F {}
 
 pub struct WidgetArr<const LEN: usize> {
-    pub arr: [WidgetHandle; LEN],
+    pub arr: [StrongWidget; LEN],
 }
 
 impl<const LEN: usize> WidgetArr<LEN> {
-    pub fn new(arr: [WidgetHandle; LEN]) -> Self {
+    pub fn new(arr: [StrongWidget; LEN]) -> Self {
         Self { arr }
     }
 }
 
 pub trait WidgetOption<State> {
-    fn get(self, state: &mut State) -> Option<WidgetHandle>;
+    fn get(self, state: &mut State) -> Option<StrongWidget>;
 }
 
 impl<State> WidgetOption<State> for () {
-    fn get(self, _: &mut State) -> Option<WidgetHandle> {
+    fn get(self, _: &mut State) -> Option<StrongWidget> {
         None
     }
 }
 
-impl<State, F: FnOnce(&mut State) -> Option<WidgetHandle>> WidgetOption<State> for F {
-    fn get(self, state: &mut State) -> Option<WidgetHandle> {
+impl<State, F: FnOnce(&mut State) -> Option<StrongWidget>> WidgetOption<State> for F {
+    fn get(self, state: &mut State) -> Option<StrongWidget> {
         self(state)
     }
 }

core/src/widget/tag.rs

@@ -1,19 +1,19 @@
 use super::*;
-use crate::HasUi;
+use crate::UiRsc;
 use std::marker::Unsize;
 
 pub struct WidgetTag;
-impl<Rsc: HasUi, W: Widget> WidgetLike<Rsc, WidgetTag> for W {
+impl<Rsc: UiRsc, W: Widget> WidgetLike<Rsc, WidgetTag> for W {
     type Widget = W;
-    fn add(self, rsc: &mut Rsc) -> WidgetRef<W> {
-        rsc.ui_mut().widgets.add_weak(self)
+    fn add(self, rsc: &mut Rsc) -> WeakWidget<W> {
+        rsc.add_widget(self)
     }
 }
 
 pub struct FnTag;
-impl<Rsc: HasUi, W: Widget, F: FnOnce(&mut Rsc) -> W> WidgetLike<Rsc, FnTag> for F {
+impl<Rsc: UiRsc, W: Widget, F: FnOnce(&mut Rsc) -> W> WidgetLike<Rsc, FnTag> for F {
     type Widget = W;
-    fn add(self, rsc: &mut Rsc) -> WidgetRef<W> {
+    fn add(self, rsc: &mut Rsc) -> WeakWidget<W> {
         self(rsc).add(rsc)
     }
 }
@@ -23,36 +23,38 @@ pub trait WidgetFnTrait<Rsc> {
     fn run(self, rsc: &mut Rsc) -> Self::Widget;
 }
 pub struct FnTraitTag;
-impl<Rsc: HasUi, T: WidgetFnTrait<Rsc>> WidgetLike<Rsc, FnTraitTag> for T {
+impl<Rsc: UiRsc, T: WidgetFnTrait<Rsc>> WidgetLike<Rsc, FnTraitTag> for T {
     type Widget = T::Widget;
     #[track_caller]
-    fn add(self, rsc: &mut Rsc) -> WidgetRef<T::Widget> {
+    fn add(self, rsc: &mut Rsc) -> WeakWidget<T::Widget> {
         self.run(rsc).add(rsc)
     }
 }
 
 pub struct RefTag;
-impl<Rsc: HasUi, W: ?Sized + Widget + Unsize<dyn Widget>> WidgetLike<Rsc, RefTag> for WidgetRef<W> {
+impl<Rsc: UiRsc, W: ?Sized + Widget + Unsize<dyn Widget>> WidgetLike<Rsc, RefTag>
+    for WeakWidget<W>
+{
     type Widget = W;
-    fn add(self, _: &mut Rsc) -> WidgetRef<W> {
+    fn add(self, _: &mut Rsc) -> WeakWidget<W> {
         self
     }
 }
 
 pub struct RefFnTag;
-impl<Rsc: HasUi, W: ?Sized + Widget + Unsize<dyn Widget>, F: FnOnce(&mut Rsc) -> WidgetRef<W>>
+impl<Rsc: UiRsc, W: ?Sized + Widget + Unsize<dyn Widget>, F: FnOnce(&mut Rsc) -> WeakWidget<W>>
     WidgetLike<Rsc, RefFnTag> for F
 {
     type Widget = W;
-    fn add(self, rsc: &mut Rsc) -> WidgetRef<W> {
+    fn add(self, rsc: &mut Rsc) -> WeakWidget<W> {
         self(rsc)
     }
 }
 
 pub struct ViewTag;
-impl<Rsc: HasUi, V: WidgetView> WidgetLike<Rsc, ViewTag> for V {
+impl<Rsc: UiRsc, V: WidgetView> WidgetLike<Rsc, ViewTag> for V {
     type Widget = V::Widget;
-    fn add(self, _: &mut Rsc) -> WidgetRef<Self::Widget> {
+    fn add(self, _: &mut Rsc) -> WeakWidget<Self::Widget> {
         self.root()
     }
 }

core/src/widget/view.rs

@@ -1,16 +1,16 @@
 use std::marker::Unsize;
 
-use crate::{Widget, WidgetRef};
+use crate::{Widget, WeakWidget};
 
 pub trait WidgetView {
     type Widget: Widget + ?Sized + Unsize<dyn Widget>;
-    fn root(&self) -> WidgetRef<Self::Widget>;
+    fn root(&self) -> WeakWidget<Self::Widget>;
 }
 
 pub trait HasWidget {
     type Widget: Widget + ?Sized + Unsize<dyn Widget>;
 }
 
-impl<W: Widget + Unsize<dyn Widget> + ?Sized> HasWidget for WidgetRef<W> {
+impl<W: Widget + Unsize<dyn Widget> + ?Sized> HasWidget for WeakWidget<W> {
     type Widget = W;
 }

core/src/widget/widgets.rs

@@ -1,7 +1,7 @@
-use std::sync::mpsc::Sender;
+use std::sync::mpsc::{Receiver, Sender, channel};
 
 use crate::{
-    IdLike, Widget, WidgetData, WidgetHandle, WidgetId, WidgetRef,
+    IdLike, StrongWidget, WeakWidget, Widget, WidgetData, WidgetId,
     util::{DynBorrower, HashSet, SlotVec, forget_mut, to_mut},
 };
 
@@ -9,16 +9,19 @@ pub struct Widgets {
     pub needs_redraw: HashSet<WidgetId>,
     vec: SlotVec<WidgetData>,
     send: Sender<WidgetId>,
+    recv: Receiver<WidgetId>,
     pub(crate) waiting: HashSet<WidgetId>,
 }
 
 impl Widgets {
-    pub fn new(send: Sender<WidgetId>) -> Self {
+    pub fn new() -> Self {
+        let (send, recv) = channel();
         Self {
             needs_redraw: Default::default(),
             vec: Default::default(),
             waiting: Default::default(),
             send,
+            recv,
         }
     }
 
@@ -61,25 +64,27 @@ impl Widgets {
         self.get_dyn_mut(id.id())?.as_any_mut().downcast_mut()
     }
 
-    pub fn add_strong<W: Widget>(&mut self, widget: W) -> WidgetHandle<W> {
+    pub fn add_strong<W: Widget>(&mut self, widget: W) -> StrongWidget<W> {
         let id = self.vec.add(WidgetData::new(widget));
-        WidgetHandle::new(id, self.send.clone())
+        StrongWidget::new(id, self.send.clone())
     }
 
-    pub fn add_weak<W: Widget>(&mut self, widget: W) -> WidgetRef<W> {
+    pub fn add_weak<W: Widget>(&mut self, widget: W) -> WeakWidget<W> {
         let id = self.vec.add(WidgetData::new(widget));
         self.waiting.insert(id);
-        WidgetRef::new(id)
+        WeakWidget::new(id)
     }
 
     #[track_caller]
-    pub fn upgrade<W: ?Sized>(&mut self, rf: WidgetRef<W>) -> WidgetHandle<W> {
+    pub fn upgrade<W: ?Sized>(&mut self, rf: WeakWidget<W>) -> StrongWidget<W> {
         if !self.waiting.remove(&rf.id()) {
             let label = self.label(rf);
             let id = rf.id();
-            panic!("widget '{label}' ({id:?}) was already added\ncannot add a widget twice; consider creating two")
+            panic!(
+                "widget '{label}' ({id:?}) was already added\ncannot add a widget twice; consider creating two"
+            )
         }
-        WidgetHandle::new(rf.id(), self.send.clone())
+        StrongWidget::new(rf.id(), self.send.clone())
     }
 
     pub fn data(&self, id: impl IdLike) -> Option<&WidgetData> {
@@ -90,14 +95,19 @@ impl Widgets {
         &self.data(id.id()).unwrap().label
     }
 
+    /// useful for debugging
+    pub fn set_label(&mut self, id: impl IdLike, label: String) {
+        self.data_mut(id.id()).unwrap().label = label;
+    }
+
     pub fn data_mut(&mut self, id: impl IdLike) -> Option<&mut WidgetData> {
         self.vec.get_mut(id.id())
     }
 
-    pub fn delete(&mut self, id: impl IdLike) {
-        self.vec.free(id.id());
-        // not sure if there's any point in this
-        // self.updates.remove(&id);
+    pub fn free(&mut self) {
+        for id in self.recv.try_iter() {
+            self.vec.free(id.id());
+        }
     }
 
     #[allow(clippy::len_without_is_empty)]
@@ -106,4 +116,30 @@ impl Widgets {
     }
 }
 
+impl Default for Widgets {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 pub type WidgetWrapper<'a> = DynBorrower<'a, dyn Widget>;
+
+impl<I: IdLike> std::ops::Index<I> for Widgets
+where
+    I::Widget: Sized + Widget,
+{
+    type Output = I::Widget;
+
+    fn index(&self, id: I) -> &Self::Output {
+        self.get(&id).unwrap()
+    }
+}
+
+impl<I: IdLike> std::ops::IndexMut<I> for Widgets
+where
+    I::Widget: Sized + Widget,
+{
+    fn index_mut(&mut self, id: I) -> &mut Self::Output {
+        self.get_mut(&id).unwrap()
+    }
+}